Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61396081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61396080
[Test build #22742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22742/consoleFull)
for PR 3032 at commit
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19710069
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,30 @@ object ShuffleBlockFetcherIterator {
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61396504
How about now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19710088
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,30 @@ object ShuffleBlockFetcherIterator {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61396600
[Test build #22753 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22753/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61396730
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19710231
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,18 @@ private[hash] object
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19710310
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,18 @@ private[hash] object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61397587
[Test build #22757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22757/consoleFull)
for PR 3032 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61398052
[Test build #22753 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22753/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61398055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61400137
**[Test build #22757 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22757/consoleFull)**
for PR 3032 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61418385
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61418515
[Test build #22764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22764/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61423148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61423147
**[Test build #22764 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22764/consoleFull)**
for PR 3032 at commit
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19715256
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,21 +53,21 @@ private[hash] object
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19715279
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
@@ -30,13 +31,20 @@ private[spark] class FetchFailedException(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19715284
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1060,7 +1060,7 @@ class DAGScheduler(
if
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19715295
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
@@ -46,7 +54,7 @@ private[spark] class MetadataFetchFailedException(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19718354
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,21 +53,21 @@ private[hash] object
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19718379
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1060,7 +1060,7 @@ class DAGScheduler(
if
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19719128
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,21 +53,21 @@ private[hash] object
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61441682
New screenshots for current codes.
Stages page:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61441696
[Test build #22800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22800/consoleFull)
for PR 3032 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19719301
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,21 +53,21 @@ private[hash] object
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61442041
LGTM, will merge as soon as Jenkins passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61446009
Merging into master. Thanks for this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702059
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
@@ -30,13 +31,15 @@ private[spark] class FetchFailedException(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702103
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,19 @@ private[hash] object
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702114
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -107,7 +107,7 @@ class JsonProtocolSuite extends FunSuite {
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702216
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1060,7 +1060,7 @@ class DAGScheduler(
if
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702219
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -69,11 +69,13 @@ case class FetchFailed(
bmAddress: BlockManagerId, //
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702223
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -627,7 +628,9 @@ private[spark] object JsonProtocol {
val
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702231
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,30 @@ object ShuffleBlockFetcherIterator {
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19702235
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,30 @@ object ShuffleBlockFetcherIterator {
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61361054
LGTM, only had superficial comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61373259
@aarondav thanks for reviewing it. Updated as per your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19705166
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,30 @@ object ShuffleBlockFetcherIterator {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61373383
[Test build #22696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22696/consoleFull)
for PR 3032 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61376273
[Test build #22696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22696/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61376279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19706108
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,29 @@ object ShuffleBlockFetcherIterator {
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19706121
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,18 @@ private[hash] object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61394707
[Test build #22742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22742/consoleFull)
for PR 3032 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19709864
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,18 @@ private[hash] object
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19709867
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,14 +319,29 @@ object ShuffleBlockFetcherIterator {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3032#discussion_r19709873
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -52,18 +53,18 @@ private[hash] object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61227899
[Test build #22600 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22600/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61227902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61358019
[Test build #22681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22681/consoleFull)
for PR 3032 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61358931
[Test build #22681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22681/consoleFull)
for PR 3032 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3032#issuecomment-61358932
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
55 matches
Mail list logo
