Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-88195603
LGTM Thanks very much for bearing with the issues in getting this in!
Merging into master
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87811886
@leahmcguire Thanks for updating the enum type. I just made 2 tiny
comments; other than that, it looks fine.
---
If your project is set up for it, you can reply to
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r27426348
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -264,16 +373,42 @@ object NaiveBayes {
/**
*
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r27426350
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -177,10 +257,27 @@ class NaiveBayes private (private var
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87914318
[Test build #29438 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29438/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87914345
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87894803
[Test build #29438 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29438/consoleFull)
for PR 4087 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87079594
If you have time, I'd really appreciate it---thank you! We can eliminate
the special enum-like types entirely and just use String.
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87153735
[Test build #29336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29336/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87160155
[Test build #29336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29336/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-87160157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-86185401
LGMT I'll merge this into master. Thank you for the PR! I'll make a JIRA
for the Python API.
---
If your project is set up for it, you can reply to this email and
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-86187804
(I was about to merge this, but then this issue came up.) After that
adjustment, it should be fine. (And feel free to make this change yourself,
but I'm offering to
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-86187492
So...that discussion on the mailing list about enum-like types just keeps
going with no decision yet. Speaking with @mengxr , it might be best to
support only String
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-86292839
Either version is fine. If you have time to make the change on tomorrow go
ahead and send the PR. Otherwise I'll have time to make the change on
Friday.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-85735012
[Test build #29119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29119/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-85758296
[Test build #29119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29119/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-85758331
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-84175879
@leahmcguire It looks like the unclean merge came from the PR earlier
today for adding Python save/load. I think rebasing and fixing conflicts
should be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-84220898
[Test build #28936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28936/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-84214070
[Test build #28936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28936/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-84220913
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-82025636
[Test build #28685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28685/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-82072739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26542594
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26543828
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-82072732
[Test build #28685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28685/consoleFull)
for PR 4087 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26439272
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26439275
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26439273
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-80565896
Thanks for the updates again! I responded inline to those 2 comments above.
I'll write up something for the model versioning and send a PR.
---
If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26439278
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -166,6 +196,14 @@ class NaiveBayes private (private var
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169291
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +90,87 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169235
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78618223
[Test build #28535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28535/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78618243
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78584985
[Test build #28527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28527/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78585010
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78591015
[Test build #28535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28535/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78552225
[Test build #28527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28527/consoleFull)
for PR 4087 at commit
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26347821
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26256579
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26258688
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78381145
@jkbradley thanks for the comments! I have implemented everything except
the two inline comments that I replied to directly.
I'm not clear about how you want the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78389593
[Test build #28485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28485/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78400178
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78400160
[Test build #28485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28485/consoleFull)
for PR 4087 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169197
--- Diff: docs/mllib-naive-bayes.md ---
@@ -13,12 +13,15 @@ compute the conditional probability distribution of
label given an observation
and use it
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169266
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169284
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169237
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169251
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -166,6 +196,13 @@ class NaiveBayes private (private var
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169241
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169287
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -41,37 +44,39 @@ object NaiveBayesSuite {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169280
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78154960
@leahmcguire Thank you for the updates! Most of the comments I just added
are minor, so hopefully this will be the last round.
---
If your project is set up for it,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169281
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169193
--- Diff: docs/mllib-naive-bayes.md ---
@@ -13,12 +13,15 @@ compute the conditional probability distribution of
label given an observation
and use it
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26169233
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame,
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78171348
I forgot to say: With respect to model save/load, would you like for me to
push a PR to your PR to add a new version, or will you do that?
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77936979
[Test build #28402 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28402/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77952686
[Test build #28402 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28402/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77952703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77914436
@leahmcguire By the way, there's an ongoing discussion on the dev list
about how to specify enum types:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77667987
[Test build #28361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28361/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77665465
[Test build #28361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28361/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77667991
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77435497
I made all the inline fixes and integrated the model type fix. If you can
provide me with a bit more guidance on the save/load I am happy to do it.
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77439573
[Test build #28306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28306/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77439367
[Test build #28306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28306/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77439577
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77435746
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77438045
[Test build #28303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28303/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77435740
[Test build #28304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28304/consoleFull)
for PR 4087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77435559
[Test build #28304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28304/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77438052
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77468934
[Test build #28316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28316/consoleFull)
for PR 4087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77468944
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77429331
[Test build #28303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28303/consoleFull)
for PR 4087 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727352
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +92,66 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727333
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +52,27 @@ import org.apache.spark.sql.{DataFrame,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727349
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +92,66 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77047237
I'm trying to see if there's a better solution for the NaiveBayesModelType
which will permit the same API in both Scala Java. I'll update soon.
---
If your project
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727329
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -17,17 +17,34 @@
package
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727335
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -66,11 +84,18 @@ class NaiveBayesModel private[mllib] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727343
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +191,12 @@ object NaiveBayesModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727348
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +92,66 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727332
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +52,27 @@ import org.apache.spark.sql.{DataFrame,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727350
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +92,66 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727354
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -85,19 +92,66 @@ class NaiveBayesSuite extends FunSuite
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77037995
@leahmcguire Thanks for the update! I've added some inline comments, plus
a few larger items below.
Java compatibility
The NaiveBayesModels
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727327
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -17,17 +17,34 @@
package
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727338
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -89,7 +114,10 @@ object NaiveBayesModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25727344
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +311,25 @@ object NaiveBayes {
def train(input:
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77061183
I found a better option with help from @mengxr
I'll push it as a PR to your branch; feel free to use the changes by
merging or by copying just what you need.
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-76779195
[Test build #28179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28179/consoleFull)
for PR 4087 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-76763940
Thanks for fixing the merge issue! The MIMA test failure is from the
constructor for NaiveBayesModel having changed. To fix that, I'd recommend
adding another
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-76428527
[Test build #28075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28075/consoleFull)
for PR 4087 at commit
1 - 100 of 134 matches
Mail list logo
