Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-57974280
@nchammas that page won't appear until we actually update the live docs
(something that happens for each release rather than when a push a PR)
---
If your project is
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17668529
--- Diff: CONTRIBUTING.md ---
@@ -0,0 +1,12 @@
+## Contributing to Spark
--- End diff --
Having this is pretty nice! I like the banner you
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55717325
@pwendell no I believe that the user still has to install the gem. I did at
least. Yes this is GTG from my end.
---
If your project is set up for it, you can reply to
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55768975
Okay I can merge this. One thing though, we've typically had
less-than-smooth experiences with jekyll and its dependencies. So if this
feature causes issues for users
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55770066
FYI: This page is 404-ing:
http://spark.apache.org/docs/latest/building-spark.html
Is that temporary?
---
If your project is set up for it, you can reply to
I imagine the new site hasn't been pushed. Yeah, the README.md has the
new links immediately though. It's a minor and temporary, since I
believe the site was going to be updated to fix that 1.1.0-SNAPSHOT
ref anyway.
On Tue, Sep 16, 2014 at 5:24 PM, nchammas g...@git.apache.org wrote:
Github
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55598514
@andrewor14 @nchammas @pwendell Humble ping on this one, I think it's good
to go, and probably helps head off some build questions going forward.
---
If your project is
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17546110
--- Diff: docs/building-spark.md ---
@@ -159,4 +160,13 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
The
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17546414
--- Diff: docs/building-spark.md ---
@@ -159,4 +160,13 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
The
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17547220
--- Diff: docs/building-spark.md ---
@@ -159,4 +160,13 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
The
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55609759
There really should be at least some mention of zinc
(https://github.com/typesafehub/zinc) in our maven build instructions, since
using zinc greatly improves the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55609958
Yes, the build already warns if zinc is not being used.
To keep this scoped, I suggest that could be handled separately if more
docs were desired about zinc.
---
If
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55611558
Yes, I know that the scala-maven-plugin will throw warnings if zinc isn't
being used. I also know that many users are either confused by those warnings
or ignore
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17564257
--- Diff: docs/building-spark.md ---
@@ -159,4 +160,13 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
The
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55661991
@pwendell I changed to `sbt/sbt`, and @markhamstra I took the liberty of
adding a note on `zinc` while we're at it.
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55662640
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20353/consoleFull)
for PR 2014 at commit
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17570971
--- Diff: docs/building-spark.md ---
@@ -159,4 +160,21 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
The
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55664791
@markhamstra Nice one, change coming up...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55665680
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20354/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55672401
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20354/consoleFull)
for PR 2014 at commit
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17583504
--- Diff: docs/_config.yml ---
@@ -1,5 +1,7 @@
-pygments: true
+highlighter: pygments
markdown: kramdown
+gems:
+ -
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55695994
@srowen are you planning to add more to this or is it GTG from your
perspective?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17472638
--- Diff: README.md ---
@@ -66,78 +69,24 @@ Many of the example programs print usage help if no
params are given.
## Running Tests
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55386674
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20226/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-55391607
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20226/consoleFull)
for PR 2014 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17458463
--- Diff: README.md ---
@@ -13,16 +13,19 @@ and Spark Streaming.
## Online Documentation
You can find the latest Spark documentation,
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17458522
--- Diff: README.md ---
@@ -66,78 +69,24 @@ Many of the example programs print usage help if no
params are given.
## Running Tests
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r17458717
--- Diff: README.md ---
@@ -13,16 +13,19 @@ and Spark Streaming.
## Online Documentation
You can find the latest Spark documentation,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54790978
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19968/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54797341
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19968/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54141725
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19589/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54147529
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19589/consoleFull)
for PR 2014 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54147642
(Test failure looks spurious -- it's in the Python code and no code was
touched in this PR.)
---
If your project is set up for it, you can reply to this email and have
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-54103445
@srowen what about adding a redirect? As a stupid-simple approach, we could
just have the old page there and do a javascript based redirect by setting
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16968179
--- Diff: docs/building-with-maven.md ---
@@ -159,4 +159,8 @@ then ship it over to the cluster. We are investigating
the exact cause for this.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53981717
OK will add back the TL;DR build instructions, and keep the wiki link for
completeness.
@pwendell I'll update the Building with Maven doc too, but do you want me
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53992523
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19538/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53994367
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19538/consoleFull)
for PR 2014 at commit
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16936253
--- Diff: CONTRIBUTING.md ---
@@ -0,0 +1,12 @@
+## Contributing to Spark
--- End diff --
@pwendell Perhaps for a future PR: What do you
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16933031
--- Diff: CONTRIBUTING.md ---
@@ -0,0 +1,12 @@
+## Contributing to Spark
--- End diff --
Yeah, seems fine to have this here. It might make
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16933034
--- Diff: README.md ---
@@ -66,78 +69,24 @@ Many of the example programs print usage help if no
params are given.
## Running Tests
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16933038
--- Diff: README.md ---
@@ -66,78 +69,24 @@ Many of the example programs print usage help if no
params are given.
## Running Tests
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53977940
Made a few comments inline. On building docs, my favorite idea is just to
have the README link to the upstream docs, and then change the upstream docs to
be called
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53717258
@nchammas @pwendell Is the net conclusion that `README.md` should use Maven
if anything?
I'd be happy to move the wiki into `CONTRIBUTING.md` but then I can't
remove
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53775856
Is the net conclusion that README.md should use Maven if anything?
Not sure. It sounds like Maven is indeed in the official standard for
building Spark, but we
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53565824
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19309/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53572164
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19309/consoleFull)
for PR 2014 at commit
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16796104
--- Diff: README.md ---
@@ -13,16 +13,19 @@ and Spark Streaming.
## Online Documentation
You can find the latest Spark documentation,
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16796412
--- Diff: README.md ---
@@ -66,78 +69,24 @@ Many of the example programs print usage help if no
params are given.
## Running Tests
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2014#discussion_r16796890
--- Diff: CONTRIBUTING.md ---
@@ -0,0 +1,12 @@
+## Contributing to Spark
--- End diff --
@srowen I think it's a good idea to have a
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53626165
Just wanted to point out that `make-distribution.sh` uses Maven.
Also, we have features available in the Maven build (e.g. Guava shading)
that were intentionally
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53638059
`make-distribution.sh` uses Maven.
Oh, good point. Erm... I guess we need one of the project maintainers to
step in then and clarify the place of `sbt`
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53644873
Yeah so our position on the builds is that we officially recommend Maven
for packaging spark but we support sbt for day-to-day development since it can
provide much
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53645224
@nchammas there is a bit more color in this thread:
http://apache-spark-developers-list.1001551.n3.nabble.com/Assorted-project-updates-tests-build-etc-td7063.html
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53646263
Ah, thanks for that. Clears things up for me about `sbt` vs. Maven.
So if we want to stress Maven as the standard, where would we move the
`sbt`-related
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53147889
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19102/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53148101
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19103/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53148996
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19102/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53149241
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19103/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53157117
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19108/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-53158753
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19108/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-52907543
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19051/consoleFull)
for PR 2014 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-52911412
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19051/consoleFull)
for PR 2014 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-52912040
Ha, false positive. It picked up a line of text in `README.md` that
contains a class declaration. Maybe the checker can avoid known non-source
extensions. The unit test
Github user bbossy commented on the pull request:
https://github.com/apache/spark/pull/2014#issuecomment-52769500
Yes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/2014
SPARK-3069 [DOCS] Build instructions in README are outdated
Here's my crack at Bertrand's suggestion. The Github `README.md` contains
build info that's outdated. It should just point to the current
67 matches
Mail list logo
