[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah closed the pull request at: https://github.com/apache/spark/pull/2984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-68417417 If this PR is not useful any more, mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user msgehard commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-63396251 Hello all. I am wondering if there is any known ETA for allowing newer versions of Jetty (specifically Jetty9) to be used in apps that embed Spark and not hurting Spark similar to what @ash211 mentioned. Thanks for all of the hard work on Spark. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-63396867 That is what this PR is trying to address, but it is superceded by another PR now. https://github.com/apache/spark/issues/3130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user msgehard commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-63397585 @mccheah Thanks for pointing to the new pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61781966 Hey @vanzin I was actually thinking that over time we might shade a handful of things in addition to guava. The user classpath first is at best a partial solution (and I agree, we should try to make that actually work correctly) because it only deals with cases where either Spark or the application don't actually use conflicting parts of a library. In many cases, there is a legitimate conflict, especially with libraries like jetty that are widely used. In these cases it seems like shading the dependency is the only real answer, because Spark and user code need to exist in the same JVM - and even in the same threads - at the same time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61930885 Hey I took a look at this and had a few observations. This example is actually a bit different from what we were trying to do with Gauva, so it's not possible to directly pattern match - I might have lead @mccheah astray slightly with that advice. 1. This spends a lot of effort to make jetty provided and then escalate it to compile scope. I think this can all be removed in favor of just leaving at at compile scope. Since we publish effective poms now, jetty will simply be removed from the pom that is published (it won't have any scope since it won't be present as a dependency). That can remove a lot of code. 2. This approach doesn't actually relocate the jetty classes, it just inlines them in the spark-core jar. This won't help people who have dependency conflicts with jetty. ``` jar -tf spark-core_2.10-1.2.0-SNAPSHOT.jar |grep jetty | head -n 10 org/eclipse/jetty/ org/eclipse/jetty/plus/ org/eclipse/jetty/plus/servlet/ org/eclipse/jetty/plus/servlet/ServletHandler.class org/eclipse/jetty/plus/webapp/ org/eclipse/jetty/plus/webapp/PlusDescriptorProcessor$1.class org/eclipse/jetty/plus/webapp/PlusDescriptorProcessor.class org/eclipse/jetty/plus/webapp/PlusDecorator.class org/eclipse/jetty/plus/webapp/PlusConfiguration.class org/eclipse/jetty/plus/webapp/EnvConfiguration$1.class ``` I'll see if I can send a patch that does this in a different way. We can then use that as the example for any future things we shade. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61931505 Hey actually I'm gonna scratch my earlier comment and spend a bit more time playing with this to understand how this works in guava. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61582083 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61582421 [Test build #22847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22847/consoleFull) for PR 2984 at commit [`c28f57e`](https://github.com/apache/spark/commit/c28f57e7096ec8e21e546bebf6f8a1a525a1fecf). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61588577 [Test build #22847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22847/consoleFull) for PR 2984 at commit [`c28f57e`](https://github.com/apache/spark/commit/c28f57e7096ec8e21e546bebf6f8a1a525a1fecf). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61588579 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22847/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61301013 Requesting an update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61305361 @mccheah people are probably busy with the upcoming 1.2 code freeze, so I wouldn't expect a lot of activity on PRs that are not critical for 1.2 at this point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61339002 Except we also need this to get into 1.2. Can we get this bumped up to be merged in for that release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-61133142 Any update on this? @JoshRosen @pwendell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60958313 @ash211, ah, I see, so that's why SparkSubmit doesn't do anything with it. :-) In any case, I don't see the harm of extending it to the driver also, after all, it's still part of the application and can still have conflicts with the rest of Spark. But that's propably better discussed separately from this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60968644 It's sounding like Spark's dependency tree is so large that we eventually want a solution that prevents any collision at all whatsoever; a holistic solution, if you will. But I agree - outside the scope of this PR. Any more comments on this, or can it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
GitHub user mccheah opened a pull request: https://github.com/apache/spark/pull/2984 Shading the Jetty dependency. Jetty is a common dependency in projects. Spark is sensitive to the version of Jetty that is used, but version conflicts should be avoided. Shading Jetty in a similar manner to how Guava was shaded solves that problem. I did the shading in exactly the same way that Guava was shaded. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mccheah/spark shading-jetty Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2984.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2984 commit 25c9e73e0e1a25292f34a3738e9425093d99d5ca Author: mcheah mch...@palantir.com Date: 2014-10-27T22:26:55Z Shading the Jetty dependency. Jetty is a common dependency in projects. Spark is sensitive to the version of Jetty that is used, but version conflicts should be avoided. Shading Jetty in a similar manner to how Guava was shaded solves that problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60848427 Broken for now, investigating --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60848381 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22391/consoleFull) for PR 2984 at commit [`25c9e73`](https://github.com/apache/spark/commit/25c9e73e0e1a25292f34a3738e9425093d99d5ca). * This patch **does not merge cleanly**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60848646 [Test build #22392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22392/consoleFull) for PR 2984 at commit [`2507592`](https://github.com/apache/spark/commit/250759202184f9b626b81ce2df4869a7a37c63ba). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60849409 False alarm. This should be okay for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60849659 I wanted to comment on the bug after I investigated some things, but since you filed a PR, let me comment here... I don't think this is a good long term solution (yeah, I know, ironic from the guy who worked on the Guava shading thing :-)). I think the right (or, let's say, better) way to do this is to actually make `spark.files.userClassPathFirst` work. The goal of that setting is to make the user's classpath run in a separate class loader from the Spark classes. So you'd package your app with your jetty, and turn on that setting; your app's classes would come from this separate class loader, and Spark classes would come from the system one. Your app would see your Jetty, Spark would see its own. All without shading. (There are caveats, but it should mostly work. Hadoop/MR has something similar to this, too.) The problem is that setting seems to be sort of broken. It's definitely broken in any client mode, since SparkSubmit.scala doesn't seem to be doing the right thing. And it's definitely broken in Yarn, since it's completely ignored there... In any case, long term, I think the class loader isolation thing is a better way to go, otherwise we'll have to start changing the Spark build every time someone wants to use a different version of some library... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60850543 @vanzin Is there a slated timeline for spark.files.userClassPathFirst to be done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60851079 I'm taking a look at fixing it for Yarn (which means it will also most probably also fixing SparkSubmit), but it should take me at least a few more days to get the code ready and things tested... I'm sort of ok with going forward with this patch, as long as we're sure that shading jetty works as expected (jetty does a lot of class loading based on class names, which doesn't work well with shading). But we should revert this (and potentially even the Guava one) if we get that setting working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60856770 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22392/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60856764 [Test build #22392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22392/consoleFull) for PR 2984 at commit [`2507592`](https://github.com/apache/spark/commit/250759202184f9b626b81ce2df4869a7a37c63ba). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60857662 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22391/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60857659 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22391/consoleFull) for PR 2984 at commit [`25c9e73`](https://github.com/apache/spark/commit/25c9e73e0e1a25292f34a3738e9425093d99d5ca). * This patch **passes all tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60859256 @JoshRosen any comments? I know you've participated in the dependency discussion in the past. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Shading the Jetty dependency.
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/2984#issuecomment-60862101 One motivation for this change is to support wrapping an application-specific REST API around Spark using the Dropwizard webapp framework, which is using Jetty 9. @vanzin is `spark.files.userClassPathFirst` intended to work when the classpath conflict in question isn't on the executor -- it's actually in the driver? The docs on http://spark.apache.org/docs/latest/configuration.html suggest that it's intended for handling executor classpath conflicts, not driver conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
