Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r85922961
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -137,7 +137,7 @@ object ColumnStatStruct {
p
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r85839282
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -137,7 +137,7 @@ object ColumnStatStruct {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r79028863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78928177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(ch
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78900571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(child
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78899346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(ch
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78891139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(child
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78360821
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,41 @@ class AnalysisSuite extends Analysi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r78359970
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,41 @@ class AnalysisSuite extends Anal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77935222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,34 @@ case class CreateMap(ch
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77589555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,34 @@ case class CreateMap(child
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77588679
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -243,8 +243,8 @@ class ComplexTypeSuite exte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77588612
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,41 @@ class AnalysisSuite extends Anal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77588295
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,41 @@ class AnalysisSuite extends Anal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77587859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -652,11 +652,18 @@ class Analyzer(
cas
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77587010
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,34 @@ case class CreateMap(ch
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77586697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,34 @@ case class CreateMap(ch
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77552578
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -124,6 +124,9 @@ class CodeGenerationSui
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r77552582
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -174,6 +174,9 @@ class ComplexTypeSuite ext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76667084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r7950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76663726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76663187
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
---
@@ -174,7 +174,10 @@ class ComplexTypeSuite ex
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76663119
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -124,7 +124,12 @@ class CodeGenerationSu
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76663028
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Ana
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76662951
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76662599
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76657914
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76657836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76657472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r76656778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -172,60 +172,47 @@ case class CreateMap(c
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73788331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1101,7 +1101,7 @@ class AstBuilder extends SqlBaseBaseVis
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73701323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -669,7 +669,7 @@ class AstBuilder extends SqlBaseBaseVisit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73468912
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Anal
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73353314
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Analysi
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73352680
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Analysi
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73352019
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Analysi
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73351502
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends Analysi
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73351287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases extends Rule[Lo
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73350996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases extends Rule[Lo
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73350871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extends Rule[L
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337483
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337237
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337186
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337136
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337012
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337074
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -25,7 +27,8 @@ import org.apache.spark.sql.ca
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73336967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extend
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73112000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extends Rule[L
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73105110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extends Rul
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73103369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extends Rule[L
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73102639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions extends Rul
GitHub user eyalfa opened a pull request:
https://github.com/apache/spark/pull/1
[SPARK-16839] [SQL] redundant aliases after cleanupAliases
## What changes were proposed in this pull request?
a failing test, soon to add a proposed fix
## How was this patch tested?
55 matches
Mail list logo
