Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18576
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r178411933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroupExp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r178243412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroup
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r177782600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroupExp
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r177694451
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroupExp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r177674483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroup
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r177671867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1309,3 +1311,20 @@ object RemoveRepetitionFromGroup
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r136211188
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -120,7 +120,25 @@ case class Generate(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r136210112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -120,7 +120,25 @@ case class Generate(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r135983831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -120,7 +120,25 @@ case class Genera
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r135982647
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -120,7 +120,25 @@ case class Genera
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r131573104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -94,27 +94,14 @@ case class FilterExec(condition: Expre
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126345144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -132,7 +132,9 @@ abstract class Optimizer(sessionCatalo
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126344026
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UpdateNullabilityInAttributeReferencesSuite.scala
---
@@ -0,0 +1,53 @@
+/*
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126343168
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UpdateNullabilityInAttributeReferencesSuite.scala
---
@@ -0,0 +1,53 @@
+/*
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126342208
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UpdateNullabilityInAttributeReferencesSuite.scala
---
@@ -0,0 +1,53 @@
+/*
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126339942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -132,7 +132,9 @@ abstract class Optimizer(sessionCatalog
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r126339215
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UpdateNullabilityInAttributeReferencesSuite.scala
---
@@ -0,0 +1,53 @@
+/*
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/18576
[SPARK-21351][SQL] Update nullability based on children's output
## What changes were proposed in this pull request?
This pr added a new optimizer rule `UpdateNullabilityInAttributeReferences
`
19 matches
Mail list logo
