Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20710
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172321800
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -48,6 +48,9 @@
*
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172319605
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -48,6 +48,9 @@
* same
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172306573
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -172,18 +173,22 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172303450
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java
---
@@ -39,21 +36,21 @@
* If this method
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172303088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -172,18 +173,22 @@ object
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172265884
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -31,13 +31,17 @@
* the {@link #write(Object)},
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r172081660
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -31,13 +31,17 @@
* the {@link #write(Object)}, {@link
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993983
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java
---
@@ -39,21 +36,21 @@
* If this method fails
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993716
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -48,6 +48,9 @@
* same task
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993622
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -48,6 +48,9 @@
* same task
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993559
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -36,8 +36,9 @@
* {@link
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993519
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -36,8 +36,9 @@
* {@link
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993467
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -36,8 +36,9 @@
* {@link
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -172,17 +173,19 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -198,7 +201,7 @@ object DataWritingSparkTask
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20710#discussion_r171993066
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -48,6 +48,9 @@
* same task
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20710
[SPARK-23559][SS] Add epoch ID to DataWriterFactory.
## What changes were proposed in this pull request?
Add an epoch ID argument to DataWriterFactory for use in streaming. As
18 matches
Mail list logo
