[GitHub] spark pull request #20780: [MINOR] [SQL] [TEST] Create table using `dataSour...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20780


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20780: [MINOR] [SQL] [TEST] Create table using `dataSour...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/20780#discussion_r173366467
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala 
---
@@ -335,7 +335,7 @@ abstract class HadoopFsRelationTest extends QueryTest 
with SQLTestUtils with Tes
 
   test("saveAsTable()/load() - non-partitioned table - ErrorIfExists") {
 withTable("t") {
-  sql("CREATE TABLE t(i INT) USING parquet")
+  sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
   intercept[AnalysisException] {
 
testDF.write.format(dataSourceName).mode(SaveMode.ErrorIfExists).saveAsTable("t")
   }
--- End diff --

Could you add an error message check logic here explicitly?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20780: [MINOR] [SQL] [TEST] Create table using `dataSour...

[jiangxb1987]

GitHub user jiangxb1987 opened a pull request:

https://github.com/apache/spark/pull/20780

[MINOR] [SQL] [TEST] Create table using `dataSourceName` in 
`HadoopFsRelationTest`

## What changes were proposed in this pull request?

This PR fixes a minor issue in `HadoopFsRelationTest`, that you should 
create table using `dataSourceName` instead of `parquet`. The issue won't 
affect the correctness, but it will generate wrong error message in case the 
test fails.

## How was this patch tested?

Exsiting tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jiangxb1987/spark dataSourceName

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20780


commit 29fd5a8f1b065f50d324389c2d796e93a3a8844d
Author: Xingbo Jiang 
Date:   2018-03-09T03:58:37Z

create table using dataSourceName




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org