[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21024 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r181300040 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,67 @@ case class ArrayCont

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r181085033 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,68 @@ case class ArrayContains

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-11 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180892505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,70 @@ case class ArrayContai

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180784794 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,70 @@ case class ArrayContains(

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180783601 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,70 @@ case class ArrayContains(

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180414332 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class ArrayContai

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180403822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class ArrayContains

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21024#discussion_r180387495 --- Diff: python/pyspark/sql/functions.py --- @@ -2080,6 +2080,21 @@ def size(col): return Column(sc._jvm.functions.size(_to_java_column(col)))

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21024 [SPARK-23917][SQL] Add array_max function ## What changes were proposed in this pull request? The PR adds the SQL function `array_max`. It takes an array as argument and returns the maxim