Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21346
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r198236456
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r198233111
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r196558660
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,59 @@ public void onFailure(Throwable e)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195819256
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,59 @@ public void onFailure(Throwable e)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195819061
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,59 @@ public void onFailure(Throwable e)
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195796301
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195795803
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,60 @@ public void onFailure(Throwable e)
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195788253
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -216,34 +192,99 @@ public long sendRpc(ByteBuffer
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195287202
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195592355
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195591573
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195588878
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -203,6 +197,76 @@ public void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195592205
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195592158
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195586580
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -216,34 +192,99 @@ public long sendRpc(ByteBuffer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195590730
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,60 @@ public void onFailure(Throwable e)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195584408
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195585864
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -216,34 +192,99 @@ public long sendRpc(ByteBuffer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195584794
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -216,34 +192,99 @@ public long sendRpc(ByteBuffer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195591438
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195464933
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,28 @@
*
* This method will
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195464525
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -220,30 +196,91 @@ public long sendRpc(ByteBuffer
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195284967
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -220,30 +196,91 @@ public long sendRpc(ByteBuffer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192825636
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,28 @@
*
* This method will
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192823558
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,9 @@ object MimaExcludes {
// Exclude rules for 2.4.x
lazy val v24excludes =
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192797087
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,28 @@
*
* This method will
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192795662
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method will
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192566116
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192565980
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192565530
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191981552
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method will
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191979425
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191979019
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191978545
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191978140
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/StreamInterceptor.java
---
@@ -50,16 +52,22 @@
@Override
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191976952
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamData.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191964329
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,9 @@ object MimaExcludes {
// Exclude rules for 2.4.x
lazy val v24excludes =
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191941962
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamData.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191941503
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191940304
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191939431
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191938203
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191935821
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/StreamInterceptor.java
---
@@ -50,16 +52,22 @@
@Override
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191059478
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191001378
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -85,10 +96,52 @@ public void receive(TransportClient
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191002520
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -193,10 +299,78 @@ public void sendOneWayMessage()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191003869
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,9 @@ object MimaExcludes {
// Exclude rules for 2.4.x
lazy val v24excludes =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r190999338
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamData.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191003553
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/StreamTestHelper.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r190999775
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -23,25 +23,16 @@
import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191002393
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +183,59 @@ public void onFailure(Throwable e)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r190997078
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -244,6 +242,54 @@ public long sendRpc(ByteBuffer
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191001160
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -17,17 +17,21 @@
package
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r190998463
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method will
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r190997532
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191001733
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +183,59 @@ public void onFailure(Throwable e)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r188801902
--- Diff: project/MimaExcludes.scala ---
@@ -73,7 +73,10 @@ object MimaExcludes {
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/21346
[SPARK-6237][NETWORK] Network-layer changes to allow stream upload.
These changes allow an RPCHandler to receive an upload as a stream of
data, without having to buffer the entire message in the
59 matches
Mail list logo
