[GitHub] spark pull request #22081: [SPARK-23654][BUILD] remove jets3t as a dependenc...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22081 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22081: [SPARK-23654][BUILD] remove jets3t as a dependenc...
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/22081#discussion_r209707448
--- Diff: pom.xml ---
@@ -984,24 +987,15 @@
-
+
-net.java.dev.jets3t
-jets3t
-${jets3t.version}
+javax.activation
+activation
+1.1.1
--- End diff --
the reason for the activation is that it still comes in from somewhere and
the version pulled in drops from 1.1.1 to 1.1; meaning it'd be an accidental
downgrade of a JAR. I don't know exactly what uses javax.activation: it is one
of those historical artifacts whose main role, mapping mime types, is
potentially used somewhere important.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22081: [SPARK-23654][BUILD] remove jets3t as a dependenc...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22081#discussion_r209454764
--- Diff: pom.xml ---
@@ -984,24 +987,15 @@
-
+
-net.java.dev.jets3t
-jets3t
-${jets3t.version}
+javax.activation
+activation
+1.1.1
--- End diff --
Yeah really the change is to remove jets3t; I think Steve also thought it
necessary to add back javax.activation that it brought in but wasn't otherwise
depended-on by Hadoop. That is I think this patches a gap in the Hadoop pom?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22081: [SPARK-23654][BUILD] remove jets3t as a dependenc...
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22081#discussion_r209443568
--- Diff: pom.xml ---
@@ -984,24 +987,15 @@
-
+
-net.java.dev.jets3t
-jets3t
-${jets3t.version}
+javax.activation
+activation
+1.1.1
--- End diff --
this changes from `jets3t.version>0.9.4`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22081: [SPARK-23654][BUILD] remove jets3t as a dependenc...
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22081 [SPARK-23654][BUILD] remove jets3t as a dependency of spark ## What changes were proposed in this pull request? Remove jets3t dependency, and bouncy castle which it brings in; update licenses and deps Note this just takes over https://github.com/apache/spark/pull/21146 ## How was this patch tested? Existing tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/srowen/spark SPARK-23654 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22081 commit a222cb84fa7317e39e134c8233f3bebe596bf088 Author: Sean Owen Date: 2018-08-11T21:41:38Z Remove jets3t dependency, and bouncy castle which it brings in; update licenses and deps --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
