Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
LuciferYang commented on PR #45141: URL: https://github.com/apache/spark/pull/45141#issuecomment-1952216959 Thanks @srowen @dongjoon-hyun @HeartSaVioR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
LuciferYang commented on PR #45141: URL: https://github.com/apache/spark/pull/45141#issuecomment-1952216163 > +1, LGTM. > > Do we need this to branch-3.4, @LuciferYang ? No, does not need this patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
HeartSaVioR commented on PR #45141: URL: https://github.com/apache/spark/pull/45141#issuecomment-1949492132 Late +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
dongjoon-hyun closed pull request #45141: [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` URL: https://github.com/apache/spark/pull/45141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
dongjoon-hyun commented on PR #45141: URL: https://github.com/apache/spark/pull/45141#issuecomment-1948939396 Merged to branch-3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45357][CONNECT][TESTS][3.5] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]
LuciferYang commented on PR #45141: URL: https://github.com/apache/spark/pull/45141#issuecomment-1948673492 cc @HeartSaVioR @srowen @amaliujia Actually, I didn't reproduce this issue locally because when I use Maven to test the branch-3.5 `connect` module, the order of test case execution is `SparkConnectStreamingQueryCacheSuite`, `ExecuteEventsManagerSuite`, `SparkConnectProtoSuite`... and there are no `DataFrame` instances in `SparkConnectStreamingQueryCacheSuite` and `ExecuteEventsManagerSuite`. Therefore, `sparkTestRelation` in `SparkConnectProtoSuite` is still the first `DataFrame` to be initialized, its `id` is 0, which bypasses this issue. However, we can use some tricky methods to reproduce the failure. For example, change https://github.com/apache/spark/blob/1c1c5faa29dc649faf143fe2eea39ccf15862f85/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala#L90-L94 to ```scala test("Basic select") { val connectPlan = connectTestRelation.select("id".protoAttr) val sparkPlan = sparkTestRelation2.select("id") comparePlans(connectPlan, sparkPlan) } ``` In this way, `sparkTestRelation` will definitely not be the first `DataFrame` to be initialized, and the test failure can be reproduced, but `Basic select` will still pass the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org