Oh! Ok, that's why I didn't see a merge request. Cool, that's exactly how
it should be. :)
In other news, I finally figured out why the server kept crashing (on this
site). Someone put a match string in their inbox rules that doesn't compile
to a regular expression. regcomp() fails, and
That is not the branch that was merged. It is the new one to actually add
support for all the flags. I ran into some issues testing so I am working
on it locally. Should be updating the branch and submitting soon. Adding
the flags is a big change (hopefully for the better), but touches a lot
I also see that the `Support_IMAP_Flagged_Deleted_Draft_Recent_flags` branch
is still there. I thought it was going to get deleted in the merge. Mind
if I delete it?
I also have to make sure I'm not "squashing" multiple commits so they all
get their own commit log messages.
Thanks for
I am completely new to Git and commits, so I did not realize there was a
standard :-P
Thanks for the feedback and access. I'll now shut up and code :-)
I'm assuming you're familiar with the industry-wide standard for how to write
a commit message (summary line of 50 characters or less, then if you need
to type more, skip a line and then make the longer description lines of 72
characters or less).
If you're doing that in the commit message,
Ok. I have gotten my feet wet, so now I have a couple more questions. I
am trying not to be annoying, but I seem to be running into things that I am
not sure how to handle. Just let me know if I should shut up and code :-)
As you have seen, I have been creating rather long, detailed commit
libcitadel and webcit use the GNU Automake build system. That's why there's
a bootstrap program; it sets up the build environment on your build machine
so you can continue.
citadel (server), textclient, and webcit-ng use a much simpler build system,
one that doesn't rely on the GNU
The bootstrap was the part I was missing. Thanks.
For webcit, I am glad to hear that it is getting rewritten. At one point, I
tried to fix the calendar so it would work as an internet calendar in
Outlook, but after a bunch of work, it was not worth it. Got it talking to
Outlook, but then I
The patch looks good, and I'll go ahead and see if it applies cleanly. The
important thing is that it doesn't try to change too many things at the same
time, and you've documented what it is intended to do. That's really really
good.
By the way -- in case you haven't figured it
Submitting Code:
What you said makes very good sense. To try out submitting code, I cloned
down the citadel release, created a branch and made some updates to fix some
WebCit page issues and cleaned up a little formatting. Seemed like a simple
change to submit with low impact for a first try.
Ok, let me see if I can answer these questions one at a time.
git: at any given time, you'll want to be keeping up with the code in the
git repo. If you are developing against a released version of the code you
might have trouble integrating your changes.
That having been said, no
Thanks. Looking forward to it.
Great! I just want to answer quick and let you know I'll read through this
soon -- I'm super busy at work this week but I wanted to let you know these
questions *will* be answered. Give me a bit and I'll go through it. Thanks
for being interested in contributing!
13 matches
Mail list logo
