Re: [ros-dev] [ros-diffs] [fireball] 40368: - Compile UniATA with stdcall default calling convention instead of cdecl.

2009-04-05 Thread Alex Ionescu
Please don't do this. -MRTD has NOTHING to do with stdcall and has been broken since gcc 2.9.5 Best regards, Alex Ionescu On Sun, Apr 5, 2009 at 7:46 AM, wrote: > Author: fireball > Date: Sun Apr 5 15:46:53 2009 > New Revision: 40368 > > URL: http://svn.reactos.org/svn/re

Re: [ros-dev] Re : Year 2038 problem

2009-04-11 Thread Alex Ionescu
Again, since Ged wasn't clear: This is NT. NT does not use Unix time. Best regards, Alex Ionescu On Sat, Apr 11, 2009 at 6:52 PM, Sylvain Petreolle wrote: > I also noticed a funny thing browsing the year 2038 website : > http://www.2038bug.com/demo.html shows the first negative da

Re: [ros-dev] Re : Year 2038 problem

2009-04-11 Thread Alex Ionescu
Just to make the point clear: It will overflow on January 1st, 584942. Best regards, Alex Ionescu On Sat, Apr 11, 2009 at 10:08 PM, Alex Ionescu wrote: > Windows NT time is specified as the number of 100 nanosecond intervals > since January 1, 1601 > > Best regards, > Alex Ion

Re: [ros-dev] Re : Year 2038 problem

2009-04-11 Thread Alex Ionescu
Windows NT time is specified as the number of 100 nanosecond intervals since January 1, 1601 Best regards, Alex Ionescu On Sat, Apr 11, 2009 at 8:13 PM, King InuYasha wrote: > Then what DOES NT use to calculate time? > On Sat, Apr 11, 2009 at 9:34 PM, Alex Ionescu wrote: >> >

Re: [ros-dev] Using git for all ros source as main revision control

2009-04-12 Thread Alex Ionescu
Bazaar is a toy, I'm surprised you've "never heard" of anyone using hg... Also, see http://bitbucket.org/ Best regards, Alex Ionescu On Sun, Apr 12, 2009 at 10:38 AM, Michael B. Trausch wrote: > On Sun, 12 Apr 2009 01:13:47 -0500 > Zachary Gorden > wrote: > &

Re: [ros-dev] [ros-diffs] [janderwald] 40823: - Use a spinlock with list functions over interlocked list functions - Use a bitmap for storing reference count of the mappings as mapping are complete as

2009-05-07 Thread Alex Ionescu
RtlBitmap? Best regards, Alex Ionescu On Thu, May 7, 2009 at 12:58 AM, wrote: > Author: janderwald > Date: Thu May 7 02:58:57 2009 > New Revision: 40823 > > URL: http://svn.reactos.org/svn/reactos?rev=40823&view=rev > Log: > - Use a spinlock with list functions over i

Re: [ros-dev] Stubbing Block w TEB

2009-05-12 Thread Alex Ionescu
Looks like the CSRSS bug in Windows -- by setting this to NULL, something is probably trying to dereference it and crashes. What is the original value? Probably some bogus uninitialized variable that happens to be valid memory... Best regards, Alex Ionescu On Tue, May 12, 2009 at 7:03 AM

Re: [ros-dev] I want to develop the kernel of ReactOS, how do i join????

2009-05-17 Thread Alex Ionescu
ditionally, seen a source code base that encompasses the ENTIRE NT tree (winnt source leaks even have the CRT and boot loader in there, and the linker, nothing is safe!) needs to stay as far away from this project as possible. Best regards, Alex Ionescu On Sun, May 17, 2009 at 2:35 PM, Daniel Reimer &l

Re: [ros-dev] [ros-diffs] [fireball] 40961: - Initialize IoCountOperations variable to FALSE by default. Spotted by Dmitry Chapyshev & winetests.

2009-05-17 Thread Alex Ionescu
Um, there's a serious compiler/linker/loader bug if that value is not already FALSE by default. Best regards, Alex Ionescu On Sun, May 17, 2009 at 6:46 PM, wrote: > Author: fireball > Date: Sun May 17 20:46:58 2009 > New Revision: 40961 > > URL: http://svn.reactos.org/s

Re: [ros-dev] [ros-diffs] [tkreuzer] 40963: MmGrowKernelStack: Don't assert, but fail, when the kernel stack can't grow any more. Fixes a crash with recursive user calls. See issue #4060 for more deta

2009-05-17 Thread Alex Ionescu
The code SHOULD assert. This is a hack. Best regards, Alex Ionescu On Sun, May 17, 2009 at 11:51 PM, wrote: > Author: tkreuzer > Date: Mon May 18 01:51:31 2009 > New Revision: 40963 > > URL: http://svn.reactos.org/svn/reactos?rev=40963&view=rev > Log: > MmGrowKerne

Re: [ros-dev] I want to develop the kernel of ReactOS, how do i join????

2009-05-17 Thread Alex Ionescu
You should care because >50% of ReactOS code comes from Wine :) Best regards, Alex Ionescu On Sun, May 17, 2009 at 10:57 PM, Ged wrote: > James Tabor wrote: > > > Question should be, Where is the full discloser of the wine audit? > > Who cares? > Let's concentrate

Re: [ros-dev] [ros-diffs] [dchapyshev] 41042: - Formatting fix. No code change

2009-05-22 Thread Alex Ionescu
That's unfair, I don't think every other dev checks with anyone that might have pending patches. This is life. Best regards, Alex Ionescu On Fri, May 22, 2009 at 10:12 PM, Aleksey Bragin wrote: > I hope you asked James and Timo, who may have uncommitted patches to > this f

Re: [ros-dev] [ros-diffs] [cgutman] 41090: - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions - Sorry for so many commits on the same function

2009-05-24 Thread Alex Ionescu
May I ask, why not use simple C for this?: DriverBlock->DriverObject->MajorFunction = MajorFunctions; Or if that doesn't work, use a casting trick... Best regards, Alex Ionescu On Sun, May 24, 2009 at 2:49 AM, wrote: > Author: cgutman > Date: Sun May 24 04:49:02 2009 >

Re: [ros-dev] [ros-diffs] [cwittich] 41093: sync RegQueryValueExA, RegQueryValueA, RegQueryValueW and RegSetValueExA to wine patch by Giannis Adamopoulos See issue #452

2009-05-24 Thread Alex Ionescu
Lol, Ged...this is Wine, remember? It works like this: Ntoskrnl calls user32, which calls kernel32, which calls ntdll, which then calls msi. Msi's A function then calls ntoskrnl's W function, which calls back into gdi32's A function (after converting all the parameters). Bes

Re: [ros-dev] [ros-diffs] [cwittich] 41093: sync RegQueryValueExA, RegQueryValueA, RegQueryValueW and RegSetValueExA to wine patch by Giannis Adamopoulos See issue #452

2009-05-24 Thread Alex Ionescu
FYI, Local* or Base functions are typically always W. Best regards, Alex Ionescu On Sun, May 24, 2009 at 6:13 PM, Ged wrote: > And somewhere in the middle of that there's an RPC call picked up by the > linux host which calls a bash script to do the work. > > > I was ini

Re: [ros-dev] [ros-diffs] [tkreuzer] 41106: MmGrowKernelStack: go back to the ASSERT and add a fixed check

2009-05-24 Thread Alex Ionescu
Sorry for not replying to e-mails about this -- I was on vacation on a cruise. When I'm back to Montreal I'll write a driver to test if this is correct or not -- but definitely this is better. Best regards, Alex Ionescu On Mon, May 25, 2009 at 1:17 AM, wrote: > Author: tkreuze

Re: [ros-dev] Wineconf 2009

2009-05-30 Thread Alex Ionescu
"There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [cgutman] 41213: - Export and hackplement NdisSetTimerEx - Implementation is #ifed out currently but I may enable it later - Hopefully somebody can think of a better way to d

2009-06-02 Thread Alex Ionescu
There's nothing ugly about this -- this is exactly what the field is for. Best regards, Alex Ionescu On Sat, May 30, 2009 at 4:07 PM, wrote: > Author: cgutman > Date: Sun May 31 03:07:13 2009 > New Revision: 41213 > > URL: http://svn.reactos.org/svn/reactos?rev=

Re: [ros-dev] [ros-diffs] [mjmartin] 41269: - IopCreateDriver: Change MajorFunction routines back to internal function IopInvalidDeviceRequest for ones that were set to NULL in the Drivers DriverEntry

2009-06-03 Thread Alex Ionescu
I must say that I protest to all the recent I/O changes, and in my opinion, they are all wrong and badly researched, and have hacked what was once good code. Best regards, Alex Ionescu On Wed, Jun 3, 2009 at 2:48 AM, wrote: > Author: mjmartin > Date: Wed Jun  3 13:48:33 2009 > New

Re: [ros-dev] [ros-diffs] [hyperion] 41557: #define inline to __inline for Visual C++ when compiling C sources

2009-06-22 Thread Alex Ionescu
so-8859-1] (original) > +++ trunk/reactos/ReactOS-generic.rbuild [iso-8859-1] Tue Jun 23 > 00:03:20 2009 > @@ -132,6 +132,7 @@ > > > > + __inline > /Zl > /Zi > /W1 > Best regards, Alex Ionescu

Re: [ros-dev] [ros-diffs] [cwittich] 41599: stub NtSetThreadExecutionState needed by PowerPoint Viewer 2003

2009-06-25 Thread Alex Ionescu
Statics? Win32 flags? Hungarian notation? What is this -- Wine? Please revert this shit. Best regards, Alex Ionescu On Wed, Jun 24, 2009 at 12:53 PM, wrote: > Author: cwittich > Date: Wed Jun 24 23:53:54 2009 > New Revision: 41599 > > URL: http://svn.reactos.org/svn/reactos

Re: [ros-dev] [ros-diffs] [dgorbachev] 41610: Remove a hack from NtAccessCheck(). Bug #4169.

2009-06-25 Thread Alex Ionescu
st regards, Alex Ionescu On Thu, Jun 25, 2009 at 6:29 AM, wrote: > Author: dgorbachev > Date: Thu Jun 25 17:29:58 2009 > New Revision: 41610 > > URL: http://svn.reactos.org/svn/reactos?rev=41610&view=rev > Log: > Remove a hack from NtAccessCheck(). Bug #4169. > >

Re: [ros-dev] r41685 crashes early at boot in my real hardware (P-i @ 200 MHz)

2009-06-29 Thread Alex Ionescu
You could just read his log and see that the P1 issue in the newsletter has nothing to do with the issue he's experiencing Best regards, Alex Ionescu On Mon, Jun 29, 2009 at 10:36 AM, Zachary Gorden wrote: > I refer you to http://www.reactos.org/en/newsletter_61.html#sec1 near the

Re: [ros-dev] [ros-diffs] [dgorbachev] 41788: "Fix" MDL PROBE FAILED! bug #4663.

2009-07-06 Thread Alex Ionescu
=== > --- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Mon Jul 6 > 22:28:11 2009 > @@ -679,6 +679,7 @@ > // Oops :( > // > ProbeStatus = _SEH2_GetExceptionCo

Re: [ros-dev] [ros-diffs] [dgorbachev] 41788: "Fix" MDL PROBE FAILED! bug #4663.

2009-07-07 Thread Alex Ionescu
, it's a bug in PSEH2, unnoticed. More testcases are needed in >> psehtest. > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 41863: stop building ntdll as a win32dll so we can fucking stop auto-importing mingw_common and kernel32 into it... it's supposed to be built as a /SUBSYSTE

2009-07-12 Thread Alex Ionescu
> in > any way but . Do you need a "subsystem" attribute for > modules, maybe? Knock the table once for "no", twice for "yes" > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] Very nice.

2009-07-16 Thread Alex Ionescu
o-force. But since this list > is not related to physics I will not continue this discussion here. > > -- > Best regards, > Alex mailto:care2de...@gmail.com > > ___ > Ros-dev mailing list > Ros-dev

Re: [ros-dev] [ros-diffs] [fireball] 42000: - Create a branch for upcoming work. " people will eat you alive anyway so it doesn't really matter"

2009-07-17 Thread Alex Ionescu
l fucked in the same way, so you can remove that part from the equation (meaning the problem is the driver or kernel or some other DLL). <--- I hope so Best regards, Alex Ionescu On Fri, Jul 17, 2009 at 6:12 PM, James Tabor wrote: > Hi, > > 2009/7/17 Timo Kreuzer : > > Yeah it l

Re: [ros-dev] [ros-diffs] [fireball] 42000: - Create a branch for upcoming work. " people will eat you alive anyway so it doesn't really matter"

2009-07-18 Thread Alex Ionescu
This is such an awesome russian response :) "Let me finish the political upheveal first, "restructure" the parliament, rebuild the economy and then my vision will become clear". Best regards, Alex Ionescu On Sat, Jul 18, 2009 at 12:16 PM, Aleksey Bragin wrote: &g

Re: [ros-dev] [ros-diffs] [dchapyshev] 42012: - Samplify SwitchToThread and QueueUserWorkItem - Remove unneeded InternalWorkItemTrampoline function and QUEUE_USER_WORKITEM_CONTEXT structure - Other sm

2009-07-21 Thread Alex Ionescu
rkItemContext, >>> ___ >>> Ros-dev mailing list >>> Ros-dev@reactos.org >>> http://www.reactos.org/mailman/listinfo/ros-dev >> >> >> >> Wine and Windows do so. Why we should do in another way? Other &g

Re: [ros-dev] [ros-diffs] [dchapyshev] 42012: - Samplify SwitchToThread and QueueUserWorkItem - Remove unneeded InternalWorkItemTrampoline function and QUEUE_USER_WORKITEM_CONTEXT structure - Other sm

2009-07-21 Thread Alex Ionescu
rthermore, this is typecasting from a ULONG to a VOID, isn't it? So the "real" function will never return anything in the first place, making this a non-issue. I challenge you to provide a test case/example on any architecture where this could possibly happen. It can't. Best reg

Re: [ros-dev] FullFAT replacement for Fastfat.sys

2009-07-29 Thread Alex Ionescu
her areas of > ReactOS. I shall be taking a closer look at the ReactOS code over the > coming weeks, and will probably post some questions about various > aspects. I have just bought the Windows Internals, fifth edition > co-authored by Alex Ionescu, hopefully this will pr

Re: [ros-dev] FullFAT replacement for Fastfat.sys

2009-07-29 Thread Alex Ionescu
rk was already started by one of Aleksey's russian guys, but seems to have been dropped... On 29-Jul-09, at 4:47 PM, Steven Edwards wrote: > On Wed, Jul 29, 2009 at 5:00 PM, Alex Ionescu > wrote: >> I'm still at a loss as to why you are all ignoring the free, open &g

Re: [ros-dev] Arwinss architecture

2009-07-30 Thread Alex Ionescu
What you guys need is some way to convince the ARM Ninjas that rewriting the memory manager won't make the ARM port easier -- but that rewriting win32k/gdi32/user32 will! Best regards, Alex Ionescu On Thu, Jul 30, 2009 at 1:32 PM, Samuel serapion wrote: > I love you. > > > On

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.

2009-08-01 Thread Alex Ionescu
Please apply this hack in ke/freeldr.c Best regards, Alex Ionescu On Sat, Aug 1, 2009 at 3:55 AM, Dmitry Gorbachev wrote: > > otherwise you're breaking ntldr boot style, I suppose. > > No, the new hack is applied only if the old is present. > > > Should I or would y

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.

2009-08-01 Thread Alex Ionescu
/itfile.c (oops, I mean ke/freeldr.c), including GRUB code, Wine code and Linux_kernel_functions all day long. Best regards, Alex Ionescu On Sat, Aug 1, 2009 at 2:27 PM, Dmitry Gorbachev wrote: > > Please apply this hack in ke/freeldr.c > > Should I apply same sh*t to differen

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.

2009-08-01 Thread Alex Ionescu
ASCII porn of RMS is also okay. Best regards, Alex Ionescu On Sat, Aug 1, 2009 at 3:26 PM, Alex Ionescu wrote: > ke/freeldr.c was designed for sh*t. It really means, translated sh/itfile.c > and I was actually hoping to commit it that way. > The other files are designed to be 100% c

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.

2009-08-01 Thread Alex Ionescu
Thanks dad, baby Bragin and Ionescu love you. Best regards, Alex Ionescu On Sat, Aug 1, 2009 at 5:15 PM, Dmitry Gorbachev wrote: > > The other files are designed to be 100% compatible and as much as > possible > > identical to 2003 SP1, so please remove that hack from there. &

Re: [ros-dev] [ros-diffs] [fireball] 42333: - Handle case when RosGdiSetDeviceClipping is being called without rects at all (with a respective DPRINT1). - Use combined clipping object everywhere to en

2009-08-02 Thread Alex Ionescu
A similar question would apply to the ninjas' "issue #" that crept up once or twice... Best regards, Alex Ionescu On Sun, Aug 2, 2009 at 3:26 PM, Steven Edwards wrote: > On Sun, Aug 2, 2009 at 6:32 AM, wrote: > > - Use combined clipping object everywhere to ensure d

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-02 Thread Alex Ionescu
The version that GCC 4.4 and CL 15 will generate would be way more optimized than this unportable/slower assembly code. This isn't 1994 anymore. You can't beat the compiler anymore. Best regards, Alex Ionescu On Sun, Aug 2, 2009 at 3:31 PM, wrote: > Author: tkreuzer > Date:

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-03 Thread Alex Ionescu
Just got back to San Francisco... I will take you up on the challenge. Your ass is grass, and I'm the lawnmower. Best regards, Alex Ionescu On Mon, Aug 3, 2009 at 11:15 AM, Timo Kreuzer wrote: > yeah ;-) > > Dmitry Gorbachev wrote: > > Bug? > > > &g

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-03 Thread Alex Ionescu
the P3), because it gets micro-coded and has to do a lot of pre-setup work. I don't know if you were trying to bait me -- I respect you and I'm pretty sure you knew these facts, so I'm surprised about this "challenge". Best regards, Alex Ionescu On Mon, Aug 3, 2009 at

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-03 Thread Alex Ionescu
le zeroing (the kernel itself will use XMMI btw) Best regards, Alex Ionescu On Mon, Aug 3, 2009 at 8:37 PM, Alexander Potashev wrote: > Hey, relax, guys! > > > Btw, 'memset' can only fill a chunk of memory with identical bytes, > thus it can't fill an array of DWO

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-04 Thread Alex Ionescu
time ago. > Using > inline functions instead of a code generator. The idea is to make it > fully portable, optimizable though inline asm functions where useful > and > easier to maintain then the current stuff. It's on my list... > > Timo > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-04 Thread Alex Ionescu
On 4-Aug-09, at 12:36 PM, Timo Kreuzer wrote: Alex Ionescu wrote: I will provide some code and timings but I love how you ignored my main points: And you ignored my main points: 1) The optimization "around" the function is not important, as the function is not called that often

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-04 Thread Alex Ionescu
Note to everyone else: I just spent some time to do the calculations and have data proving C code can be faster -- I will post tonight from home. Now to get to your argument, Jose.. Best regards, Alex Ionescu On Tue, Aug 4, 2009 at 2:19 PM, Jose Catena wrote: > With all respect Alex, altho

Re: [ros-dev] [ros-diffs] [tkreuzer] 42353: asm version of DIB_32BPP_ColorFill: - Add frame pointer - Get rid of algin_draw, 32bpp surfaces must be DWORD aligned - Optimize the loop - Add comments

2009-08-04 Thread Alex Ionescu
; : "D"(p), "c"(DATASIZE/sizeof(int)), "a"(1) > ); > } > > int > main() { > void *data = malloc(DATASIZE); > long long t1, t2, t3, m1, m2; > int i; > > t1 = rdtsc64(); &

Re: [ros-dev] [ros-diffs] [cgutman] 42400: - Partial rewrite of recursive mutex code - Makes the recursive mutex faster and smaller - Fixes several unprotected accesses to recursive mutex

2009-08-04 Thread Alex Ionescu
SERT((x)->Locked) > +#define ASSERT_LOCKED(x) > > #endif/*_ROSRTL_RECMUTEX_H*/ > > Modified: trunk/reactos/drivers/network/tcpip/tcpip/lock.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpip/lock.c?rev=42400&r1=42399&r2=42400&view=diff > = > = > = > = > = > = > = > = > == > --- trunk/reactos/drivers/network/tcpip/tcpip/lock.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/network/tcpip/tcpip/lock.c [iso-8859-1] > Wed Aug 5 01:51:39 2009 > @@ -48,11 +48,9 @@ > RecursiveMutexInit( RecMutex ); > } > > -UINT TcpipRecursiveMutexEnter( PRECURSIVE_MUTEX RecMutex, BOOLEAN > ToWrite ) { > -UINT Ret; > +VOID TcpipRecursiveMutexEnter( PRECURSIVE_MUTEX RecMutex, BOOLEAN > ToWrite ) { > //TI_DbgPrint(DEBUG_LOCK,("Locking\n")); > -Ret = RecursiveMutexEnter( RecMutex, ToWrite ); > -return Ret; > +RecursiveMutexEnter( RecMutex ); > } > > VOID TcpipRecursiveMutexLeave( PRECURSIVE_MUTEX RecMutex ) { > > Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [hyperion] 42530: modified base/setup/vmwinst/vmwinst.c modified base/setup/vmwinst/vmwinst.rbuild Implement VMWare detection for Visual C++ as well For cleaner code, use SEH

2009-08-08 Thread Alex Ionescu
> detection. Don't use SEH > here so we notice the next time someone removes support for > vectored > exception handling from ros... */ Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tkreuzer] 42596: Implement EngFileIoControl and EngFileWrite

2009-08-10 Thread Alex Ionescu
And since when is static used in ReactOS kernel code? Best regards, Alex Ionescu On Mon, Aug 10, 2009 at 10:51 AM, Hervé Poussineau wrote: > tkreu...@svn.reactos.org a écrit : >  > Author: tkreuzer >  > Date: Mon Aug 10 17:09:14 2009 >  > New Revision: 42596 >  &g

Re: [ros-dev] Some upcoming changes

2009-08-15 Thread Alex Ionescu
Can we please 7zip logs instead of deleting them? Should give you massive improvements (especially since A) it's text B) it contains highly-repeatable file/function names). Thanks! Best regards, Alex Ionescu On Sat, Aug 15, 2009 at 7:17 PM, Colin Finck wrote: > Hello all, > > I

Re: [ros-dev] Some upcoming changes

2009-08-17 Thread Alex Ionescu
How about archiving the older logs in a format that may be a one-time CPU expense, but never have to worry about uncompressing? Ie: I don't want really old logs accessible through the UI, but just available by developer request. Best regards, Alex Ionescu On Mon, Aug 17, 2009 at 2:36 AM,

[ros-dev] GCC 4.4

2009-08-24 Thread Alex Ionescu
Please see http://www.reactos.org/wiki/Moving_to_GCC_4.4 Thank you! Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] GCC 4.4

2009-08-24 Thread Alex Ionescu
Hi Dmitry, Does that mean you have patches to fix all the warnings (and errors) in the log? Or have you just hacked the .rbuild files to ignore them? ;-) What about C++ support, how did you solve that? Happy to hear the test results are similar, however. Best regards, Alex Ionescu On Mon

Re: [ros-dev] GCC 4.4

2009-08-24 Thread Alex Ionescu
to build ntoskrnl when the function to make the stack executable imports from VirtualProtect? Thanks! Best regards, Alex Ionescu On Mon, Aug 24, 2009 at 1:43 PM, Dmitry Gorbachev wrote: >> Does that mean you have patches to fix all the warnings (and errors) >> in the log? > > Ther

Re: [ros-dev] GCC 4.4

2009-08-25 Thread Alex Ionescu
support for __enable_execute_stack for kernel-mode. > > Cheers, > Dmitry > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] GCC 4.4

2009-08-25 Thread Alex Ionescu
4.4 built on Windows or Linux? If Windows, perhaps it could become part of RosBE -- they have not been able to figure out how to build the compiler, hence my idea to use the MinGW binaries. > > ___ > Ros-dev mailing list > Ros-dev@

Re: [ros-dev] [ros-diffs] [sginsberg] 42829: - svchost: #ifdef _MSC_VER doesn't mean "using Microsoft's headers" anymore - ddraw, imm32, msxml3, oleaut32, riched20: Include typeof.h for typeof emulati

2009-09-12 Thread Alex Ionescu
"If (!x & 1)" is the most horrible way to write this. To most people it means "NOT X AND 1", what you want is NOT(X AND 1). Best regards, Alex Ionescu On Fri, Sep 11, 2009 at 7:31 PM, Jose Catena wrote: > To check odd / even we should always use: > > >

Re: [ros-dev] GCC 4.4

2009-09-13 Thread Alex Ionescu
So? What's the status on this? It's almost been a month. Best regards, Alex Ionescu On Wed, Aug 26, 2009 at 6:33 AM, Daniel Reimer wrote: > Alex Ionescu wrote: >> Hi, >> >> On 25-Aug-09, at 12:48 PM, Dmitry Gorbachev wrote: >> >> >>>>

Re: [ros-dev] GCC 4.4

2009-09-13 Thread Alex Ionescu
0 duplicate entries. 3) There used to be errors related to PSEH2 and executable stack -- have those been fixed or...? Thank you. Best regards, Alex Ionescu On Sun, Sep 13, 2009 at 3:21 PM, Daniel Reimer wrote: > Alex Ionescu wrote: >> So? What's the status on this? It'

Re: [ros-dev] GCC 4.4

2009-09-15 Thread Alex Ionescu
Finally. I apologize if I sounded rude but as you can see, asskicking works. Best regards, Alex Ionescu On Tue, Sep 15, 2009 at 10:18 AM, Daniel Reimer wrote: > Hi, plase modify this one: > http://www.reactos.org/wiki/Compiling_GCC_From_Windows so that we can > build i

Re: [ros-dev] [ros-diffs] [hpoussin] 43145: Revert r43141 to try to fix ReactOS boot style...

2009-09-25 Thread Alex Ionescu
Fuck. Best regards, Alex Ionescu On Fri, Sep 25, 2009 at 11:10 AM, wrote: > Author: hpoussin > Date: Fri Sep 25 17:10:28 2009 > New Revision: 43145 > > URL: http://svn.reactos.org/svn/reactos?rev=43145&view=rev > Log: > Revert r43141 to try to fix ReactOS b

Re: [ros-dev] [ros-diffs] [sginsberg] 43167: - HAL: Make /W3 friendly - Everywhere else: Use casts instead of -1U to fix C4146 (this is compatible with both compilers)

2009-09-26 Thread Alex Ionescu
No. 0x. Best regards, Alex Ionescu On Sat, Sep 26, 2009 at 9:41 AM, wrote: > Author: sginsberg > Date: Sat Sep 26 15:41:57 2009 > New Revision: 43167 > > URL: http://svn.reactos.org/svn/reactos?rev=43167&view=rev > Log: > - HAL: Make /W3 friendly >

Re: [ros-dev] [ros-diffs] [sginsberg] 43167: - HAL: Make /W3 friendly - Everywhere else: Use casts instead of -1U to fix C4146 (this is compatible with both compilers)

2009-09-26 Thread Alex Ionescu
, compiler warns I need an int*... let me typecast, it seems to fix the warning. } 3) Ask yourself what ULONG means 4) And then ask yourself what -1 means If you still don't get it, go read a book on C. Best regards, Alex Ionescu On Sat, Sep 26, 2009 at 11:50 AM, Stefan Ginsberg wrote:

Re: [ros-dev] [ros-diffs] [sginsberg] 43167: - HAL: Make /W3 friendly - Everywhere else: Use casts instead of -1U to fix C4146 (this is compatible with both compilers)

2009-09-27 Thread Alex Ionescu
es, in which case you use 0x... Or if you want "portability", you can use ~0. Best regards, Alex Ionescu On Sat, Sep 26, 2009 at 2:39 PM, Stefan Ginsberg wrote: > 1) I believe that is to warn about a possible mistake where you really want > -1 and not 0x. > 2) It

Re: [ros-dev] [ros-diffs] [sginsberg] 43241: - KeBugCheckEx expects BugCheckParameter2 to point to an array when the bug code is FATAL_UNHANDLED_HARD_ERROR -- properly stub out ExpSystemErrorHandler s

2009-09-30 Thread Alex Ionescu
And the reason you couldn't pass Parameters? Best regards, Alex Ionescu On Wed, Sep 30, 2009 at 2:31 PM, wrote: > Author: sginsberg > Date: Wed Sep 30 20:31:26 2009 > New Revision: 43241 > > URL: http://svn.reactos.org/svn/reactos?rev=43241&view=rev > Lo

Re: [ros-dev] [ros-diffs] [sginsberg] 43265: - Replace some x86 assembly in drivers with portable breakpoint support.

2009-10-03 Thread Alex Ionescu
e "__break()"??? It's inlined -- producing exactly the same int 3 code as you were using on x86, would've saved you to have to re-define DbgBreakPoint, and would've been portable from day one. Best regards, Alex Ionescu On Sat, Oct 3, 2009 at 6:03 PM, Timo Kreuzer wrote: &

Re: [ros-dev] [ros-diffs] [sginsberg] 43265: - Replace some x86 assembly in drivers with portable breakpoint support.

2009-10-04 Thread Alex Ionescu
He did :) Thanks Timo, and sorry for the typo, it's __debugbreak, as you committed. Best regards, Alex Ionescu On Sun, Oct 4, 2009 at 5:48 PM, KJK::Hyperion wrote: > Timo Kreuzer wrote: >> Stop whining, smartass. > > Please do

Re: [ros-dev] [ros-diffs] [dgorbachev] 43331: Fix logging to a file. In spite of limitations, it remains the only way to obtain desired logs for some people.

2009-10-07 Thread Alex Ionescu
regards, Alex Ionescu On Wed, Oct 7, 2009 at 3:57 PM, wrote: > Author: dgorbachev > Date: Wed Oct  7 21:57:40 2009 > New Revision: 43331 > > URL: http://svn.reactos.org/svn/reactos?rev=43331&view=rev > Log: > Fix logging to a file. > > In spite of limitations, it

Re: [ros-dev] [ros-diffs] [dgorbachev] 43333: Fix GCC 4.1.3 warning.

2009-10-07 Thread Alex Ionescu
Why are you using this bad/broken API? Why are you doing an exchange without even checking the result? Just use InterlockedAdd (but you're not accessing KdpFreeBytes safely elsewhere, so again, you're just wasting time doing bad synchronziation). Best regards, Alex Ionescu On

Re: [ros-dev] [ros-diffs] [dgorbachev] 43333: Fix GCC 4.1.3 warning.

2009-10-08 Thread Alex Ionescu
erlock (only MSVC generates fences around volatile variables, and even then they're not sufficient on IA64/Alpha systems). > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [cgutman] 43693: - Limit the number of interrupts that are handled per call to MiniportHandleInterrupt to prevent us from staying at DISPATCH_LEVEL for too long

2009-10-23 Thread Alex Ionescu
Do the cards not support interrupt coalescing? Best regards, Alex Ionescu On Fri, Oct 23, 2009 at 1:27 AM, wrote: > Author: cgutman > Date: Fri Oct 23 02:27:00 2009 > New Revision: 43693 > > URL: http://svn.reactos.org/svn/reactos?rev=43693&view=rev > Log: >  - Limit

Re: [ros-dev] [ros-diffs] [lsuggs] 43700: First push of nslookup implementation.

2009-10-24 Thread Alex Ionescu
nslookup on Windows uses DNSAPI exclusively for DNS resolution, and the Rtl* network APIs for IP processing. In fact, there are even lots of Wine postings about people trying to run nslookup and failing due to missing dnsapi functionality. Best regards, Alex Ionescu On Sat, Oct 24, 2009 at 4

Re: [ros-dev] Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation

2009-10-27 Thread Alex Ionescu
__ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Conosci il tuo Messenger? Scopri tutte le novità ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailm

Re: [ros-dev] Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation

2009-10-27 Thread Alex Ionescu
ause some SATA adapters are fucking slow in > initializing and uniata would continue too early for them and this > results in failures. Maybe theres a better way to get this done, but > it > was enough for testing and did its job well. > > Alex Ionescu schrieb: >> The real problem

Re: [ros-dev] Re : [ros-diffs] [sginsberg] 43789: - Replace broken implementation of HalpCalibrateStallExecution with a new implementation by a mysterious HAL ninja and myself. The old implementation

2009-10-27 Thread Alex Ionescu
gt; 921 > 2426 > 873 > 2405 > 2405 > > I can't say it's a huge success over the old implementation (it > provided values in the 1000 - 4000 range in the same environment), > taking in mind how more complex the code became (it even has its own > ISR handler embedded i

Re: [ros-dev] Reactos and MinWin

2009-11-02 Thread Alex Ionescu
e and disk space. Best regards, Alex Ionescu On Mon, Nov 2, 2009 at 11:14 AM, Timo Kreuzer wrote: > > One thing related to this is the sepeartion of the SDK part. > > Curently the SDK is integral part of the whole source tree. One minor > change can cause massive rebuilds eve

Re: [ros-dev] Reactos and MinWin

2009-11-02 Thread Alex Ionescu
Mon, Nov 2, 2009 at 10:43 AM, Alex Ionescu wrote: There are all things that KJK and myself have been striving to work on. They require changes to rbuild's underpinnings, which have yet to happen. There is a Wiki tracking some of this. The end plan is for us to ship an RDK which would ship

Re: [ros-dev] [ros-diffs] [tkreuzer] 44052: [NDK] - Add KEXCEPTION_FRAME offsets

2009-11-09 Thread Alex Ionescu
t; +#define KEXCEPTION_FRAME_Rbx 0x100 > +#define KEXCEPTION_FRAME_Rdi 0x108 > +#define KEXCEPTION_FRAME_Rsi 0x110 > +#define KEXCEPTION_FRAME_R12 0x118 > +#define KEXCEPTION_FRAME_R13 0x120 > +#define KEXCEPTION_FRAME_R14 0x128 > +#define KEXCEPTION_FRAME_R15 0x130 > +#define KEXCEPTION_FR

Re: [ros-dev] want to learn

2009-11-09 Thread Alex Ionescu
__ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] want to learn

2009-11-09 Thread Alex Ionescu
rts of 5th edition are useful for ROS, and most of it > was based on 4th > > On Mon, Nov 9, 2009 at 11:15 PM, Alex Ionescu wrote: > 5th. > > On 2009-11-09, at 5:03 PM, Javier Agustìn Fernàndez Arroyo wrote: > >> Windows Internals, 4th Edition >> >> On Mon

Re: [ros-dev] A reimplementation of reactos' cache manager supporting alternate filesystems better (including ext2)

2009-11-12 Thread Alex Ionescu
is is where boot files go) to separate from the Win7 boot volume (this is where the Windows system files go) and to allow BitLocker to work. Best regards, Alex Ionescu On Thu, Nov 12, 2009 at 3:18 AM, Love Nystrom wrote: > Brian wrote: >> i was always under the impression that having a sw

Re: [ros-dev] want to learn

2009-11-12 Thread Alex Ionescu
ReactOS uses C. VC++ is an IDE made by Microsoft for writing C/C++ code, not a language. The "concepts" you are not "understanding" are the in the 3 Intel books you refuse to read. Go away. Best regards, Alex Ionescu On Thu, Nov 12, 2009 at 6:10 AM, rahul nagpal wrot

Re: [ros-dev] A reimplementation of reactos' cache manager supporting alternate filesystems better (including ext2)

2009-11-12 Thread Alex Ionescu
1) You would get the SAME ADVANTAGE by having the FILE on another physical drive! 2) I believe there's a book that covers that? Not to mention a bunch of easily googable information. Best regards, Alex Ionescu On Thu, Nov 12, 2009 at 11:37 AM, Love Nystrom wrote: > Alex Iones

Re: [ros-dev] [ros-general] Microsoft PDC

2009-11-12 Thread Alex Ionescu
chat at the conference or > a beer in the evening drop me a mail. > > Cheers, > Ged. > ___ > Ros-general mailing list > ros-gene...@reactos.org > http://www.reactos.org/mailman/listinfo/ros-general Best regards, Alex Ionescu

Re: [ros-dev] Microsoft PDC

2009-11-12 Thread Alex Ionescu
drink on my own then. >> > I wish I could.. but I can't even afford to visit my mom.. > Have a good time, don't miss Mark Russinovitch. > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org

[ros-dev] Why the *$#(% are you adding Vista exports?

2009-11-18 Thread Alex Ionescu
Bugs like these would've NEVER happened if you stuck to your TARGET: NT 5.2.3790.1800 SP1: http://www.reactos.org/bugzilla/show_bug.cgi?id=4940 You can't just add Vista APIs and expect shit to work! You should really revert this kind of garbage. Best regards, Al

Re: [ros-dev] [ros-diffs] [cgutman] 44286: - Initialize SocketError to 0 to prevent a bogus error from GCC

2009-11-25 Thread Alex Ionescu
it is correct, in a sense. > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org ht

Re: [ros-dev] [ros-diffs] [cgutman] 44286: - Initialize SocketError to 0 to prevent a bogus error from GCC

2009-11-25 Thread Alex Ionescu
.reactos.org/mailman/listinfo/ros-dev >> >> > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [fireball] 44348: [ntoskrnl/se] - Add a hack which prints an annoying message and grants access when it should not be. Callers/bugs should be fixed and this commit reverted a

2009-12-02 Thread Alex Ionescu
This is stupid!!! We had this discussion countless times! It's not a bug to get back access denied! In many situations this is normal, and the application will try again! (Ie: Writing to a read-only file) Best regards, Alex Ionescu On Tue, Dec 1, 2009 at 10:26 PM, wrote: > Author:

Re: [ros-dev] rbuild msvc backend

2009-12-02 Thread Alex Ionescu
If anyone uses the 2003 Toolkit, you do know the latest Windows SDK gives you essentiall a "2008 Toolkit", as does the WDK. Just saying. I think the latest Windows SDK even ships with MSBUILD, which can build .vcproj files. Best regards, Alex Ionescu On Wed, Dec 2, 2009 at 9:14

Re: [ros-dev] [ros-diffs] [tkreuzer] 44464: [RTL] Rewrite the rtl bitmap implementation. The old one was a little .... suboptimal. The new one should outperform the old one by several orders of magnit

2009-12-07 Thread Alex Ionescu
f (!(dw = (DWORD)ulLong)) > -{ > -ret = 32; > -if (!(dw = (DWORD)(ulLong >> 32))) return -1; > -} > -if (!(dw & 0x)) > -{ > -dw >>= 16; > -ret += 16; > -} > -if (!(dw & 0xff)) &

Re: [ros-dev] [ros-diffs] [tkreuzer] 44464: [RTL] Rewrite the rtl bitmap implementation. The old one was a little .... suboptimal. The new one should outperform the old one by several orders of magnit

2009-12-07 Thread Alex Ionescu
= 0; >>> +while (Mask && ((Mask & (1 << 31)) == 0)) >>> +{ >>> +Mask <<= 1; >>> +++(*Index); >>> +} >>> +return Mask ? 1 : 0; >>> +} >> Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tkreuzer] 44464: [RTL] Rewrite the rtl bitmap implementation. The old one was a little .... suboptimal. The new one should outperform the old one by several orders of magnit

2009-12-07 Thread Alex Ionescu
So? Use intrinsics anyways. Or __builtin_clz... On 2009-12-07, at 10:07 PM, Timo Kreuzer wrote: > > Because this is a host module. > > Alex Ionescu wrote: >> Well why this then? They should be intrinsics... >> >> On 2009-12-07, at 8:43 PM, Timo Kreuzer wrote

Re: [ros-dev] [ros-diffs] [tkreuzer] 44464: [RTL] Rewrite the rtl bitmap implementation. The old one was a little .... suboptimal. The new one should outperform the old one by several orders of magnit

2009-12-07 Thread Alex Ionescu
ompiling on a > non-x86 linux machine? This code is portable and serves it's pupose very > well. > Or are you seriously concerned about the performance? > > > Alex Ionescu schrieb: >> So? Use intrinsics anyways. >> >> Or __builtin_clz... >> >

Re: [ros-dev] [ros-diffs] [tkreuzer] 44508: updates EFLAGS definitions

2009-12-11 Thread Alex Ionescu
0x10 > +#define EFLAGS_ID 0x20 > #define EFLAGS_USER_SANITIZE0x3F4DD7 > -#define EFLAG_SIGN 0x8000 > -#define EFLAG_ZERO 0x4000 > > // > // IPI Types > > Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tkreuzer] 44508: updates EFLAGS definitions

2009-12-11 Thread Alex Ionescu
On 2009-12-11, at 10:10 AM, Love Nystrom wrote: > Alex Ionescu wrote: >> There is a reason this set and names was chosen, please don't change them. >> It is for SDK compatibility. >> > > I see mostly additions that reflect Intel flag identifiers.. ergo, no &

Re: [ros-dev] [ros-diffs] [tkreuzer] 44508: updates EFLAGS definitions

2009-12-11 Thread Alex Ionescu
e* should do this instead." On 2009-12-11, at 3:57 PM, Javier Agustìn Fernàndez Arroyo wrote: > > i hope you dont mean we no-devs cant discuss stuff and even learn from you > > On Fri, Dec 11, 2009 at 9:42 PM, Alex Ionescu wrote: > > > > Ergo, we may define them

Re: [ros-dev] [ros-diffs] [tkreuzer] 44508: updates EFLAGS definitions

2009-12-11 Thread Alex Ionescu
c and moved to include/psdk. Anything that was used in asm.h and is not in ks386.inc needs to go to some internal header. > > Further constructive suggestions appreciated. Same arguments apply for amd64/asm.h -- needs to match ksamd.inc > > Regards, > Timo > > > Al

Re: [ros-dev] [ros-diffs] [sserapion] 44550: -Remove hacks for older gcc versions. -Black list gcc below 4.4.2 -Black list ld below 20091119. -99.99% Based on bug 4810 -Speeds up my build by 3 minutes

2009-12-12 Thread Alex Ionescu
gt; > + /* LD automatically exports all symbols by default if -shared is > specified. Prevent it from doing > +this by adding the option -exclude-all-symbols (available since > Binutils 20091017). */ > + // FIXME: Should only be applied for -shared modules, when there's a > smart way to check for them. > + if ( ModuleHandlerInformations[module.type].DefaultHost == HostFalse && > !module.importLibrary ) > + fprintf ( fMakefile, > "%s_LDFLAGS+=$(LDFLAG_EXCLUDE_ALL_SYMBOLS)\n", module.name.c_str() ); > + > fprintf ( fMakefile, "\n\n" ); > } > > > Modified: > branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/rules.mak > URL: > http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/rules.mak?rev=44550&r1=44549&r2=44550&view=diff > == > --- branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/rules.mak > [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/rules.mak > [iso-8859-1] Sat Dec 12 16:41:43 2009 > @@ -259,7 +259,7 @@ > $$(ECHO_WIDL) > $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call > RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C > ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2) > > -${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_c.c,,-fno-unit-at-a-time,${call > RBUILD_intermediate_path_noext,$(2)}_c.o} > +${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_c.c,,,${call > RBUILD_intermediate_path_noext,$(2)}_c.o} > > endef > > @@ -272,7 +272,7 @@ > $$(ECHO_WIDL) > $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call > RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S > ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2) > > -${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_s.c,,-fno-unit-at-a-time,${call > RBUILD_intermediate_path_noext,$(2)}_s.o} > +${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_s.c,,,${call > RBUILD_intermediate_path_noext,$(2)}_s.o} > > endef > > @@ -285,7 +285,7 @@ > $$(ECHO_WIDL) > $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call > RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_p.h -p -P > ${call RBUILD_intermediate_path_noext,$(2)}_p.c $(2) > > -${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_p.c,,-fno-unit-at-a-time,${call > RBUILD_intermediate_path_noext,$(2)}_p.o} > +${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_p.c,,,${call > RBUILD_intermediate_path_noext,$(2)}_p.o} > > endef > > @@ -298,7 +298,7 @@ > $$(ECHO_WIDL) > $$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call > RBUILD_dir,$(2)}} -u -U $$@ $$< > > -${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_i.c,,-fno-unit-at-a-time,${call > RBUILD_intermediate_path_noext,$(2)}_i.o} > +${call RBUILD_CC,$(1),${call > RBUILD_intermediate_path_noext,$(2)}_i.c,,,${call > RBUILD_intermediate_path_noext,$(2)}_i.o} > > endef > > > Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/project.cpp > URL: > http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/tools/rbuild/project.cpp?rev=44550&r1=44549&r2=44550&view=diff > == > --- branches/ros-amd64-bringup/reactos/tools/rbuild/project.cpp [iso-8859-1] > (original) > +++ branches/ros-amd64-bringup/reactos/tools/rbuild/project.cpp [iso-8859-1] > Sat Dec 12 16:41:43 2009 > @@ -527,6 +527,7 @@ > case MicrosoftC: return "msc"; > default: assert ( false ); > } > +return ""; > } > > std::string > @@ -538,4 +539,5 @@ > case MicrosoftLink: return "mslink"; > default: assert ( false ); > } > -} > +return ""; > +} > > Best regards, Alex Ionescu ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

  1   2   3   4   >