Re: [Rosegarden-user] Prevent warning when closing a file

2018-10-09 Thread nocom
Ted, Lorenzo, thanks for you reactions! I am not asking for a mass 
conversion tool, I really have to listen to a log of music and I have 
already written a mass conversion tool. I should've been clearer in what 
I wanted. What I really would appreciate is an option to switch the 
dialog off. Or a *real* check whether the file did change because in my 
case the message "file has changed" is almost always wrong.


Arnold


On 09-10-18 18:02, Lorenzo Sutton wrote:

On 09/10/18 15:25, Ted Felix wrote:

On 10/08/2018 03:04 PM, nocom wrote:
I drag and drop a file into a running rosegarden. But it asks 
whether I want to save a changed file.


   This can be changed by adding the following line to the end of 
RosegardenMainWindow::createDocumentFromMIDIFile():


   newDoc->clearModifiedStatus()

   ...and deleting the unnecessary call to slotDocumentModified() in 
that routine.


   However, there is a use case where the current behavior is 
helpful. If someone is converting a MIDI file to .rg, they will want 
a warning that they forgot to save.


I think this is the standard behaviour (e.g. think importing a wave 
file in Audacity or Ardour...). I think the OP's use case really calls 
for some 'mass converter' midi to Rosegarden .rg tool - maybe from the 
command line...? :)


Lorenzo.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user




___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Prevent warning when closing a file

2018-10-09 Thread Lorenzo Sutton

On 09/10/18 15:25, Ted Felix wrote:

On 10/08/2018 03:04 PM, nocom wrote:
I drag and drop a file into a running rosegarden. But it asks whether 
I want to save a changed file.


   This can be changed by adding the following line to the end of 
RosegardenMainWindow::createDocumentFromMIDIFile():


   newDoc->clearModifiedStatus()

   ...and deleting the unnecessary call to slotDocumentModified() in 
that routine.


   However, there is a use case where the current behavior is helpful. 
If someone is converting a MIDI file to .rg, they will want a warning 
that they forgot to save.


I think this is the standard behaviour (e.g. think importing a wave file 
in Audacity or Ardour...). I think the OP's use case really calls for 
some 'mass converter' midi to Rosegarden .rg tool - maybe from the 
command line...? :)


Lorenzo.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Prevent warning when closing a file

2018-10-09 Thread Ted Felix

On 10/08/2018 03:04 PM, nocom wrote:
I drag and 
drop a file into a running rosegarden. But it asks whether I want to 
save a changed file.


  This can be changed by adding the following line to the end of 
RosegardenMainWindow::createDocumentFromMIDIFile():


  newDoc->clearModifiedStatus()

  ...and deleting the unnecessary call to slotDocumentModified() in 
that routine.


  However, there is a use case where the current behavior is helpful. 
If someone is converting a MIDI file to .rg, they will want a warning 
that they forgot to save.


  I think the current behavior is best.  In the case of someone 
browsing files, they are inconvenienced by an extra click.  In the case 
of someone converting files, they are notified that they have forgotten 
to complete the conversion process.


  I think at a conceptual level, the warning makes sense as well.  The 
MIDI file import process creates a .rg file that hasn't been saved yet. 
We need to make sure that was the user's intent.


Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user