Closed #124.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/124#event-975979205___
Rpm-maint mailing list
Rpm-maint@lists.rpm.or
While there is a real issue here. The proposed solution is not quite right.
Making commenting out a multiline macro illegal is kida silly. Still this need
some solution. We opened #158 for discussing this issue and to come up with a
better solution.
Still thank you very much for your work and
> And this outlaws commenting multiline macros. Which, if you really think
> about it, seems totally absurd.
The point is that commenting out multi-line macros never worked. If I
understand it correctly, it expanded to a commented first line and left the
remaining lines uncommented which can ca
Seems I missed the return with error code earlier, possibly due to testing by
commenting %configure in %prep where this doesn't do anything at all. So it
seems to do what it promises in eg spec preample, but spec scriptlets are
special for the macro expansion warning already.
I'm not really hap
pmatilai commented on this pull request.
rpmlog(RPMLOG_ERR, ...) does not stop the build any more than the
rpmlog(RPMLO_WARNING, ...) does a few lines below. As you should've noticed
when testing it.
Another possible (not saying it's good or what I want, just enumerating)
approach would be add
myungjoo commented on this pull request.
> @@ -207,10 +207,22 @@ static int expandMacrosInSpecBuf(rpmSpec spec, int
> strip)
bufB++;
}
- if (*bufA != '\0' || *bufB != '\0')
+ if (*bufA != '\0' || *bufB != '\0') {
+char *s = lbuf;
+/* If
I like idea of this patchset.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/124#issuecomment-272172751___
Rpm-maint mailing lis
Multi-line macro expansion in a comment has side effects
as mentioned in the PR #123. However, because there are
cases where a macro is needed to be expanded at a line
starting with # (e.g., shebang), let's emit an error
in a case where it is expected to cause side effects while
we do not expect to
