I did some testing in dnfdaemon and the patch is working for us. Just (as Panu
mentioned) for consistency I'd like to change CompleteTransaction signal name
to EndTransaction - the signal is emitted regardless the transaction was
successful and "Complete" in the name suggests the success.
I was
Updated for some subtle fixes and more testcases to showcase what's possible.
If there are no further comments/objections I'll hit merge tomorrowish.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-sof
The handling of "parse" type builtins is kind of weird. I would prefer to have
the parsing outside of doExpandThisMacro() so that I can set args to [ "foo",
"bar" ] and expand the %define macro to do a `%define foo bar`
We only have 5 builtin macros that are "parse" type: define, global, undefin
