Re: non-recursive remote listing breakage in 3.0.0pre1

2008-01-14 Thread Matt McCutchen
On Sun, 2007-10-07 at 01:31 -0400, Matt McCutchen wrote: In the process of investigating this, I ran across another oddity with --dirs and --relative that appears to be present in both rsync 2.6.9 and the current CVS rsync. When a source argument ends in a ./ but isn't ./ itself, rsync skips

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-07 Thread Wayne Davison
On Sun, Oct 07, 2007 at 01:18:46AM -0400, Matt McCutchen wrote: That fix misses the point. On Sat, Oct 06, 2007 at 10:27:38PM -0700, Wayne Davison wrote: No, it's just incomplete. Actually, you were right. Turned out I just needed to limit the check to when inc_recurse was active, as that

non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Erik Jan Tromp
It would appear something snuck in that breaks non-recursive remote listings when talking to a non-3.0.0pre1 version of rsync. The symptom itself is simple enough to see; rather than displaying member directories/regular files/symlinks/etc as one would expect, only non-directories (with the

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Matt McCutchen
On 10/6/07, Erik Jan Tromp [EMAIL PROTECTED] wrote: It would appear something snuck in that breaks non-recursive remote listings when talking to a non-3.0.0pre1 version of rsync. The symptom itself is simple enough to see; rather than displaying member directories/regular files/symlinks/etc as

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Wayne Davison
On Sat, Oct 06, 2007 at 04:52:38PM -0400, Erik Jan Tromp wrote: It would appear something snuck in that breaks non-recursive remote listings when talking to a non-3.0.0pre1 version of rsync. This was a simple problem with the code that was trying to skip implied directories failing to check if

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Wayne Davison
On Sat, Oct 06, 2007 at 05:50:41PM -0400, Matt McCutchen wrote: There's a flip side to this. An rsync 3.0.0 sender *does* set FLAG_XFER_DIR on dirs like D, so if deletion is enabled, the generator incorrectly deletes all their contents! Yeah, that's bad. I'm looking into a fix. ..wayne.. --

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Matt McCutchen
On 10/7/07, Wayne Davison [EMAIL PROTECTED] wrote: This was a simple problem with the code that was trying to skip implied directories failing to check if the relative flag was set. The latest CVS version has this fixed. That fix misses the point. If I pass --relative --no-implied-dirs, the

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Wayne Davison
On Sun, Oct 07, 2007 at 01:18:46AM -0400, Matt McCutchen wrote: That fix misses the point. No, it's just incomplete. Patience. ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Matt McCutchen
In the process of investigating this, I ran across another oddity with --dirs and --relative that appears to be present in both rsync 2.6.9 and the current CVS rsync. When a source argument ends in a ./ but isn't ./ itself, rsync skips the subdirectories. Continuing the previous example: $

Re: non-recursive remote listing breakage in 3.0.0pre1

2007-10-06 Thread Matt McCutchen
On 10/7/07, Wayne Davison [EMAIL PROTECTED] wrote: On Sun, Oct 07, 2007 at 01:18:46AM -0400, Matt McCutchen wrote: That fix misses the point. No, it's just incomplete. Patience. Sorry. What I meant was that, once impliedness of directories is represented properly (which is necessary to