[rtc-linux] Re: rtc: fix chardev initialization races

2018-09-04 Thread Alexandre Belloni
uct module *module is now > > > > > freed */ > > > > > chrdev_open() > > > > >spin_lock(cdev_lock) > > > > > cdev_get() > > > > >

[rtc-linux] Re: [PATCH] rtc: ab8500: Drop AB8540 support

2018-03-22 Thread Alexandre Belloni
the support for now to simplify > maintenance of the AB8500. > > Cc: Loic Pallardy <loic.palla...@st.com> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org> > --- Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel e

[rtc-linux] Re: [PATCH] rtc-pm8xxx: Fix issue in RTC write path

2018-03-01 Thread Alexandre Belloni
;regmap, regs->ctrl, ctrl_reg); > + rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg); > if (rc) { > - dev_err(dev, "Write to RTC control register failed\n"); > + dev_err(dev, "Write to

[rtc-linux] Re: 500 ms delay in time saved into RTC

2018-02-24 Thread Alexandre Belloni
xplained, 96盜 on my PC. It can still be improved and doesn't handle RTCs in localtime. I'm planning to integrate that in hwclock at some point i(hopefully soon) but I didn't have the time to dive too much in the code yet. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kern

[rtc-linux] Re: 500 ms delay in time saved into RTC

2018-02-19 Thread Alexandre Belloni
h has the x86 insanity commented out: https://git.busybox.net/busybox/tree/util-linux/hwclock.c -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- You received this message because you are subscribed to "rtc-linux". Membershi

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-18 Thread Alexandre Belloni
On 13/12/2017 at 07:55:35 +, Lee Jones wrote: > On Tue, 12 Dec 2017, Alexandre Belloni wrote: > > > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > > + Alessandro Zu

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Alexandre Belloni
On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > + Alessandro Zummo > > + Alexandre Belloni > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > <enric.bal

[rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Alexandre Belloni
On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > + Alessandro Zummo > + Alexandre Belloni > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > <enric.balle...@collabora.com>: > > Dear all, > > > > This is an attempt to revive so

[rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130

2017-10-26 Thread Alexandre Belloni
quot;) > Signed-off-by: Bastian Stender <b...@pengutronix.de> > --- > drivers/rtc/rtc-ds1307.c | 5 + > 1 file changed, 5 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received

Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127 watchdog functionality

2017-08-29 Thread Alexandre Belloni
ter(_wdt_miscdev); > + if (ret) > + return ret; > + } > + pcf2127_wdt_settimeout(32); > +#endif > + > + return 0; > } > > #ifdef CONFIG_OF > @@ -427,6 +595,10 @@ static void __exit pcf2127_exit(void) > { >

[rtc-linux] Re: [RESEND v9 06/12] rtc: Kconfig: Name RK805 in Kconfig for RTC_DRV_RK808

2017-08-24 Thread Alexandre Belloni
> Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> > Signed-off-by: Joseph Chen <che...@rock-chips.com> > --- > drivers/rtc/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded

[rtc-linux] Re: [PATCH] rtc: m41t80: enable wakealarm when "wakeup-source" is specified

2017-08-22 Thread Alexandre Belloni
sertions(+), 6 deletions(-) > I've applied it but it didn't apply cleanly, please check rtc-next or linux-next, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-li

Re: [rtc-linux] RTC used as a module

2017-08-21 Thread Alexandre Belloni
On 21/08/2017 at 14:47:20 +0200, Alexandre Belloni wrote: > On 21/08/2017 at 14:19:07 +0200, Michal Simek wrote: > > On 21.8.2017 14:13, Alexandre Belloni wrote: > > > On 21/08/2017 at 12:50:34 +0200, Michal Simek wrote: > > >> Hi, > > >> > >

Re: [rtc-linux] RTC used as a module

2017-08-21 Thread Alexandre Belloni
On 21/08/2017 at 14:19:07 +0200, Michal Simek wrote: > On 21.8.2017 14:13, Alexandre Belloni wrote: > > On 21/08/2017 at 12:50:34 +0200, Michal Simek wrote: > >> Hi, > >> > >> On 21.8.2017 00:03, Alexandre Belloni wrote: > >>> Hi Michal, >

[rtc-linux] Re: [RFC] rtc: ds1307: add square wave output from ds1308

2017-07-31 Thread Alexandre Belloni
S1308_BIT_BBCLK); That should not be needed, the CCF will disable any unused clock. > case ds_1338: > /* clock halted? turn it on, so clock can tick. */ > if (tmp & DS1307_BIT_CH) > -- > 2.13.3 > -- Alexandre Belloni, Free Electrons Embedd

[rtc-linux] Re: [PATCH v2 2/2] RTC: s35390a: implement ioctls

2017-07-30 Thread Alexandre Belloni
nsertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.c

[rtc-linux] Re: [PATCH v2 1/2] RTC: s35390a: handle invalid RTC time

2017-07-30 Thread Alexandre Belloni
information will be lost. > > Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> > --- > drivers/rtc/rtc-s35390a.c | 72 > +++ > 1 file changed, 42 insertions(+), 30 deletions(-) > Applied, thanks. -- Ale

[rtc-linux] Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug

2017-07-09 Thread Alexandre Belloni
6 > 4 files changed, 212 insertions(+), 16 deletions(-) > create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c > Applied, thanks. I've fixed up the date to meaningful ones in patch 2. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engi

[rtc-linux] Re: [PATCHv2 0/2] rtc: add support for STM32H7 RTC

2017-07-06 Thread Alexandre Belloni
gt; rtc: stm32: add STM32H7 RTC support > > .../devicetree/bindings/rtc/st,stm32-rtc.txt | 32 +++-- > drivers/rtc/rtc-stm32.c| 82 > +- > 2 files changed, 92 insertions(+), 22 deletions(-) > Applied, thanks. -- Ale

Re: [rtc-linux] [PATCH 1/2] rtc: ds1307: add ds1308 variant

2017-07-06 Thread Alexandre Belloni
rs/rtc/rtc-ds1307.c | 12 > 1 file changed, 12 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership optio

Re: [rtc-linux] [PATCH 2/2] rtc: ds1307: disable square wave output from ds1308

2017-07-06 Thread Alexandre Belloni
" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rtc-linux+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[rtc-linux] Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support

2017-07-05 Thread Alexandre Belloni
"); > - return PTR_ERR(rtc->ck_rtc); > + match = of_match_device(stm32_rtc_of_match, >dev); > + if (match && match->data) > + rtc->data = (struct stm32_rtc_data *)match->data; > + else > + return -EINVAL; This wi

[rtc-linux] Re: [PATCH 3/3 v2] rtc: gemini/ftrtc010: rename driver and symbols

2017-07-05 Thread Alexandre Belloni
| 2 +- > drivers/rtc/Kconfig | 10 +-- > drivers/rtc/Makefile | 2 +- > drivers/rtc/{rtc-gemini.c => rtc-ftrtc010.c} | 91 > ++-- > 4 files changed, 53 insertions(+), 52 deletions

[rtc-linux] Re: [PATCH 2/3 v2] rtc: gemini: Augment DT bindings for Faraday

2017-07-05 Thread Alexandre Belloni
txt | 14 --- > .../devicetree/bindings/rtc/faraday,ftrtc010.txt | 28 > ++ > 2 files changed, 28 insertions(+), 14 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/cortina,gemini.txt > create mode 100644 Documentation/d

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-07-04 Thread Alexandre Belloni
On 04/07/2017 at 10:55:52 +0200, Fabien Lahoudere wrote: > On Thu, 2017-06-29 at 09:56 +0200, Alexandre Belloni wrote: > > On 26/06/2017 at 11:51:13 +0200, Fabien Lahoudere wrote: > > > > Actually, after reading the datasheet, I realize it is only POC that is > > >

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-06-29 Thread Alexandre Belloni
s. One that does the initialization and another one that reads > > status1 and immediately doest the initialization when POC is set. If BLD > > is set, then we can wait for set_time to happen before initializing. > > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel

[rtc-linux] Re: [PATCH v2 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
te mode 100644 drivers/rtc/rtc-brcmstb-waketimer.c > Both applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
s you removed it from v2. I'll applay that but it is ok if you change your mind. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http:/

[rtc-linux] Re: [PATCH V2] rtc: ds1307: Add support for Epson RX8130CE

2017-06-24 Thread Alexandre Belloni
the chip, Alarm and > Timer is not supported. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Felipe Balbi <ba...@ti.com> > Cc: Nishanth Menon <

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-24 Thread Alexandre Belloni
disabled\n", __func__); > + } else { > + /* Alarm is enabled */ > + alarm->enabled = 1; > + rtc_time_to_tm(sec, >time); > + dev_dbg(dev, "%s: alarm is enabled\n", __func__); > + } > + > + reg = readl_r

[rtc-linux] Re: [PATCH] rtc: opal: Implement rtc_class_ops.alarm_irq_enable callback

2017-06-23 Thread Alexandre Belloni
2 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Me

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
fixups once > per class, not once per driver. Yes, I'm in the middle of the whole rework that allows that. I don't understand the sudden urgency of fixing that and the amount of bikeshedding, seeing that the closest cutoff date is actually 31st of december 2069 in the rtc subsystem and tha

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
On 21/06/2017 at 10:19:49 +0100, Russell King - ARM Linux wrote: > On Wed, Jun 21, 2017 at 10:39:07AM +0200, Alexandre Belloni wrote: > > On 21/06/2017 at 09:51:52 +0200, Pavel Machek wrote: > > > If someone uses different threshold, well, there will be > > > co

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
e unusual. > Or not, having an RTC set in the past is actually quite common. I'd find it weird to have a new device boot and be set to a date in the future. Also note that the threshold or offset thing may seem like a good idea but fails with many RTCs because of how they handle leap years. --

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > <alexandre.bell...@free-electrons.com>: > > >> Yes, that's argument against ch

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits varia

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
roll <ulli.kr...@googlemail.com> > CC: Vladimir Zapolskiy <v...@mleia.com> > CC: Sylvain Lemieux <slemieux.t...@gmail.com> > CC: Barry Song <bao...@kernel.org> > CC: Maxime Ripard <maxime.rip...@free-electrons.com> > CC: Chen-Yu Tsai <w...@

[rtc-linux] Re: [PATCH 2/3] tools: timer: add test to check y2038/2106 bug

2017-06-16 Thread Alexandre Belloni
exit(errno); > + } > + > + fprintf(stderr, "RTC alarm is %d-%d-%d, %02d:%02d:%02d.\n", > + current.tm_mday, current.tm_mon + 1, current.tm_year + 1900, > + current.tm_hour, current.tm_min, current.tm_sec); > + > + if (new.tm_year != current

[rtc-linux] Re: [PATCH 1/3] tools: timer: add rtctest_setdate

2017-06-16 Thread Alexandre Belloni
* Write the new date in RTC */ > + retval = ioctl(fd, RTC_SET_TIME, ); > + if (retval == -1) { > + perror("RTC_SET_TIME ioctl"); > + close(fd); > + exit(errno); > + } > + > + /* Read back */ > + retval = ioctl(fd, RTC_RD_TIME, ); &

[rtc-linux] [GIT PULL] RTC for 4.12 #2

2017-06-03 Thread Alexandre Belloni
address Alexandre Belloni (1): MAINTAINERS: update RTC mailing list MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free

[rtc-linux] [PATCH 2/5] rtc: dev: remove rtc->name from debug message

2017-06-02 Thread Alexandre Belloni
rtc->name is superfluous here because the rtc is already registered at that point and its name has already been printed. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[rtc-linux] [PATCH 3/5] rtc: pcf8563: avoid using rtc->name

2017-06-02 Thread Alexandre Belloni
pcf8563->rtc->name is a copy of pcf8563_driver.driver.name, use it instead Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc

[rtc-linux] [PATCH 5/5] rtc: remove rtc_device.name

2017-06-02 Thread Alexandre Belloni
rtc->name is only used in messages were it is superfluous. Remove it completely from the structure. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/class.c | 7 +++ include/linux/rtc.h | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) d

[rtc-linux] [PATCH 4/5] rtc: ds1307: avoid using rtc-name

2017-06-02 Thread Alexandre Belloni
ds1307->rtc->name is a copy of ds1307->client->name, use it instead. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-ds1307.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/

[rtc-linux] Re: [PATCH 12/29] rtc.txt: standardize document format

2017-05-31 Thread Alexandre Belloni
ed, 23 insertions(+), 21 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc

[rtc-linux] Re: [PATCH] drivers/rtc/interface.c: Validate alarm-time before handling rollover

2017-05-31 Thread Alexandre Belloni
and if rtc_valid_tm() still > reports it to be invalid then bails out of the function without > handling the rollover. > > Reported-by: Steve Best <sb...@redhat.com> > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> > --- > drivers/rtc/interface.c | 9

[rtc-linux] Re: [PATCH] rtc/tpo: Handle disabled TPO in opal_get_tpo_time()

2017-05-31 Thread Alexandre Belloni
n such a case. This signals generic rtc that no alarm is set and it > bails out from the alarm initialization flow without reporting the > above error. > > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> > Reported-by: Steve Best <sb...@redhat.com> > --- > d

[rtc-linux] Re: [PATCH 0/4] rtc: m41t80: improve SQW support

2017-05-30 Thread Alexandre Belloni
: m41t80: remove sqw sysfs entry > rtc: m41t80: add clock provider support > > drivers/rtc/rtc-m41t80.c | 251 > +-- > 1 file changed, 175 insertions(+), 76 deletions(-) > All applied now, I had to rebase the last patch on top of v4.12-

[rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ

2017-05-30 Thread Alexandre Belloni
ds1307_can_wakeup_device)) { > irq_handler = mcp794xx_irq; > want_irq = true; > } I applied it now but it didn't applied cleanly. Can you check tomorrow's linux-next? Thanks! -- Alexandre Belloni, Fre

[rtc-linux] Re: [PATCH v2] rtc: ds1307: convert driver to regmap

2017-05-25 Thread Alexandre Belloni
test as > well. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > v2: > - rebased on top of latest rtc tree > --- > drivers/rtc/rtc-ds1307.c | 603 > +-- > 1 file changed, 221 insertions(+), 382 deletions(

[rtc-linux] Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm

2017-05-22 Thread Alexandre Belloni
On 22/05/2017 at 00:02:08 +0200, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang <w...@the-dreams.de> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.c

[rtc-linux] [PATCH] MAINTAINERS: update RTC mailing list

2017-05-16 Thread Alexandre Belloni
The RTC subsystem mailing list is moving to vger. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f7d568b8f133..b3863ec142d7 100644 --- a/MAINT

[rtc-linux] Re: [PATCH 1/1] rtc: snvs: fix an incorrect check of return value

2017-05-04 Thread Alexandre Belloni
ff-by: Pan Bian <bianpan2...@163.com> > --- > drivers/rtc/rtc-snvs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because

[rtc-linux] Re: [PATCH] RTC: Add functionality to read/write rtc scratch registers

2017-05-04 Thread Alexandre Belloni
/rtc.h > > @@ -91,6 +91,10 @@ struct rtc_class_ops { > > int (*alarm_irq_enable)(struct device *, unsigned int enabled); > > int (*read_offset)(struct device *, long *offset); > > int (*set_offset)(struct device *, long offset); > > + int (*read_scratch)(s

[rtc-linux] Re: [PATCH] rtc: hid-sensor-time: remove some dead code

2017-04-25 Thread Alexandre Belloni
On 12/04/2017 at 11:32:53 +0300, Dan Carpenter wrote: > devm_rtc_device_register() doesn't ever return NULL so there is no need > to check. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux a

[rtc-linux] Re: [PATCH] rtc: ds1374: Add trickle charger device tree binding

2017-04-24 Thread Alexandre Belloni
thing, > make setting the timeout actually work (right now it the timeout to > tick conversion is > hosed). > I think I would do something with MFD as you were suggesting on IRC. You can have a look at the flexcom driver (atmel-flexcom.c) which is simply selecting a mode and then using whatev

[rtc-linux] Re: [PATCH] rtc: sh: mark PM functions as unused

2017-04-22 Thread Alexandre Belloni
there is no reference. > > Fixes: dab5aec64bf5 ("rtc: sh: add support for rza series") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > drivers/rtc/rtc-sh.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Bel

[rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ

2017-04-22 Thread Alexandre Belloni
s1307_can_wakeup_device)) { irq_handler = mcp794xx_irq; This seems right but your mailer as mangled the patch. Can you resend? > want_irq = true; > } -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electron

[rtc-linux] [PATCH] rtc: m41t80: Add proper compatible for rv4162

2017-04-19 Thread Alexandre Belloni
The correct compatible for the rv4162 (microcrystal,rv4162) was not used upstream and so was not added by eb235c561d04e. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-m41t80.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/r

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-14 Thread Alexandre Belloni
BOL > --- > arch/x86/kernel/i8259.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux&quo

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-13 Thread Alexandre Belloni
> +EXPORT_SYMBOL_GPL(legacy_pic); > > static int __init i8259A_init_ops(void) > { > -- > 2.9.3 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-

[rtc-linux] [PATCH] rtc: ds1307: Add m41t0 to OF device ID table

2017-04-08 Thread Alexandre Belloni
m41t0 was added to the I2C device ID table but not the OF table. Fix that. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/rtc/rtc-ds1307.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c

[rtc-linux] Re: [PATCH] rtc: cpcap: fix improper use of IRQ_NONE for request_threaded_irq

2017-04-08 Thread Alexandre Belloni
Cc: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Tony Lindgren <t...@atomide.com> > --- > drivers/rtc/rtc-cpcap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c Applied, thanks. -- Alex

[rtc-linux] Re: [PATCH] rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs

2017-04-08 Thread Alexandre Belloni
e Goede <hdego...@redhat.com> > --- > drivers/rtc/rtc-cmos.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received th

[rtc-linux] Re: [PATCH v3 0/7] rtc: Reuse rtc-sh driver to support RZ/A1

2017-04-03 Thread Alexandre Belloni
s: rtc: document the rtc-sh bindings I applied those two, I'll let Simon take the device tree patches. Thanks! > ARM: dts: r7s72100: add rtc clock to device tree > ARM: dts: r7s72100: add RTC_X clock inputs to device tree > ARM: dts: r7s72100: add rtc to device tree > ARM:

[rtc-linux] Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules

2017-03-26 Thread Alexandre Belloni
to use devm_*()" has been > verified on 96boards Hikey. Other patches can pass building but have > not really tested on hardware. > If your plan is to actually remove usage of amba_request_regions() and amba_release_regions(), you should do so in its own patch sets instead of hiding

[rtc-linux] Re: Question: Linux changes required for off control board RTC

2017-03-21 Thread Alexandre Belloni
? > The kernel will work, the RTC is not required. > 4) Is there a configurable kernel option to allow for such a change, > or have these or similar changes already been added to the kernel? > More details are needed to answer that but basically if your FPGa emulates an RTC that is

[rtc-linux] Re: [PATCH 2/5] rtc: Add rtc-sh

2017-03-20 Thread Alexandre Belloni
stuff go if not in the DT? > If you want you can leave the clock selection logic out of the driver as long as the DT binding is complete. You dont have to use everything that is described in the DT. Regarding the selection, I'd say take the first that is present and not 0 however, if something has

[rtc-linux] Re: [PATCH 3/5] ARM: dts: r7s72100: add rtc clock to device tree

2017-03-17 Thread Alexandre Belloni
lock.h > index cd2ed51..bc256d3 100644 > --- a/include/dt-bindings/clock/r7s72100-clock.h > +++ b/include/dt-bindings/clock/r7s72100-clock.h > @@ -29,6 +29,9 @@ > #define R7S72100_CLK_OSTM0 1 > #define R7S72100_CLK_OSTM1 0 > > +/* MSTP6 */ > +#define R7S7

[rtc-linux] Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series

2017-03-17 Thread Alexandre Belloni
Mostly good, one nitpick: On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote: > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > + if (res == NULL) if (!res) is preferred here -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electro

[rtc-linux] Re: [PATCH 2/5] rtc: Add rtc-sh

2017-03-17 Thread Alexandre Belloni
e them in the future. > E.g. to select among X1, X3, or EXTAL, depending on availability. > I'm on Geert's side here, I wouldn't rely on the bootloader to set everything up correctly. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You recei

[rtc-linux] Re: [PATCH] rtc: rtc-wm8350: Remove unused to_wm8350_from_rtc_dev

2017-03-16 Thread Alexandre Belloni
, 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read

[rtc-linux] Re: [PATCHv4 2/2] rtc: cpcap: new rtc driver

2017-03-08 Thread Alexandre Belloni
| 1 + > drivers/rtc/rtc-cpcap.c| 332 > + > 4 files changed, 358 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cpcap-rtc.txt > create mode 100644 drivers/rtc/rtc-cpcap.c > Applied, thanks. -- Alexa

[rtc-linux] Re: [PATCHv4 1/2] dt-bindings: Add vendor prefix for Motorola

2017-03-08 Thread Alexandre Belloni
Herring > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscri

[rtc-linux] Re: [PATCH] rtc: omap: mark PM methods as __maybe_unused

2017-03-08 Thread Alexandre Belloni
khov <dmitry.torok...@gmail.com> > --- > drivers/rtc/rtc-omap.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received thi

[rtc-linux] Re: Kernel without RTC

2017-03-08 Thread Alexandre Belloni
e source so it can already work without an RTC. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux

[rtc-linux] Re: [PATCH 00/13] rtc: Add OF device table to I2C drivers that are missing it

2017-03-03 Thread Alexandre Belloni
On 03/03/2017 at 12:27:23 -0300, Javier Martinez Canillas wrote: > On 03/03/2017 12:01 PM, Alexandre Belloni wrote: > > On 03/03/2017 at 11:29:11 -0300, Javier Martinez Canillas wrote: > >> This series add OF device ID tables to RTC I2C drivers whose devices are > >>

Re: [rtc-linux] RTC used as a module

2017-03-03 Thread Alexandre Belloni
if in this situation > driver should be modular or not. > If driver can be modular then somewhere should be put_device(). > >From a quick look, I'd say the issue is coming from 8bc0dafb5cf38a19484dfb16e2c6d29e85820046 which removed the call to rtc_class_open so you can actually unload t

[rtc-linux] Re: [PATCH v2 01/16] chardev: add helper function to register char devs with a struct device

2017-02-27 Thread Alexandre Belloni
kobject parent without using device_add. > > [1] https://lkml.org/lkml/2017/2/13/700 > [2] https://lkml.org/lkml/2017/2/10/370 > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> Reviewed-by: Alexandre Belloni &l

[rtc-linux] Re: [PATCH v2 14/16] rtc: utilize new cdev_device_add helper function

2017-02-27 Thread Alexandre Belloni
Gunthorpe <log...@deltatee.com> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > --- > drivers/rtc/class.c | 14 ++ > drivers/rtc/rtc-dev.c | 17 - > 2 files changed, 10 insertions(+), 21 deletions(-) > > diff --git

[rtc-linux] [GIT PULL] RTC for 4.11

2017-02-26 Thread Alexandre Belloni
: calibration support Akinobu Mita (1): bindings: rtc: correct wrong reference in required properties Alexandre Belloni (1): rtc: sun6i: extend test coverage Amelie Delaunay (4): dt-bindings: document the STM32 RTC

[rtc-linux] Re: [PATCH 3/3] rtc: ds3232: Call device_init_wakeup before device_register

2017-02-23 Thread Alexandre Belloni
On 24/02/2017 at 10:32:40 +0800, Phil Reid wrote: > On 24/02/2017 09:46, Alexandre Belloni wrote: > > On 22/02/2017 at 09:33:14 +0800, Phil Reid wrote: > > > On 22/02/2017 04:33, Alexandre Belloni wrote: > > > > On 17/02/2017 at 09:44:58 +0800, Phil Reid wrote: >

[rtc-linux] Re: [PATCH 3/3] rtc: ds3232: Call device_init_wakeup before device_register

2017-02-23 Thread Alexandre Belloni
On 22/02/2017 at 09:33:14 +0800, Phil Reid wrote: > On 22/02/2017 04:33, Alexandre Belloni wrote: > > On 17/02/2017 at 09:44:58 +0800, Phil Reid wrote: > > > The wakealarm attribute is currently not exposed in the sysfs interface > > > as the device has not been

[rtc-linux] Re: [PATCH v2] rtc: pcf2127: bulk read only date and time registers.

2017-02-23 Thread Alexandre Belloni
nges since v1: > - fixed indentation > - use of more defines > > drivers/rtc/rtc-pcf2127.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.

Re: [rtc-linux] RTC used as a module

2017-02-23 Thread Alexandre Belloni
s: - is this the only rtc with a driver on your system ? - is it selected as the RTC_SYSTOHC_DEVICE or RTC_HCTOSYS_DEVICE. I've checked the code and I don't think this is the issue but it is worth testing. Thanks, -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.

[rtc-linux] Re: [PATCHv2] rtc: cpcap: new rtc driver

2017-02-22 Thread Alexandre Belloni
gt; > + dev_err(dev, "Could not request update irq: %d\n", err); > > > + return err; > > > + } > > > + disable_irq(rtc->update_irq); > > > + > > > + err = device_init_wakeup(dev, 1); > > > > If you use device

[rtc-linux] Re: [PATCHv2] rtc: cpcap: new rtc driver

2017-02-21 Thread Alexandre Belloni
> + "rtc_1hz", rtc); I don't think this IRQ is actually useful. It doesn't really harm but the tests should pass without it. > + if (err) { > + dev_err(dev, "Could not request update irq: %d\n", err); > + return err; > +

[rtc-linux] Re: [PATCH v3 2/3] rtc: armada38x: Add support for Armada 7K/8K

2017-02-21 Thread Alexandre Belloni
80-rtc.txt | 8 ++- > drivers/rtc/rtc-armada38x.c| 65 > ++ > 2 files changed, 70 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --

[rtc-linux] Re: [PATCH v3 1/3] rtc: armada38x: Prepare driver to manage different versions

2017-02-21 Thread Alexandre Belloni
insertions(+), 53 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux

[rtc-linux] Re: [PATCH 3/3] rtc: ds3232: Call device_init_wakeup before device_register

2017-02-21 Thread Alexandre Belloni
t; + THIS_MODULE); > + if (IS_ERR(ds3232->rtc)) > + return PTR_ERR(ds3232->rtc); > + > return 0; > } > > -- > 1.8.3.1 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You rece

[rtc-linux] Re: [PATCH 1/5] rtc: m48t86: verify that the RTC is actually present

2017-02-21 Thread Alexandre Belloni
outer <alex+ker...@digriz.org.uk> > Ok, then I've applied the whole series. I'll send that to Linus by the end of the week. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "r

[rtc-linux] Re: [PATCH 1/5] rtc: m48t86: verify that the RTC is actually present

2017-02-21 Thread Alexandre Belloni
On 21/02/2017 at 17:04:07 +, Hartley Sweeten wrote: > On Tuesday, February 21, 2017 9:37 AM, Alexandre Belloni wrote: > > On 15/02/2017 at 09:35:23 -0700, H Hartley Sweeten wrote: > >> The RTC is an optional feature at purchase time on some Technologic > >

[rtc-linux] Re: [PATCH 1/5] rtc: m48t86: verify that the RTC is actually present

2017-02-21 Thread Alexandre Belloni
Sweeten <hswee...@visionengravers.com> > Cc: Alessandro Zummo <a.zu...@towertech.it> > Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com> > Cc: Alexander Clouter <a...@digriz.org.uk> > --- > drivers/rtc/rtc-m48t86.c | 36 +++

Re: [rtc-linux] [PATCH] rtc: pcf2127: bulk read only date and time registers.

2017-02-21 Thread Alexandre Belloni
more diff linies :-S > What do you think ? Then, what about: regmap_bulk_read(pcf2127->regmap, PCF2127_REG_SC, (buf + PCF2127_REG_SC), sizeof(buf) - PCF2127_REG_SC); -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- Yo

[rtc-linux] Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function

2017-02-21 Thread Alexandre Belloni
_region->kref); > > - dev->devt = dev_t; > dev->class = dax_class; > dev->parent = parent; > dev->groups = dax_attribute_groups; > -- > 2.1.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-elect

[rtc-linux] Re: [PATCH v2 0/3] Extend rtc-armada38x support for Armada 7K/8K

2017-02-20 Thread Alexandre Belloni
following: > > devmem2 0xf428401c w 0 > devmem2 0xf4284018 w 0x2000 The question being what does that do and whether it could be done in the driver instead. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this messa

Re: [rtc-linux] [PATCH 0/3] rtc: m48t86: cleanup driver and add NVRAM support

2017-02-11 Thread Alexandre Belloni
rom this driver, along with > platform_data/rtc-m48t86.h. > > H Hartley Sweeten (3): > rtc: m48t86: shorten register name defines > rtc: m48t86: allow driver to manage it's resources > rtc: m48t86: add NVRAM support > > drivers/rtc/rtc-m48t86.c | 247 > +++++

Re: [rtc-linux] RE: [PATCH 0/3] rtc: m48t86: cleanup driver and add NVRAM support

2017-02-11 Thread Alexandre Belloni
S is actually incrementing after being instantiated, if it looks weird > >> then > >> to unbind its-self. > > Or the probe could do that check and return -ENODEV if it fails. > If it is always incrementing, even when it has never been set (first boot or battery is dea

[rtc-linux] Re: [PATCH -next] rtc: sun6i: Fix return value check in sun6i_rtc_clk_init()

2017-02-11 Thread Alexandre Belloni
IS_ERR(). > > Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> > --- > drivers/rtc/rtc-sun6i.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free E

  1   2   3   >