Re: New provider

[Paulo Henrique Lopes Ribeiro]

Oh. So keep the authors part. =)

We just need to check the other points I mentioned.

Em sex, 2 de mar de 2018 11:49, geemus (Wesley Beary) 
escreveu:

> I'm fine with authors that way in gemspec, fwiw. It is an interesting
> pattern.
>
> Thanks Paulo for checking in and giving feedback!
>
> On Fri, Mar 2, 2018 at 7:04 AM, Paulo Henrique Lopes Ribeiro <
> plribeiro3...@gmail.com> wrote:
>
>> Hello Piotr. Good morning!
>>
>> Sorry i just got to this now.
>>
>> I would like to ask you to take a look at this wiki page:
>> https://github.com/fog/fog/wiki/Create-New-Provider-from-Scratch
>>
>> I believe most of it might be already covered since you have the code
>> finished already but there is one thing to notice.
>>
>> The `autoload` part. We had a big issue because of it so we really need
>> you to update your code to use it.
>>
>> Good examples are:
>> * https://github.com/fog/fog-xenserver/blob/master/lib/fog/xenserver.rb
>> * https://github.com/fog/fog-aws/blob/master/lib/fog/aws.rb
>>
>> I've noticed that you are doing this:
>> https://github.com/pkliczewski/fog-kubevirt/blob/a61f6bba099e2404fbace2af1e885ea934583fe4/fog-kubevirt.gemspec#L8-L13
>>
>> I'm not sure whats the intention behind it but i believe you can leave
>> just Wesley there. At least that what we are doing in the other providers.
>>
>> And we do need you to release the gem before we merge your PR into
>> `fog/fog`.
>>
>> Let me know if you need assistance with anything else.
>>
>> Best,
>>
>>
>>
>>
>>
>>
>> 2018-03-02 7:12 GMT-03:00 Piotr Kliczewski :
>>
>>> I pushed the PRs [1][2][3]. Please take a look and let us know how to
>>> continue.
>>>
>>> Thanks,
>>> Piotr
>>>
>>> [1] https://github.com/pkliczewski/fog-kubevirt/pull/3
>>> [2] https://github.com/fog/fog/pull/3984
>>> [3] https://github.com/fog/fog-core/pull/225
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "ruby-fog" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to ruby-fog+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> -
>> Paulo Henrique Lopes Ribeiro - Linkedin
>> 
>> CTO 4Shark - Website 
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "ruby-fog" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to ruby-fog+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Paulo Ribeiro
CTO 4SHARK

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[geemus (Wesley Beary)]

I'm fine with authors that way in gemspec, fwiw. It is an interesting
pattern.

Thanks Paulo for checking in and giving feedback!

On Fri, Mar 2, 2018 at 7:04 AM, Paulo Henrique Lopes Ribeiro <
plribeiro3...@gmail.com> wrote:

> Hello Piotr. Good morning!
>
> Sorry i just got to this now.
>
> I would like to ask you to take a look at this wiki page:
> https://github.com/fog/fog/wiki/Create-New-Provider-from-Scratch
>
> I believe most of it might be already covered since you have the code
> finished already but there is one thing to notice.
>
> The `autoload` part. We had a big issue because of it so we really need
> you to update your code to use it.
>
> Good examples are:
> * https://github.com/fog/fog-xenserver/blob/master/lib/fog/xenserver.rb
> * https://github.com/fog/fog-aws/blob/master/lib/fog/aws.rb
>
> I've noticed that you are doing this: https://github.com/
> pkliczewski/fog-kubevirt/blob/a61f6bba099e2404fbace2af1e885e
> a934583fe4/fog-kubevirt.gemspec#L8-L13
>
> I'm not sure whats the intention behind it but i believe you can leave
> just Wesley there. At least that what we are doing in the other providers.
>
> And we do need you to release the gem before we merge your PR into
> `fog/fog`.
>
> Let me know if you need assistance with anything else.
>
> Best,
>
>
>
>
>
>
> 2018-03-02 7:12 GMT-03:00 Piotr Kliczewski :
>
>> I pushed the PRs [1][2][3]. Please take a look and let us know how to
>> continue.
>>
>> Thanks,
>> Piotr
>>
>> [1] https://github.com/pkliczewski/fog-kubevirt/pull/3
>> [2] https://github.com/fog/fog/pull/3984
>> [3] https://github.com/fog/fog-core/pull/225
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "ruby-fog" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to ruby-fog+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> -
> Paulo Henrique Lopes Ribeiro - Linkedin
> 
> CTO 4Shark - Website 
>
> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[Paulo Henrique Lopes Ribeiro]

Hello Piotr. Good morning!

Sorry i just got to this now.

I would like to ask you to take a look at this wiki page:
https://github.com/fog/fog/wiki/Create-New-Provider-from-Scratch

I believe most of it might be already covered since you have the code
finished already but there is one thing to notice.

The `autoload` part. We had a big issue because of it so we really need you
to update your code to use it.

Good examples are:
* https://github.com/fog/fog-xenserver/blob/master/lib/fog/xenserver.rb
* https://github.com/fog/fog-aws/blob/master/lib/fog/aws.rb

I've noticed that you are doing this:
https://github.com/pkliczewski/fog-kubevirt/blob/a61f6bba099e2404fbace2af1e885ea934583fe4/fog-kubevirt.gemspec#L8-L13

I'm not sure whats the intention behind it but i believe you can leave just
Wesley there. At least that what we are doing in the other providers.

And we do need you to release the gem before we merge your PR into
`fog/fog`.

Let me know if you need assistance with anything else.

Best,






2018-03-02 7:12 GMT-03:00 Piotr Kliczewski :

> I pushed the PRs [1][2][3]. Please take a look and let us know how to
> continue.
>
> Thanks,
> Piotr
>
> [1] https://github.com/pkliczewski/fog-kubevirt/pull/3
> [2] https://github.com/fog/fog/pull/3984
> [3] https://github.com/fog/fog-core/pull/225
>
> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
-
Paulo Henrique Lopes Ribeiro - Linkedin

CTO 4Shark - Website 

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[Piotr Kliczewski]

I pushed the PRs [1][2][3]. Please take a look and let us know how to 
continue.

Thanks,
Piotr

[1] https://github.com/pkliczewski/fog-kubevirt/pull/3
[2] https://github.com/fog/fog/pull/3984
[3] https://github.com/fog/fog-core/pull/225

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[geemus (Wesley Beary)]

gee...@gmail.com and plribeiro3...@gmail.com would be great, thanks!

On Mon, Feb 26, 2018 at 2:26 AM, Piotr Kliczewski <
piotr.kliczew...@gmail.com> wrote:

>
>
> On Friday, February 23, 2018 at 5:27:55 PM UTC+1, geemus wrote:
>>
>> Mostly you just need to reach out to us. When you are ready, you can add
>> me (@geemus) as an administrator on your repo and then I can pull it in to
>> the org. We also ask that you would add a couple of the core folks to the
>> gem authors, so that we could push emergency releases if it ever came to
>> it. Beyond that we can advise and provide support as needed.
>>
>
> Great, we still need to finalize few things. Who should I add to gem
> authors?
>
>
>>
>> Does that all make sense? Any other questions or things I can support?
>>
>
> Yes, thank you!
>
>
>>
>> Thanks!
>> wes
>>
>> On Wed, Feb 21, 2018 at 10:25 AM, Piotr Kliczewski > > wrote:
>>
>>> Hi all,
>>>
>>> Currently we are working on new provider [1] for kubevirt [2]. I wonder
>>> what criteria do we need to meet to become part of fog organization?
>>> The are 2 commits [3][4] that we would like to make PRs to corresponding
>>> repos to enable the provider (still WIP).
>>>
>>> Thanks,
>>> Piotr
>>>
>>> [1] https://github.com/pkliczewski/fog-kubevirt
>>> [2] http://www.kubevirt.io/
>>> [3] https://github.com/masayag/fog/commit/b1ca7425d1a14fe4b2
>>> 5a15649eca1cf1450c859e
>>> [4] https://github.com/masayag/fog-core/commit/a83f48c7dc4ba
>>> 3396047ed638dd838dd398b2a6f
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "ruby-fog" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to ruby-fog+u...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[Piotr Kliczewski]

On Friday, February 23, 2018 at 5:27:55 PM UTC+1, geemus wrote:
>
> Mostly you just need to reach out to us. When you are ready, you can add 
> me (@geemus) as an administrator on your repo and then I can pull it in to 
> the org. We also ask that you would add a couple of the core folks to the 
> gem authors, so that we could push emergency releases if it ever came to 
> it. Beyond that we can advise and provide support as needed.
>

Great, we still need to finalize few things. Who should I add to gem 
authors?
 

>
> Does that all make sense? Any other questions or things I can support?
>

Yes, thank you!
 

>
> Thanks!
> wes
>
> On Wed, Feb 21, 2018 at 10:25 AM, Piotr Kliczewski  > wrote:
>
>> Hi all,
>>
>> Currently we are working on new provider [1] for kubevirt [2]. I wonder 
>> what criteria do we need to meet to become part of fog organization?
>> The are 2 commits [3][4] that we would like to make PRs to corresponding 
>> repos to enable the provider (still WIP).
>>
>> Thanks,
>> Piotr
>>
>> [1] https://github.com/pkliczewski/fog-kubevirt
>> [2] http://www.kubevirt.io/
>> [3] 
>> https://github.com/masayag/fog/commit/b1ca7425d1a14fe4b25a15649eca1cf1450c859e
>> [4] 
>> https://github.com/masayag/fog-core/commit/a83f48c7dc4ba3396047ed638dd838dd398b2a6f
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "ruby-fog" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to ruby-fog+u...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New provider

[geemus (Wesley Beary)]

Mostly you just need to reach out to us. When you are ready, you can add me
(@geemus) as an administrator on your repo and then I can pull it in to the
org. We also ask that you would add a couple of the core folks to the gem
authors, so that we could push emergency releases if it ever came to it.
Beyond that we can advise and provide support as needed.

Does that all make sense? Any other questions or things I can support?

Thanks!
wes

On Wed, Feb 21, 2018 at 10:25 AM, Piotr Kliczewski <
piotr.kliczew...@gmail.com> wrote:

> Hi all,
>
> Currently we are working on new provider [1] for kubevirt [2]. I wonder
> what criteria do we need to meet to become part of fog organization?
> The are 2 commits [3][4] that we would like to make PRs to corresponding
> repos to enable the provider (still WIP).
>
> Thanks,
> Piotr
>
> [1] https://github.com/pkliczewski/fog-kubevirt
> [2] http://www.kubevirt.io/
> [3] https://github.com/masayag/fog/commit/b1ca7425d1a14fe4b25a15649eca1c
> f1450c859e
> [4] https://github.com/masayag/fog-core/commit/
> a83f48c7dc4ba3396047ed638dd838dd398b2a6f
>
> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.