Re: [PATCH] option to tweak letter spacing

2009-05-30 Thread Marc Lehmann
On Thu, May 07, 2009 at 10:20:33AM +0100, "Mark H. Wilkinson" wrote: > So I've implemented an option to allow people to work around these > variations in font metrics. In the same way that the lineSpace option Thanks, this patch/option is now available in current CVS, if anybody wants to try. -

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Marc Lehmann wrote: [Mon May 11 2009, 11:11:45PM EDT] > But it does - the code is obviously the same everyhwree, so it is > consistent. What's not consistent is ther width of the characters another > library hands out, which has nothing to do with urxvt. > > > which is easily understood by the co

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Marc Lehmann wrote: [Mon May 11 2009, 11:06:08PM EDT] > On Mon, May 11, 2009 at 05:41:21PM -0400, Aron Griffis > wrote: > > The current behavior of urxvt is to produce terminals of > > different widths depending on underlying xft libraries, whereas > > So it seems waht is inconsisitent is the u

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Marc Lehmann
On Mon, May 11, 2009 at 11:05:02PM -0400, Aron Griffis wrote: > > > Hi Mark, > > Still Marc. > > Actually I was writing to Mark. Sorry! > > > The only question I have about this issue is: How does > > > gnome-terminal work consistently? > > > > urxvt works consistently as well. > > This stat

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Marc Lehmann
On Mon, May 11, 2009 at 05:41:21PM -0400, Aron Griffis wrote: > The current behavior of urxvt is to produce terminals of > different widths depending on underlying xft libraries, whereas So it seems waht is inconsisitent is the underlying xft (or freetype) libraries. On Mon, May 11, 2009 at 07:

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Marc Lehmann wrote: [Mon May 11 2009, 10:58:24PM EDT] > On Mon, May 11, 2009 at 08:53:14AM -0400, Aron Griffis > wrote: > > Hi Mark, > > Still Marc. Actually I was writing to Mark. > > The only question I have about this issue is: How does > > gnome-terminal work consistently? > > urxvt work

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Marc Lehmann
On Mon, May 11, 2009 at 08:53:14AM -0400, Aron Griffis wrote: > Hi Mark, Still Marc. > The only question I have about this issue is: How does > gnome-terminal work consistently? urxvt works consistently as well. > the wider urxvt font spacing. But if gnome-terminal's method > makes sense, ma

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Aron Griffis wrote: [Mon May 11 2009, 07:57:02PM EDT] > Note this is different from rxvt-unicode which includes > double-width fonts in the rendering test, despite the comment in > rxvtfont.C: Sorry, I didn't mean that the code does something different from what the comment says, just that it men

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Here is how gnome-terminal (libvte9) determines the width of an xft font with pango in vtepangocairo.c: 367 static void 368 font_info_measure_font (struct font_info *info) 369 { 370 PangoRectangle logical; 371 372 /* Estimate for ASCII characters. */ 373 pango_layou

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Mark H. Wilkinson wrote: [Mon May 11 2009, 04:17:38PM EDT] > I don't know, and I don't really have the inclination to dig > into it to find out where the code is that handles the > calculations. Understandable. > It might be > part of Pango, which does text layout for many Gtk applications, or

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Mark H. Wilkinson
On Mon, 2009-05-11 at 08:53 -0400, Aron Griffis wrote: > The only question I have about this issue is: How does > gnome-terminal work consistently? That's unfortunately been my > fallback when the mix of library versions on my system produces > the wider urxvt font spacing. But if gnome-terminal'

Re: [PATCH] option to tweak letter spacing

2009-05-11 Thread Aron Griffis
Hi Mark, The only question I have about this issue is: How does gnome-terminal work consistently? That's unfortunately been my fallback when the mix of library versions on my system produces the wider urxvt font spacing. But if gnome-terminal's method makes sense, maybe it would be appropriate f

Re: [PATCH] option to tweak letter spacing

2009-05-09 Thread Marc Lehmann
On Thu, May 07, 2009 at 10:20:33AM +0100, "Mark H. Wilkinson" wrote: > The patch makes no changes to rxvt's existing font metric computation The patch looks great (including documentation and pelr etc. updates). > Thoughts? I think it's a pretty good idea to have this tunable, and expect it to

[PATCH] option to tweak letter spacing

2009-05-07 Thread Mark H. Wilkinson
Looking back through the archives there's a recurring theme of people having problems with the letter spacing of xft fonts when used with rxvt-unicode. The root cause of this seems to be variability in the metrics reported by different versions of xft - having just upgraded from Ubuntu 8.10 to 9.04