Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Jeroen Demeyer
On 2018-08-22 21:18, Erik Bray wrote: But at the same time pull requests are cheap, and there's no harm in making them. The harm is that discussion is hard to follow because it's on multiple pages. Something that regularly happens on the Sage Trac: 1. Somebody creates an issue 2. Somebody

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Erik Bray
On Wed, Aug 22, 2018 at 8:58 PM Jeroen Demeyer wrote: > > For me, the number 1 thing that our Trac server does better than GitHub > (again, I don't know about GitLab) is that the "branch" field is > mutable: an issue is just a pull request without a branch and I can > change the branch on a pull

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Jeroen Demeyer
For me, the number 1 thing that our Trac server does better than GitHub (again, I don't know about GitLab) is that the "branch" field is mutable: an issue is just a pull request without a branch and I can change the branch on a pull request to add a reviewer patch (sometimes it's easier to add

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Erik Bray
On Wed, Aug 22, 2018 at 5:38 PM Jeroen Demeyer wrote: > > On 2018-08-21 10:43, Erik Bray wrote: > > A second clarification to make is that we are not currently proposing > > to do away with Trac for Sage's ticket database > > I find this quite important. I really really really like the Sage Trac

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Jeroen Demeyer
On 2018-08-21 10:43, Erik Bray wrote: A second clarification to make is that we are not currently proposing to do away with Trac for Sage's ticket database I find this quite important. I really really really like the Sage Trac workflow (much more than I like GitHub; I haven't used GitLab so I

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Erik Bray
On Tue, Aug 21, 2018 at 5:05 PM William Stein wrote: > > On Tue, Aug 21, 2018 at 1:43 AM, Erik Bray wrote: > > > Some of you may remember this is not a first for Sage either: some > > time ago there was a similar experiment done with GitHub, but it fell > > unmaintained. If anyone has any

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-22 Thread Dima Pasechnik
On Tuesday, August 21, 2018 at 1:36:52 PM UTC+3, Erik Bray wrote: > > On Tue, Aug 21, 2018 at 11:21 AM Daniel Krenn > > wrote: > > > > On 08/21/2018 10:43 AM, Erik Bray wrote: > > > https://gitlab.com/sagemath/sage > > > > How do I become a member of the SageMath group (or the project) in

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-21 Thread William Stein
On Tue, Aug 21, 2018 at 1:43 AM, Erik Bray wrote: > Some of you may remember this is not a first for Sage either: some > time ago there was a similar experiment done with GitHub, but it fell > unmaintained. If anyone has any lessons learned from that time, > please add them. I think Robert

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-21 Thread Erik Bray
On Tue, Aug 21, 2018 at 11:21 AM Daniel Krenn wrote: > > On 08/21/2018 10:43 AM, Erik Bray wrote: > > https://gitlab.com/sagemath/sage > > How do I become a member of the SageMath group (or the project) in > Gitlab? (username: dakrenn) Just ask, like you just did :) However, I think until /

Re: [sage-devel] Enabling Merge Requests from GitLab

2018-08-21 Thread Daniel Krenn
On 08/21/2018 10:43 AM, Erik Bray wrote: > https://gitlab.com/sagemath/sage How do I become a member of the SageMath group (or the project) in Gitlab? (username: dakrenn) Best Daniel -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To