Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-28 Thread Gael Varoquaux
On Tue, Jul 24, 2012 at 11:32:19AM +0200, Gael Varoquaux wrote: > * The joblib tests do not seem to be running. I'll see what I can do about > it. Actually, that was easy: it was simply that I had screwed up last time that I updated joblib, and forgot to remove the executable bit: https://github

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-26 Thread Gael Varoquaux
On Thu, Jul 26, 2012 at 08:01:03AM -0700, Jake Vanderplas wrote: > If we think that it's worth updating our arpack clone and copying the > test suite from scipy, I'd be happy to prepare a PR. It would make our > arpack port more stable and increase our test coverage by ~500 lines, > which is a

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-26 Thread Olivier Grisel
2012/7/26 Jake Vanderplas : > Hi, > On 07/26/2012 02:37 AM, Gael Varoquaux wrote: > >> Awesome! I just want to thank the team: after I sent this email a lot of >> different people pitched in and we are now with a coverage level that is >> above where we were a couple month ago: >> https://jenkins.

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-26 Thread Jake Vanderplas
Hi, On 07/26/2012 02:37 AM, Gael Varoquaux wrote: > Awesome! I just want to thank the team: after I sent this email a lot of > different people pitched in and we are now with a coverage level that is > above where we were a couple month ago: > https://jenkins.shiningpanda.com/scikit-learn/job/pyth

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-26 Thread Andreas Müller
> > On Tue, Jul 24, 2012 at 11:32:19AM +0200, Gael Varoquaux wrote: > > On Sat, Jul 21, 2012 at 12:18:46AM +0200, Olivier Grisel wrote: > > > Recent merges have slowly decreased the test coverage ratio of > > > the > > > code base (from nearly 90% down to 85% now): > > > This email discusses how

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-26 Thread Gael Varoquaux
On Tue, Jul 24, 2012 at 11:32:19AM +0200, Gael Varoquaux wrote: > On Sat, Jul 21, 2012 at 12:18:46AM +0200, Olivier Grisel wrote: > > Recent merges have slowly decreased the test coverage ratio of the > > code base (from nearly 90% down to 85% now): > This email discusses how to do something about

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-24 Thread Gael Varoquaux
On Tue, Jul 24, 2012 at 07:37:54PM +1000, Robert Layton wrote: > Thanks for the workflow -- I was not aware of it before! > I'll do some tests for the Spectral clustering now. Thanks Robert, that's extremely useful. As a general rule, we are in dire need of maintenance and improvement of existin

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-24 Thread Robert Layton
On 24 July 2012 19:32, Gael Varoquaux wrote: > On Sat, Jul 21, 2012 at 12:18:46AM +0200, Olivier Grisel wrote: > > Recent merges have slowly decreased the test coverage ratio of the > > code base (from nearly 90% down to 85% now): > > This email discusses how to do something about this. > > I am

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-24 Thread Gael Varoquaux
On Sat, Jul 21, 2012 at 12:18:46AM +0200, Olivier Grisel wrote: > Recent merges have slowly decreased the test coverage ratio of the > code base (from nearly 90% down to 85% now): This email discusses how to do something about this. I am not sure that everybody knows the efficient workflow to imp

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-21 Thread Gael Varoquaux
On Sat, Jul 21, 2012 at 01:07:57AM +0200, Lars Buitinck wrote: > >>> Recent merges have slowly decreased the test coverage ratio of the > >>> code base (from nearly 90% down to 85% now): Yeah. We get a lot of pull requests, but they are seldom about increasing test coverage. Actually, I must confe

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Lars Buitinck
2012/7/21 Olivier Grisel : > I have no tests failing on my box and neither on jenkins. It's just > the coverage that is decreasing. Please report your failures as bug > reports or on the mailing list. Excuse me. I'll try to write some reports when I find the time; the problem is I usually encounte

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Olivier Grisel
2012/7/21 Lars Buitinck : > 2012/7/21 Andreas Mueller : >>> On 07/20/2012 11:18 PM, Olivier Grisel wrote: Recent merges have slowly decreased the test coverage ratio of the code base (from nearly 90% down to 85% now): > > Thanks, I was just about to ask here whether it's normal that more

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Andreas Mueller
>> Btw you can increase test-coverage by installing PIL (or whatever is >> used by scipy.misc.imread) >> on jenkins ;) > @SkipTest? > The dataset test are skipped if it is not possible to load images. -- Live Security Vi

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Lars Buitinck
2012/7/21 Andreas Mueller : >> On 07/20/2012 11:18 PM, Olivier Grisel wrote: >>> Recent merges have slowly decreased the test coverage ratio of the >>> code base (from nearly 90% down to 85% now): Thanks, I was just about to ask here whether it's normal that more and more tests seem to be failing

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Andreas Mueller
On 07/20/2012 11:43 PM, Andreas Mueller wrote: > On 07/20/2012 11:18 PM, Olivier Grisel wrote: >> Hi all, >> >> Recent merges have slowly decreased the test coverage ratio of the >> code base (from nearly 90% down to 85% now): >> >> https://jenkins.shiningpanda.com/scikit-learn/job/python-2.7-numpy

Re: [Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Andreas Mueller
On 07/20/2012 11:18 PM, Olivier Grisel wrote: > Hi all, > > Recent merges have slowly decreased the test coverage ratio of the > code base (from nearly 90% down to 85% now): > > https://jenkins.shiningpanda.com/scikit-learn/job/python-2.7-numpy-1.5.1-scipy-0.10.0/ > > We should be careful not to fo

[Scikit-learn-general] Test coverage is slowly decreasing

2012-07-20 Thread Olivier Grisel
Hi all, Recent merges have slowly decreased the test coverage ratio of the code base (from nearly 90% down to 85% now): https://jenkins.shiningpanda.com/scikit-learn/job/python-2.7-numpy-1.5.1-scipy-0.10.0/ We should be careful not to follow that trend for the next pull request reviews. -- Oli