April White:
The SciTEWin::ProcessExecute() method currently pops a job off the
queue, and I've modified IDM_FINISHEDEXECUTE to receive the job as a
parameter via lparam. I have not altered anything to store the buffer
name so far, but the new code is working.
Oh, I am also planning on on
April White:
I've noticed that I am not deleteing the job object within
ProcessExecute(). I would like to:
- add a variable exitstate to the job class
- return the job as a void * instead of the exitstate
This way the IDM_FINISHEDEXECUTE code can get the exit state and build
flags.
Neil Hodgson wrote:
I've noticed that I am not deleteing the job object within
ProcessExecute(). I would like to:
- add a variable exitstate to the job class
- return the job as a void * instead of the exitstate
This way the IDM_FINISHEDEXECUTE code can get the exit state and build
flags.
Neil Hodgson wrote:
- the buffer flags isDirty and useMonoFont has been encapsulated within
a buffer variable and controlled by enum flags
Grouping all these into a bit set makes it too easy to incorrectly
set multiple states. ... Code that uses bitsets is also longer with extra
April White:
- made the internal global flag isBuilt a buffer flag; if two files
are open that use the go.needs setting, each maintains its own
built status
Good.
- the buffer flags isDirty and useMonoFont has been encapsulated within
a buffer variable and controlled by enum flags
I have uploaded my fourth revision to
http://www.scintilla.org/aprilw/scite-april-2005-11-27.zip
http://www.scintilla.org/aprilw/scite-dev-april-2005-11-10.zip
I included a Changelog.txt file to summarize what I have revised.
This version has:
- improved corrected the handling of
