Re: [Scons-dev] Announcement: Core changes for v2.4 ahead, Switching the Node class to using slots...

2015-03-31 Thread Kenny, Jason L
HI Dirk! So an update. I had a little time yesterday to look at this. I am down to 11 failures. They all seem to be the same issue. Quick summary: I seem to have three issues with the branch as it is. 1) the base node did not have __dict__ in the slots definition. This prevents my monkey

[Scons-dev] Packaging logic?

2015-03-31 Thread Kenny, Jason L
Hi guys, I been fixing up Parts packaging logic so it is pip and wheel friendly. I was wonder what are the plans for SCons on this front? It seems to me that this should not be that complex for us to do in SCons. I just noticed there is a lot of work going on in the current scripts with

Re: [Scons-dev] Announcement: Core changes for v2.4 ahead, Switching the Node class to using slots...

2015-03-31 Thread Kenny, Jason L
for extending Nodes there already exists a dict named attributes. It would be cool if you could rework your patch to use it, instead of reintroducing a dict to the Base class. attributes was added for the original Tag() API to help with RPM builders. I updated this with a MetaTag in Parts that

Re: [Scons-dev] Announcement: Core changes for v2.4 ahead, Switching the Node class to using slots...

2015-03-31 Thread Dirk Bächle
Jason, On 31.03.2015 21:06, Kenny, Jason L wrote: [...] So let me think this out load here. The main issues is that I have properties that I am adding to the node objects and this fails with __slots__ being defined without a __dict__, because I was adding a cache value to the object, vs

Re: [Scons-dev] Announcement: Core changes for v2.4 ahead, Switching the Node class to using slots...

2015-03-31 Thread Dirk Bächle
Hi Jason, On 31.03.2015 16:35, Kenny, Jason L wrote: HI Dirk! So an update. I had a little time yesterday to look at this. I am down to 11 failures. They all seem to be the same issue. Quick summary: I seem to have three issues with the branch as it is. 1) the base node did not have

Re: [Scons-dev] Announcement: Core changes for v2.4 ahead, Switching the Node class to using slots...

2015-03-31 Thread Kenny, Jason L
So adding a __dict__ to __slots__ will add a type 'dict' object. This only get assign dynamic attributes. So there is probably some memory mapped to it for the core dictionary. A test would have to be done to see how much worse it would make it. Most of any memory waste comes from add stuff to