On Sun, Nov 28, 2010 at 08:47:34PM +0200, Gleb Natapov wrote:
> On Sun, Nov 28, 2010 at 12:15:44PM -0500, Kevin O'Connor wrote:
> > It's unclear to me how SeaBIOS is supposed to do that.
> >
> Suppose we have "/p...@i0cf8/s...@3/d...@0,0" with boot index 5
On Mon, Nov 29, 2010 at 11:50:45AM +0100, Gerd Hoffmann wrote:
> >>If scsi card has optionrom with only one bcv then Seabios can determine
> >>its boot order from device path, so why not provide user with this
> >>option today?
> >It's unclear to me how SeaBIOS is supposed to do that.
> Try to keep
On Tue, Nov 30, 2010 at 04:01:00PM +0200, Gleb Natapov wrote:
> On Mon, Nov 29, 2010 at 08:34:03PM -0500, Kevin O'Connor wrote:
> > On Sun, Nov 28, 2010 at 08:47:34PM +0200, Gleb Natapov wrote:
> > > If you let go to the idea of exact matching of string built by qemu in
&
On Wed, Dec 01, 2010 at 02:27:40PM +0200, Gleb Natapov wrote:
> On Tue, Nov 30, 2010 at 09:53:32PM -0500, Kevin O'Connor wrote:
> > BTW, what's the plan for handling SCSI adapters? Lets say a user has
> > a scsi card with three drives (lun 1, lun 3, lun 5) that show up
On Thu, Dec 02, 2010 at 02:30:42PM +0200, Gleb Natapov wrote:
> On Wed, Dec 01, 2010 at 09:25:40PM -0500, Kevin O'Connor wrote:
> > You're thinking in terms of which device to boot, which does make this
> > difficult. However, it's equally valid to think in ter
On Mon, Nov 29, 2010 at 09:42:09AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> Second version of the ahci patches. Rebased to latest master,
> updated according to Kevins review comments.
>
> The patches are also available in the git repository at:
> git://anongit.freedesktop.org/~kraxel/seabios a
The compiler can get confused when referencing a C function in a
different mode. (It reasonably assumes that the C function in the
current mode is desired.) To avoid this compiler confusion, introduce
symbol prefixes (_cfunc16_, _cfunc32flat_, _cfunc32seg_) that must be
used on C function symbols
Make sure to check if CONFIG_AHCI, CONFIG_ATA, CONFIG_USB_MSC is
enabled in their respective cmd_data functions. This reduces the
compile size when they are not enabled.
---
src/ahci.c|3 +++
src/ata.c |3 +++
src/usb-msc.c |3 +++
3 files changed, 9 insertions(+), 0 deletions
On Mon, Dec 06, 2010 at 03:41:05PM +0200, Gleb Natapov wrote:
> Current code creates only one IPL entry of type IPL_TYPE_CDROM even if
> there are more then one CDROM drive present. If CDROM that the entry
> refers to is not bootable there is no way to retry boot from another
> CDROM. Fix this by c
On Tue, Dec 07, 2010 at 05:14:11PM -0800, H. Peter Anvin wrote:
> First of all, sorry for the very late reply, however, I thought I really
> ought to offer my perspective on this:
>
> On 11/25/2010 06:24 AM, Kevin O'Connor wrote:
> > It's difficult to have a un
On Wed, Dec 08, 2010 at 11:24:12AM +0100, Gerd Hoffmann wrote:
> Make sure IO, MMIO and DMA are enabled in pci config space
> before using the device.
[...]
> +cmd = pci_config_readw(bdf, PCI_COMMAND);
> +cmd |= PCI_COMMAND_IO;
> +cmd |= PCI_COMMAND_MEMORY;
> +cmd |= PCI_COMMAND_MAS
On Thu, Dec 09, 2010 at 08:39:46AM +0100, Gerd Hoffmann wrote:
> Make sure IO, MMIO and DMA are enabled in pci config space
> before using the device.
>
> [ v2: use pci_config_maskw ]
>
> Signed-off-by: Gerd Hoffmann
> ---
> src/ahci.c |4
> 1 files changed, 4 insertions(+), 0 deletion
On Wed, Dec 08, 2010 at 02:00:50PM +0200, Gleb Natapov wrote:
> With patch below (goes on top of bev per CD patch) I can specify boot
> order from qemu command line between several NICs, CDROMs, floppy and
> disk. With qemu command like this:
Hi Gleb.
I'm a bit behind right now, but I'll take a l
On Fri, Dec 10, 2010 at 10:33:28AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> >>+u16 cmd;
> >
> >You have an unused variable here.
>
> Ah, right. Howcome gcc didn't warn me on this, usually it does ...
> Is that warning turned off for seabios?
It warns for me.
Compiling whole program out/cc
On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote:
> Use _RMV method to indicate whether device can be removed.
>
> Data is retrieved from QEMU via I/O port 0xae0c.
>
> Signed-off-by: Marcelo Tosatti
Thanks Marcelo,
Can you add acked-bys from the qemu/kvm maintaners?
-Kevin
___
On Tue, Dec 07, 2010 at 01:50:54PM +0200, Gleb Natapov wrote:
> Current code creates only one IPL entry of type IPL_TYPE_CDROM even if
> there are more then one CDROM drive present. If CDROM that the entry
> refers to is not bootable there is no way to retry boot from another
> CDROM. Fix this by c
On Thu, Dec 09, 2010 at 08:39:44AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> Here is a bunch of small fixes for the ahci driver which accumulated
> over the last week.
>
> [ v2: use pci_config_maskw, one patch updated ]
I committed this series.
-Kevin
On Wed, Dec 08, 2010 at 06:00:04PM +0100, Andreas H. wrote:
> Hi,
>
> as part of a small exercise project for university I have to add a
> custom software interrupt to the bios code which is then used by some
> later booting stages. I already had a close look to the sourcefiles
> and although I do
On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote:
> On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote:
> > On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote:
> > > Use _RMV method to indicate whether device can be removed.
> > &g
On Mon, Dec 13, 2010 at 03:12:51PM +0200, Gleb Natapov wrote:
> On Thu, Dec 09, 2010 at 08:27:10PM -0500, Kevin O'Connor wrote:
> > On Wed, Dec 08, 2010 at 02:00:50PM +0200, Gleb Natapov wrote:
> > > With patch below (goes on top of bev per CD patch) I can specify boo
On Mon, Dec 13, 2010 at 08:44:08AM -0500, Kevin O'Connor wrote:
> On Mon, Dec 13, 2010 at 03:12:51PM +0200, Gleb Natapov wrote:
> > On Thu, Dec 09, 2010 at 08:27:10PM -0500, Kevin O'Connor wrote:
> > > On Wed, Dec 08, 2010 at 02:00:50PM +0200, Gleb Natapov wrote:
>
On Thu, Dec 09, 2010 at 03:10:39PM +0200, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov
Looks okay to me. Why "SCSI" though?
-Kevin
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
On Sun, Dec 19, 2010 at 07:25:42PM +0100, Olivier Galibert wrote:
> Current git fails to compile for me with:
[...]
> The interesting parts of the associated objdump are:
>
> Sections:
> Idx Name Size VMA LMA File off Algn
> [...]
> 110 .rodata.__func__.2140 000a 00
On Mon, Dec 20, 2010 at 08:28:54PM +0100, Olivier Galibert wrote:
> On Sun, Dec 19, 2010 at 05:53:44PM -0500, Kevin O'Connor wrote:
> > On Sun, Dec 19, 2010 at 07:25:42PM +0100, Olivier Galibert wrote:
> > > Current git fails to compile for me with:
> > [...]
>
I'm CC'ing the mailing list.
On Tue, Dec 21, 2010 at 10:29:27PM +0100, Stefan Reinauer wrote:
> Hi,
>
> I made these two tiny changes to SeaBIOS when I was playing with the
> HEAD version.
>
> The Makefile change prevents the test command from failing if CC
> contains a space.
>
> The coreboot
On Tue, Dec 21, 2010 at 08:55:25AM +0200, Gleb Natapov wrote:
> Kevin, any additional comments about this patch?
Hi Gleb,
I haven't had a chance to look through your recent changes.
If you break up the patch, I think we can commit most parts now.
-Kevin
On Thu, Dec 23, 2010 at 11:29:37AM +0200, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov
> ---
> src/util.c | 11 +++
> src/util.h |1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
How about this instead?
-Kevin
--- a/src/util.c
+++ b/src/util.c
@@ -262,6 +262,15 @
On Thu, Dec 23, 2010 at 11:29:35AM +0200, Gleb Natapov wrote:
> Fill out entire EDD 3.0 structure for virtio disk. Currently only EDD 1.0
> part is filled which is missing such important info as device path. Use
> SCSI device type since virtio is not defined by EDD spec and virtio disk pci
> device
On Thu, Dec 23, 2010 at 11:29:36AM +0200, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov
Thanks - I applied this.
-Kevin
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
On Thu, Dec 23, 2010 at 11:29:39AM +0200, Gleb Natapov wrote:
> romfile_name() return file name given file handler. Works for qemu and
> coreboot.
>
> Signed-off-by: Gleb Natapov
Thanks - I applied this.
-Kevin
___
SeaBIOS mailing list
SeaBIOS@seabio
so that the bootorder file doesn't need to
be null-terminated (seabios will tack on a trailing null itself).
-Kevin
commit f9b0930ab9efe5f340edbb61f3a5269dbff8c663
Author: Kevin O'Connor
Date: Fri Dec 24 11:15:26 2010 -0500
Add romfile_loadfile() helper function.
Add fu
On Thu, Dec 23, 2010 at 11:29:41AM +0200, Gleb Natapov wrote:
> At the time of bev/bcv initialization the device rom was loaded from is
> no longer know. Only memory address where rom resides is know at this
> point. This patch create mapping between boot priority and rom address
> at rom initializ
On Fri, Dec 24, 2010 at 12:13:14PM -0500, Kevin O'Connor wrote:
> On Thu, Dec 23, 2010 at 11:29:41AM +0200, Gleb Natapov wrote:
> > At the time of bev/bcv initialization the device rom was loaded from is
> > no longer know. Only memory address where rom resides is know at
On Fri, Dec 24, 2010 at 08:41:21PM +0200, Gleb Natapov wrote:
> On Fri, Dec 24, 2010 at 01:33:20PM -0500, Kevin O'Connor wrote:
> > On Fri, Dec 24, 2010 at 12:13:14PM -0500, Kevin O'Connor wrote:
> > > On Thu, Dec 23, 2010 at 11:29:41AM +0200, Gleb Natapov wrote:
&g
On Thu, Dec 23, 2010 at 11:29:42AM +0200, Gleb Natapov wrote:
> For each BAID/BCV/BEV lookup its boot priority in boot order file. If
> there is no entry for a device there assign it the lowest boot priority.
>
> Signed-off-by: Gleb Natapov
It's not clear what the floppy part of this patch does.
On Sun, Dec 26, 2010 at 04:12:21PM +0200, Gleb Natapov wrote:
> On Fri, Dec 24, 2010 at 10:42:50AM -0500, Kevin O'Connor wrote:
> > On Thu, Dec 23, 2010 at 11:29:35AM +0200, Gleb Natapov wrote:
> > > Fill out entire EDD 3.0 structure for virtio disk. Currently only EDD 1
On Sun, Dec 26, 2010 at 05:33:24PM +0200, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov
> ---
> src/boot.c | 77
> +---
> 1 files changed, 63 insertions(+), 14 deletions(-)
>
> diff --git a/src/boot.c b/src/boot.c
> index 8a9246e.
I applied this change.
-Kevin
On Tue, Dec 21, 2010 at 10:29:27PM +0100, Stefan Reinauer wrote:
> Hi,
>
> I made these two tiny changes to SeaBIOS when I was playing with the
> HEAD version.
>
> The Makefile change prevents the test command from failing if CC
> contains a space.
>
> The coreb
On Fri, Dec 24, 2010 at 10:51:08AM +0900, Isaku Yamahata wrote:
> IO port ends at 64K - 1. not 64K.
Thanks - I applied this.
-Kevin
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
e new "bootorder" file reading code.
-Kevin
Kevin O'Connor (2):
Populate drive_g->desc prior to calling add_bcv_internal().
Simplify boot ordering by building an inclusive boot list.
src/ahci.c | 11 +-
src/ata.c| 13 +-
src/block.c | 20 +---
Make sure the description is populated before registering a drive.
---
src/usb-msc.c|5 ++---
src/virtio-blk.c |8 +++-
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/usb-msc.c b/src/usb-msc.c
index 080efdc..48635d9 100644
--- a/src/usb-msc.c
+++ b/src/usb-msc.c
Replace the bcv list with a full list of all "bootable objects". All
ordering can then be done on this list. The final boot menu, drive
mapping, and BEV list generation is then driven from this
authoritative list.
Move "Floppy" and "DVD/CD" description prefixes into drive description
generation
On Sun, Dec 26, 2010 at 11:33:42PM -0500, Kevin O'Connor wrote:
> Replace the bcv list with a full list of all "bootable objects". All
> ordering can then be done on this list. The final boot menu, drive
> mapping, and BEV list generation is then driven from this
> au
On Mon, Dec 27, 2010 at 04:40:25PM +0200, Gleb Natapov wrote:
> For each BAID/BCV/BEV lookup its boot priority in boot order file. If
> there is no entry for a device there assign it the lowest boot priority.
>
> Signed-off-by: Gleb Natapov
Thanks. I reworked this patch a bit and then committed
On Wed, Dec 29, 2010 at 10:16:34AM +0800, Lin Ming wrote:
> # make
> Working around non-functional -combine
> Compiling whole program out/ccode.16.s
> In file included from out/ccode.16.s.tmp.c:5:
> out/../src/util.h:204: warning: ‘memcpy_fl’ declared inline after being called
> out/../src/util
Some cleanups I came across while reviewing the boot code.
Gleb - patch 7 conflicts with your last patch - I hope it isn't a big
deal to fixup though. (I'm still reviewing your last patch.)
-Kevin
Kevin O'Connor (9):
Rename add_ordered_drive() to add_drive() and use
---
src/block.c | 43 ++-
1 files changed, 18 insertions(+), 25 deletions(-)
diff --git a/src/block.c b/src/block.c
index 72b3081..6a3faa3 100644
--- a/src/block.c
+++ b/src/block.c
@@ -30,14 +30,13 @@ getDrive(u8 exttype, u8 extdriveoffset)
int getDrive
Unify the calling of setup_translation().
---
src/ahci.c |2 --
src/ata.c|3 ---
src/block.c |5 -
src/disk.h |1 -
src/usb-msc.c|3 ---
src/virtio-blk.c |1 -
6 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/ahci.c b/src/
The drive description is allocated with malloc_tmp() and is thus only
available during the POST phase - boot_cdrom() is called during the
boot phase.
---
src/boot.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/boot.c b/src/boot.c
i
---
src/boot.c |7 ---
src/boot.h |1 -
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/boot.c b/src/boot.c
index 8e33d53..dacf639 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -86,6 +86,8 @@ int bootprio_find_named_rom(const char *name, int instance)
* Boot setup
The "Drives" struct just held three global variables - declare the
three global variables independently.
---
src/block.c | 22 --
src/cdrom.c |2 +-
src/disk.c |2 +-
src/disk.h |9 +
4 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/src/b
Move the BEV storage to static variables in boot.c.
Also, increase the maximum number of BEV entries from 8 to 20.
---
src/boot.c | 26 +++---
src/boot.h | 19 ---
2 files changed, 19 insertions(+), 26 deletions(-)
diff --git a/src/boot.c b/src/boot.c
inde
---
src/boot.c | 43 +--
1 files changed, 25 insertions(+), 18 deletions(-)
diff --git a/src/boot.c b/src/boot.c
index 9a395c6..5bb179d 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -10,9 +10,9 @@
#include "config.h" // CONFIG_*
#include "disk.h" // cdrom
---
src/boot.c | 17 +
src/boot.h | 10 --
2 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/src/boot.c b/src/boot.c
index 5ae418c..9a395c6 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -14,13 +14,14 @@
#include "cmos.h" // inb_cmos
#include "paravirt.h"
The description field is only available during the POST phase - it is
confusing to have it live in a structure available through all phases.
The description was only used by the boot menu code - pass each drive
description directly to the bootlist code.
Add a helper (znprintf) to automatically ma
On Wed, Dec 29, 2010 at 12:47:14PM -0500, Kevin O'Connor wrote:
> The drive description is allocated with malloc_tmp() and is thus only
> available during the POST phase - boot_cdrom() is called during the
> boot phase.
Odd - two patches got merged into one
On Wed, Dec 29, 2010 at 09:00:36PM +0200, Gleb Natapov wrote:
> On Wed, Dec 29, 2010 at 12:46:45PM -0500, Kevin O'Connor wrote:
> > Some cleanups I came across while reviewing the boot code.
> >
> > Gleb - patch 7 conflicts with your last patch - I hope it isn't
On Wed, Dec 29, 2010 at 10:29:57PM +0200, Gleb Natapov wrote:
> On Wed, Dec 29, 2010 at 02:10:16PM -0500, Kevin O'Connor wrote:
> > BTW, I was thinking of ways to try and simplify this code. What if we
> > tried doing an exact string match for the device, but if that fails
&g
---
src/coreboot.c |2 +-
src/ramdisk.c |9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/coreboot.c b/src/coreboot.c
index b4dfd8a..c9ee082 100644
--- a/src/coreboot.c
+++ b/src/coreboot.c
@@ -605,7 +605,7 @@ register_cbfs_payload(void)
break;
On Thu, Dec 30, 2010 at 08:01:15AM +0200, Gleb Natapov wrote:
> On Wed, Dec 29, 2010 at 08:23:13PM -0500, Kevin O'Connor wrote:
> > Playing around with this a little further, I came up with the below.
> > I'm not sure if it's better.
> >
> For me it look
On Thu, Dec 30, 2010 at 07:55:27PM +0200, Gleb Natapov wrote:
> On Thu, Dec 30, 2010 at 12:20:17PM -0500, Kevin O'Connor wrote:
> > On Thu, Dec 30, 2010 at 08:01:15AM +0200, Gleb Natapov wrote:
> > > For me it looks more complicated (may be because I am more familiar
On Thu, Dec 30, 2010 at 09:31:56PM +0200, Gleb Natapov wrote:
> On Thu, Dec 30, 2010 at 01:56:28PM -0500, Kevin O'Connor wrote:
> > Assuming each bridge takes 15 bytes to describe, one would need around
> > 12 layers of bridges before this was an issue. I don't t
This adds tracking of USB port paths, and enables searching the
bootorder file based on it. It's on top of the other patches I've
sent.
Gleb - I tried adding:
-usb -drive file=dos-drivec,if=none,id=d1 -device
usb-storage,drive=d1,bootindex=1
But qemu didn't add anything to the bootorder file
On Wed, Jan 05, 2011 at 05:19:21PM +0200, Gleb Natapov wrote:
> On Thu, Dec 30, 2010 at 07:02:34PM -0500, Kevin O'Connor wrote:
> > Well, it was pointless for my patch to store the pci path on the stack
> > twice, so I redid that. As you say, though, it's unlikely to b
On Wed, Jan 05, 2011 at 01:10:08PM +0200, Gleb Natapov wrote:
> On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote:
> > Use _RMV method to indicate whether device can be removed.
> >
> > Data is retrieved from QEMU via I/O port 0xae0c.
> >
> > Signed-off-by: Marcelo Tosatti
> >
> A
On Wed, Jan 05, 2011 at 05:18:38PM +0200, Gleb Natapov wrote:
> Some guests (such as Linux) expect BIOS to behave according to T13
> EDD3.0 spec. T13 spec is much better then Phoenix since it provides
> more information about interface and device paths. This patch adds
> support for the spec. If gu
Hi Gleb,
Did you have any thoughts on how to build the PCI device path for the
bootprio_find_X functions?
I suppose we could keep an "int parentbus[256]" and fill it with info
on the parent info of every PCI bus. Then the build_pci_path()
function could reconstruct the path of buses back to the
On Thu, Jan 06, 2011 at 07:09:27AM +0200, Gleb Natapov wrote:
> On Wed, Jan 05, 2011 at 09:32:33PM -0500, Kevin O'Connor wrote:
> > > -SET_INT13DPT(regs, host_bus[3], 0);
> > > +SET_INT13DPT(regs, host_bus[3], ' ');
> >
> > What if
On Thu, Jan 06, 2011 at 03:53:57PM +0200, Gleb Natapov wrote:
> On Thu, Jan 06, 2011 at 08:41:11AM -0500, Kevin O'Connor wrote:
> > On Thu, Jan 06, 2011 at 07:09:27AM +0200, Gleb Natapov wrote:
> > > On Wed, Jan 05, 2011 at 09:32:33PM -0500, Kevin O'Connor wrote:
>
On Thu, Jan 06, 2011 at 04:24:13PM +0200, Gleb Natapov wrote:
> On Thu, Jan 06, 2011 at 09:00:00AM -0500, Kevin O'Connor wrote:
> > On Thu, Jan 06, 2011 at 03:53:57PM +0200, Gleb Natapov wrote:
> > > On Thu, Jan 06, 2011 at 08:41:11AM -0500, Kevin O'Connor wrote:
> &
On Thu, Jan 06, 2011 at 10:04:38PM +0100, Sebastian Herbszt wrote:
> Gleb Natapov wrote:
> >Do you want me to resend with fillchar = t13 ? ' ' : 0; or space should
> >be good enough?
> I suggest to keep the current behaviour if a buffer size of 66
> bytes is supplied; this patch would then be a no-
Introduce function nullTrailingSpace() that nulls blank characters
from the end of a string. Use this function in the ATA, USB MSC, and
bootorder code.
---
src/ata.c |6 +-
src/boot.c|1 +
src/usb-msc.c | 14 --
src/util.c| 10 ++
src/util.h|
On Sun, Jan 09, 2011 at 06:17:13PM +0200, Gleb Natapov wrote:
> On Sun, Jan 09, 2011 at 02:10:51PM +0100, Sebastian Herbszt wrote:
> > I cleared the buffer on each test. Here are the resulting buffers:
Thanks!
> So what about making Seabios to pad with spaces too?
Given the recent investigation,
Improve device path descriptions of devices on PCI buses.
---
src/boot.c | 17 -
src/pci.c | 29 +
src/pci.h |5 +
src/post.c |1 +
4 files changed, 47 insertions(+), 5 deletions(-)
diff --git a/src/boot.c b/src/boot.c
index b59794e..0
On Mon, Jan 10, 2011 at 10:50:27AM +0200, Gleb Natapov wrote:
> Some guests (such as Linux) expect BIOS to behave according to T13
> EDD3.0 spec. T13 spec is much better then Phoenix since it provides
> more information about interface and device paths. This patch adds
> support for the spec. If gu
On Tue, Jan 11, 2011 at 09:37:42AM +0200, Gleb Natapov wrote:
> On Mon, Jan 10, 2011 at 11:28:26PM -0500, Kevin O'Connor wrote:
> > On Mon, Jan 10, 2011 at 10:50:27AM +0200, Gleb Natapov wrote:
> > > Some guests (such as Linux) expect BIOS to behave according to T13
> &g
On Wed, Jan 12, 2011 at 06:23:26PM +0200, Gleb Natapov wrote:
> On Tue, Jan 11, 2011 at 10:32:24PM +0100, Sebastian Herbszt wrote:
> > Gleb Natapov wrote:
> > >On Mon, Jan 10, 2011 at 09:15:19PM +0100, Sebastian Herbszt wrote:
> > >>Should the 0 to space padding part be a separate commit? Some pre-
On Sat, Jan 15, 2011 at 10:56:43AM +0100, Marc Bertens wrote:
> Hi Kevin,
Hi - see below.
>
> I'm adding a VT100 serial console to the seabios code.
> Which can be set to port COM1 or COM2.
> I added the interrupt vector in the serial_setup() routine.
> And made the interrupt service routine.
On Sat, Jan 15, 2011 at 10:56:43AM +0100, Marc Bertens wrote:
> Hi Kevin,
>
> I'm adding a VT100 serial console to the seabios code.
> Which can be set to port COM1 or COM2.
> I added the interrupt vector in the serial_setup() routine.
> And made the interrupt service routine. The compiling goe
On Sat, Jan 15, 2011 at 05:40:11PM +0100, Marc Bertens wrote:
> Kevin,
>
> yea i know about sga bios, i used it for a long time, but not any more.
Okay.
> And the part i'm adding is basically to pick up the keyboard from the
> serial console. And that is not is sgabios.
FYI, sgabios does have
On Sat, Jan 15, 2011 at 09:07:55PM +0100, Marc Bertens wrote:
> Hi Kevin,
>
> Fixed the error on the linker, but now i got another error which i don't
> understand, can you help me ?
>
> make
> Compiling whole program out/ccode.16.s
> Compiling (16bit) out/code16.o
> Compiling whole program
On Sat, Jan 15, 2011 at 10:51:11PM +0100, Marc Bertens wrote:
> Hi Kevin,
>
> Can you tell me what the short 'HDL' stands for in for example
> 'DEBUG_HDL_pmm'
I believe it was shorthand for "handle".
> Currently i'm building a kconfig for seabios
That would be great!
-Kevin
__
On Sat, Jan 15, 2011 at 09:29:07PM +0100, Marc Bertens wrote:
> Keven,
>
> here is the patch, i hope yoiu can see what i'm doing wrong :-)
>
> Marc
The patch had no problem linking on my machine. Can you re-clone,
apply the patch, and verify you still have the failure? If so, please
tar up the
On Sun, Jan 16, 2011 at 03:01:41PM +0100, Sebastian Herbszt wrote:
> please commit the existing patch.
>
> Acked-by: Sebastian Herbszt
I have committed the patch.
-Kevin
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/list
it below is the problem. I tested the kconfig with the
> version before this one, and it
> worked fine.
>
> commit d08eb9c968e519a0b1ba63702acb2115ad536318
> Author: Kevin O'Connor
> Date: Mon Jan 10 00:48:45 2011 -0500
>
> Add ability to track PCI paths and a
On Sun, Jan 16, 2011 at 10:01:13PM +0100, Marc Bertens wrote:
> Kevin,
>
> Do i understand you correctly you want a log of the machine with the
> working version of seabios at debug level 8 ?
A log of the machine running the seabios tip (which I understand is
not working) at debug level 8.
-Kev
C) 2011 Marc Bertens
> + * Copyright (C) 2008-2010 Kevin O'Connor
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of
On Mon, Jan 17, 2011 at 07:35:25PM +0100, Marc Bertens wrote:
> Hmmm, not completely true i'm afraid. When booting a cold systen it will
> not come up.
> When i switch to my fallback rom it boots, now i switch back to the
> image that was not
> booting and now it boots just fine.
>
> So i was a
memset(PCIpaths, 0, sizeof(PCIpaths));
+memset(PCIpaths, 0, sizeof(*PCIpaths) * 256);
int roots = 0;
int bdf, max;
> Marc
>
> On Mon, 2011-01-17 at 14:47 -0500, Kevin O'Connor wrote:
>
> > On Mon, Jan 17, 2011 at 07:35:25PM +0100, Marc Bertens wrote:
> &
On Mon, Jan 17, 2011 at 09:13:47PM +0100, Marc Bertens wrote:
> Kevin,
>
> This is the final patch for Kconfig for SeaBIOS.
>
> Tested-by Marc Bertens
> Signed-off Marc Bertens
>
> Its now all in one big patch, it has now one config.h file. This should
> be straight forward.
Thanks. Unfortu
Make sure the PCI path doesn't point to itself.
---
src/pci.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/pci.c b/src/pci.c
index 45f210d..944a393 100644
--- a/src/pci.c
+++ b/src/pci.c
@@ -194,7 +194,7 @@ pci_path_setup(void)
PCIpaths = malloc_tmp(sizeof(
On Mon, Jan 17, 2011 at 10:40:58PM +0100, Marc Bertens wrote:
> Did it the old way, so that i can understand what i'm sending so that i
> can check what i'm doing is correct, at least to my opinion :-)
Hi Marc,
Your patch doesn't look complete. I get build failures when trying
different build op
On Sun, Jan 23, 2011 at 07:55:23PM +0100, Marc Bertens wrote:
> Kevin,
>
> What kind of errors on which options ? so that i can check my work, i
> use only seabios with coreboot and at the moment only with the defaults.
> But i'm ready to experiment with different options on seabios, due that
> my
On Sun, Jan 23, 2011 at 09:01:41PM +0100, Marc Bertens wrote:
> Kevin,
>
> I'm currently underway of fixing the Kconfig errors, already fixed
> coreboot Y/N issue. But i notice that this takes some work due to the
> way its currently coded.
> i did already boot.c, coreboot.c and ramdisk.c and ther
On Mon, Jan 24, 2011 at 10:50:49AM +0100, Marc Bertens wrote:
> Can you tell me why the SeaBIOS code keeps all its functions even when
> there are not needed?
> Would it nicer to exclude whole pieces of code that are not required?
The build arranges for the compiler and linker to remove the unused
This patch series adds Kconfig to SeaBIOS. The goal is to do this
with a minimal impact to the current SeaBIOS build and config system.
Further build and config changes can be done in subsequent patches.
This imports the latest Kconfig from the Linux 2.6 tree.
-Kevin
Kevin O'Conn
This is a pure copy of the tool from the Linux v2.6.38-rc2
scripts/kconfig/ directory.
---
tools/kconfig/.gitignore | 23 +
tools/kconfig/Makefile | 354 +
tools/kconfig/POTFILES.in| 12 +
tools/kconfig/check.sh | 14 +
---
Makefile | 15 +++
tools/kconfig/Makefile | 29 ++---
tools/kconfig/POTFILES.in| 24
tools/kconfig/gconf.c|2 +-
tools/kconfig/kconfig_load.c |2 +-
5 files changed, 47 insertions(+
Always emit CONFIG_X definitions in autoconf.h - set them to 0 when
they are disabled.
---
tools/kconfig/confdata.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/tools/kconfig/confdata.c b/tools/kconfig/confdata.c
index 61c35bf..f110bf5 100644
--- a/tools/kcon
Create autoconf.h during the build.
Move a couple of config settings from config.h to Kconfig.
---
.gitignore|2 ++
Makefile | 12 +---
src/Kconfig | 15 +++
src/config.h | 11 ++-
src/defconfig |6 ++
5 files changed, 34 insertions(+), 12
1 - 100 of 3555 matches
Mail list logo
