Looks fine to me.
Thanks,
Xuelei
> On Jul 17, 2018, at 9:43 PM, Jamil Nimeh wrote:
>
> Hello all,
>
> This fixes a recent finding in the new TLS code where we're accepting a
> cipher suite that is an empty string where in the past we would throw
> IllegalArgumentException. This fix makes th
Hello all,
This fixes a recent finding in the new TLS code where we're accepting a
cipher suite that is an empty string where in the past we would throw
IllegalArgumentException. This fix makes the new TLS implementation
consistent with the old behavior.
Webrev: http://cr.openjdk.java.net/~
Is it better to append the new lines to the 2nd paragraph?
Thanks
Max
> On Jul 18, 2018, at 9:46 AM, Valerie Peng wrote:
>
>
> Ok, let's use "must" then. I have also added the part about default
> parameters.
> Hope that all is clear now.
>
> Latest webrev: http://cr.openjdk.java.net/~valeri
Hi,
We are working on the JDK 11 close issue.
https://bugs.openjdk.java.net/browse/JDK-8207009
I appreciate if you can help test if we have a patch.
Thanks,
Xuelei
On 7/17/2018 4:26 PM, Tim Brooks wrote:
My understanding is that when you are interested in closing the underlying
socket whe
Ok, let's use "must" then. I have also added the part about default
parameters.
Hope that all is clear now.
Latest webrev: http://cr.openjdk.java.net/~valeriep/8206171/webrev.03/
Latest CSR: https://bugs.openjdk.java.net/browse/JDK-8206864
Thanks,
Valerie
On 7/17/2018 5:50 PM, Weijun Wang w
Ok, I will try add it back.
Thanks,
Valerie
On 7/17/2018 1:14 PM, Sean Mullan wrote:
On 7/16/18 9:46 PM, Valerie Peng wrote:
As for the part about "randomly generated", I am leaning toward not
having it as I don't see a value of specifying this.
Hmm, I think it is important to continue to
> On Jul 18, 2018, at 8:23 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Thanks for the suggestions. Please find comments inline.
>
> On 7/16/2018 7:38 PM, Weijun Wang wrote:
>> CSR at https://bugs.openjdk.java.net/browse/JDK-8206864.
>>
>> - At the end of the 1st paragraph, you have now
>>
>>>
Please review this update for VerifyCACerts test to remove dependency on
OpenJDK build.
@@ -25,7 +25,6 @@
/**
* @test
* @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923
8195774 8199779
- * @requires java.runtime.name ~= "OpenJDK.*"
* @summary Check root
My understanding is that when you are interested in closing the underlying
socket when using the SSLEngine, you must call closeOutbound() and WRAP and
UNWRAP until both isInboundDone() and isOutboundDone() return true.
One edge case of this is if you are interested in closing the socket prior to
Hi Max,
Thanks for the suggestions. Please find comments inline.
On 7/16/2018 7:38 PM, Weijun Wang wrote:
CSR at https://bugs.openjdk.java.net/browse/JDK-8206864.
- At the end of the 1st paragraph, you have now
However, for signature algorithm such as "RSASSA-PSS", it requires
parameters
On 7/16/18 9:46 PM, Valerie Peng wrote:
As for the part about "randomly generated", I am leaning toward not
having it as I don't see a value of specifying this.
Hmm, I think it is important to continue to document the case where an
implementation may return default/generated parameters even i
Dear Security Developer,
Please review the following fix for bug id 8205967. The test associated with
UnboundSSL.java was removed in a previous fix but was still listed in
ProblemList.txt. ProblemList.txt has been updated accordingly by removing the
test.
http://cr.openjdk.java.net/~rhalade/a
thanks… used the wrong mailing list again :(
> On 10. Jul 2018, at 17:57, Alan Bateman wrote:
>
> Forwarding to security-dev.
>
> On 10/07/2018 17:47, Norman Maurer wrote:
>> Hi all,
>>
>> I just tried to run netty[1] testsuite with the latest jdk11 EA release (21)
>> and saw some class-cas
Hi,
Please, could I get comments on the following change?
Since it's related to security, I would be glad if security
experts could also comment on that.
webrev: http://cr.openjdk.java.net/~gromero/POWER9/darn/v6_rebased/
It introduces a way to get benefits from hardware instructions in usersp
Hi Tom,
Were you able to resolve this issue? Even i am facing the same issue with
wildfly 8.2.1 app server.
Thanks
Nagaraju
--
Sent from:
http://openjdk.5641.n7.nabble.com/OpenJDK-Security-Development-f69724.html
On 7/16/2018 8:05 PM, Xuelei Fan wrote:
On 7/16/2018 10:38 AM, Adam Petcher wrote:
New webrev:
http://cr.openjdk.java.net/~apetcher/8206929/webrev.02/
PreSharedKeyExtension.java
447 if (result && !shc.isNegotiable(s.getSuite()) ||
448 !clientHello.cipherSuites.contains(
Looks fine.
--Sean
On 7/16/18 10:54 PM, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8207318/webrev.00/
Here, when hasPassword is true, KeyStore::load(ins,pass) is implemented as
keyStoreSpi.engineLoad(stream, password);
initialized = true;
so I sim
17 matches
Mail list logo
