Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2019-05-09 Thread Weijun Wang
I have read some but probably not as strictly as a reviewer. Anyway, let's start dealing with them one by one. The following 2 lists should have the same orders. https://bugs.openjdk.java.net/issues/?jql=assignee%20%3D%20nwilliams%20ORDER%20BY%20key%20ASC http://cr.openjdk.java.net/~weijun/twos

Code Review Request, 8221253: TLSv1.3 may generate TLSInnerPlainText longer than 2^14+1 bytes

2019-05-09 Thread Xuelei Fan
Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8221253/webrev.00/ Because of the padding impact, the TLS 1.3 record in the JDK Reference implementation could exceed the limit. It is not the expected behavior. Thanks, Xuelei

Re: 8200400: Restrict Sasl mechanisms

2019-05-09 Thread Sean Mullan
Looks good, but just a reminder to change system to security property in the javadoc per Joe's comment in the CSR. --Sean On 5/7/19 11:31 AM, Weijun Wang wrote: Updated webrev at http://cr.openjdk.java.net/~weijun/8200400/webrev.02/ The CSR at https://bugs.openjdk.java.net/browse/JDK-821

Re: RFR: 8191808: Configurable read timeout for CRLs

2019-05-09 Thread Seán Coffey
Thanks. Looks good. regards, Sean. On 09/05/2019 17:38, Sean Mullan wrote: On 5/9/19 11:29 AM, Seán Coffey wrote: Nice feature to have Sean. Thanks. What do you think about adding a debug print if such a value is set ? (perhaps in initializeTimeout method) Good suggestion. I've added the f

Re: RFR: 8191808: Configurable read timeout for CRLs

2019-05-09 Thread Sean Mullan
On 5/9/19 11:29 AM, Seán Coffey wrote: Nice feature to have Sean. Thanks. What do you think about adding a debug print if such a value is set ? (perhaps in initializeTimeout method) Good suggestion. I've added the following to the intializeTimeout method: +private static int initializeTi

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2019-05-09 Thread Nico Williams
On Thu, May 09, 2019 at 12:43:04PM +0800, Weijun Wang wrote: > Also, all your comments and responses posted in the previous mail are > on files but not on a specific bug. Now that all bugs/RFEs are created > [...] When I'm done making the changes I agreed to make, I'll make sure to have a "fixup"

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2019-05-09 Thread Nico Williams
On Thu, May 09, 2019 at 11:40:49AM +0800, Weijun Wang wrote: > Wow, this is overwhelming. Please post updated webrevs here and we will push > the final agreed version, one by one. I posted only the collated commentary from GitHub and my responses to the comments. The "diffs" in the commentary are

Re: RFR: 8191808: Configurable read timeout for CRLs

2019-05-09 Thread Seán Coffey
Nice feature to have Sean. Thanks. What do you think about adding a debug print if such a value is set ? (perhaps in initializeTimeout method) regards, Sean. On 07/05/2019 17:16, Sean Mullan wrote: On 5/7/19 11:28 AM, Xuelei Fan wrote: What do you think if com.sun.security.crl.readtimeout is

Re: RFR 8223063: Support CNG RSA keys

2019-05-09 Thread Weijun Wang
Updated webrev at http://cr.openjdk.java.net/~weijun/8223063/webrev.01/ Mostly test change. One unused export removed. Thanks, Max > On May 1, 2019, at 7:18 AM, Weijun Wang wrote: > > Please take a look at > >https://cr.openjdk.java.net/~weijun/8223063/webrev.00/ > > Unfortunately, a

RFR 8221719: Jarsigner Fails To Verify Signed By Alias If Alias Given In Wrong Case

2019-05-09 Thread Weijun Wang
Hi Philipp, I've posted your patch at http://cr.openjdk.java.net/~weijun/8221719/webrev.00/ Everyone please take a review. I think it looks fine. Just one question: why do you need to create the Manifest in the test. Can you just create a jar without MANIFEST.MF and let jarsigner add it?