Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Lance Andersen
HI Sean, I think the change looks reasonable and I would keep it focused on its current intent for zip files given the problem you were addressing. The test also looks reasonable. Did you give any consideration to throwing a SkippedException if posixAttributes are not supported? Also remember

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Philipp Kunz
Hi Sean, Nice patch. I wonder why permissions should be preserved only in zip files. Jar files also are zip files, according to the jar file specs, and hence, shouldn't jar files benefit of preserving permissions, too? The file name extension is most often zip for zip files and jar for jar files

jtreg test security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java instabilities

2020-01-17 Thread Baesken, Matthias
Hello, I wonder if you have some input regarding the following issue. I noticed a couple of instabilities (in jdk13 and higher) in the test security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java . The test sometimes fails when validating the "validity inte

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Seán Coffey
Hi Philipp, On 17/01/2020 12:40, Philipp Kunz wrote: Hi Sean, Nice patch. I wonder why permissions should be preserved only in zip files. Jar files also are zip files, according to the jar file specs, and hence, shouldn't jar files benefit of preserving permissions, too? Thanks for your comment

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Michael Osipov
Am 2020-01-17 um 11:59 schrieb Seán Coffey: Hi, Looking to introduce some JDK private functionality which will help preserve internal zip file attribute permissions when jarsigner is run on a zip file. Some of the logic is taken from the recent work carried out in this area for zipfs API. h

RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

2020-01-17 Thread Seán Coffey
Hi, Looking to introduce some JDK private functionality which will help preserve internal zip file attribute permissions when jarsigner is run on a zip file. Some of the logic is taken from the recent work carried out in this area for zipfs API. https://bugs.openjdk.java.net/browse/JDK-82180