Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v19]

2022-06-08 Thread Stuart Marks
On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote: >> as title. > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > clean up Calendar Running tests and awaiting review from security team. Our internal test system is backlogged

Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v17]

2022-06-01 Thread Stuart Marks
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote: >> as title. > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > do it as naotoj said Reviewers for i18n, net, nio, and security, please review call site changes in your areas.

Re: RFR: 8286393: Address possibly lossy conversions in java.rmi

2022-05-12 Thread Stuart Marks
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote: > Updates to modules java.rmi and java.smartcardio to remove warnings about > lossy-conversions introduced by PR#8599. > > Explicit casts are inserted where implicit casts occur. > > 8286393: Address possibly lossy conversions in java.rmi >

Re: RFR: 8286393: Address possibly lossy conversions in java.rmi

2022-05-12 Thread Stuart Marks
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote: > Updates to modules java.rmi and java.smartcardio to remove warnings about > lossy-conversions introduced by PR#8599. > > Explicit casts are inserted where implicit casts occur. > > 8286393: Address possibly lossy conversions in java.rmi >

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces [v2]

2022-04-27 Thread Stuart Marks
On Wed, 27 Apr 2022 23:04:47 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/util/AbstractMap.java line 601: >> >>> 599: * {@code Map.entrySet().toArray}. >>> 600: * >>> 601: * @param the type of keys maintained >> >> Please update to match java.util.Map, which says

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

2022-04-26 Thread Stuart Marks
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in

Re: RFR: 8284910: Buffer clean in PasswordCallback [v2]

2022-04-20 Thread Stuart Marks
On Wed, 20 Apr 2022 21:09:54 GMT, Roger Riggs wrote: >>> > Won't there be a small performance hit (perhaps negligible) for code that >>> > already calls clearPassword? >>> >>> The impact should be minimal. If clearPassword() has been called, the >>> cleanup (Cleanerable.clean()) won't happen

Re: RFR: 8186958: Need method to create pre-sized HashMap [v22]

2022-04-18 Thread Stuart Marks
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > java.xml.crypto's usage downgrade grammar to 1.8 I've also written a

Re: RFR: 8186958: Need method to create pre-sized HashMap [v22]

2022-04-18 Thread Stuart Marks
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > java.xml.crypto's usage downgrade grammar to 1.8 Marked as reviewed by

Re: RFR: 8284910: Buffer clean in PasswordCallback [v2]

2022-04-18 Thread Stuart Marks
On Mon, 18 Apr 2022 19:10:44 GMT, Roger Riggs wrote: >> What about code that is already calling `clearPassword` between calls to >> `setPassword`? This seems to be a change in the design of this API. The >> `clearPassword` method is there to allow callers to manage and clear the >> passwords

Re: RFR: 8284910: Buffer clean in PasswordCallback [v2]

2022-04-18 Thread Stuart Marks
On Mon, 18 Apr 2022 15:21:18 GMT, Xue-Lei Andrew Fan wrote: >> Please review this password cleanup enhancement in the PasswordCallback >> implementation. This is one of the effort to clean up the buffered >> passwords. >> >> The PasswordCallback.setPassword() clones the password, but is not

Re: RFR: 8186958: Need method to create pre-sized HashMap [v21]

2022-04-18 Thread Stuart Marks
On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan wrote: >>> Are the changes necessary for this part? >> >> @seanjmullan no, they are just performance refinement. >> >> If you really that wanna 100% sync , >> >> I can use the old 1.8 api to migrate that part, and make a mirror pr to that >> part

Re: RFR: 8186958: Need method to create pre-sized HashMap [v21]

2022-04-14 Thread Stuart Marks
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add `@LastModified: Apr 2022` to DocumentCache > > I learned something new about HashMap today... > > I looked at

Re: RFR: 8186958: Need method to create pre-sized HashMap [v16]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert changes in: >> src/java.desktop >> src/java.management >> src/jdk.internal.vm.ci >> src/jdk.jfr >>

Re: RFR: 8186958: Need method to create pre-sized HashMap [v18]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > update LastModified

Re: RFR: 8186958: Need method to create pre-sized HashMap [v18]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > update LastModified

Re: RFR: 8186958: Need method to create pre-sized HashMap [v18]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > update LastModified

Re: RFR: 8186958: Need method to create pre-sized HashMap [v18]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > update LastModified src/java.base/share/classes/java/lang/Character.java

Re: RFR: 8186958: Need method to create pre-sized HashMap [v16]

2022-04-13 Thread Stuart Marks
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in: > src/java.desktop > src/java.management >

Re: RFR: 8282819: Deprecate Locale class constructors

2022-03-24 Thread Stuart Marks
On Thu, 24 Mar 2022 22:01:30 GMT, Naoto Sato wrote: > Proposing to deprecate the constructors in the `java.util.Locale` class. > There is already a factory method and a builder to return singletons, so > there is no need to have constructors anymore unless one purposefully wants > to create

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed

2021-12-24 Thread Stuart Marks
On Wed, 22 Dec 2021 22:01:00 GMT, Kevin Walls wrote: >> src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java line 51: >> >>> 49: private static RemoteHost remoteHost; >>> 50: >>> 51: private static final String rmiFilterPattern = >>>

[jdk18] Integrated: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-22 Thread Stuart Marks
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote: > Enable the security manager in rmiregistry's launcher arguments. This pull request has now been integrated. Changeset: 04ee9211 Author: Stuart Marks URL: https://git.openjdk.java.net/jdk18/com

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Stuart Marks
On Wed, 22 Dec 2021 01:18:58 GMT, Stuart Marks wrote: >> Enable the security manager in rmiregistry's launcher arguments. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Change java.security.manag

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Stuart Marks
> Enable the security manager in rmiregistry's launcher arguments. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Change java.security.manager to "allow"; filter warning lines from VersionCheck - Cha

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-20 Thread Stuart Marks
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote: > Enable the security manager in rmiregistry's launcher arguments. I think there's little to worry about with custom configurations of the `rmiregistry` tool. What somebody might do is to enable a customized security manager us

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Stuart Marks
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API

Integrated: 8267123: Remove RMI Activation

2021-05-27 Thread Stuart Marks
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote: > This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). > > This is a fairly straightforward removal of this component. > - Activation implementation classes removed > - Activation tests removed &

Re: RFR: 8267123: Remove RMI Activation

2021-05-26 Thread Stuart Marks
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote: > This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). > > This is a fairly straightforward removal of this component. > - Activation implementation classes removed > - Activation tests removed &

RFR: 8267123: Remove RMI Activation

2021-05-25 Thread Stuart Marks
This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). This is a fairly straightforward removal of this component. - Activation implementation classes removed - Activation tests removed - adjustments to various comments to remove references to Activation - adjustments to

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Stuart Marks
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining Marked as reviewed by smarks (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3182

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-29 Thread Stuart Marks
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining The removal of the obsolescent "As of release 1.4, this exception has been retrofitted..." is good. Changing the calls from the other exception-getting methods to

Re: RFR: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable

2021-03-08 Thread Stuart Marks
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the `instanceof` pattern > variable? > > Kind regards, > Patrick Marked as reviewed by

Re: RFR: 8250564: Remove terminally deprecated constructor in GSSUtil

2021-01-05 Thread Stuart Marks
On Tue, 5 Jan 2021 21:02:21 GMT, Joe Darcy wrote: > Back in JDK 16, two unintended default constructors were identified and > deprecated for removal. The time has come to remove them. > > Please also review the corresponding CSRs: > > JDK-8258521 Remove terminally deprecated constructor in

Re: RFR: 8258588: MD5 MessageDigest in java.util.UUID should be cached

2020-12-18 Thread Stuart Marks
On Fri, 18 Dec 2020 19:04:36 GMT, Sean Mullan wrote: >>> MD5 and DES were removed as SE requirements in JDK 14. See >>> https://bugs.openjdk.java.net/browse/JDK-8214483 for more information. >>> However, there are no plans to remove the implementations from the JDK at >>> this time. >> >> In

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-06 Thread Stuart Marks
On Tue, 6 Oct 2020 05:07:37 GMT, Tagir F. Valeev wrote: >> Sorry to be late to the party. I thought that all reviews labeled with >> core-libs should be mirrored to core-libs-dev >> mailing list but I haven't seen it there :( >> Please note that the integrated implementation exposes

Integrated: 8156071: List.of: reduce array copying during creation

2020-10-05 Thread Stuart Marks
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fix

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 06:26:39 GMT, Martin Grigorov wrote: >> Plumb new internal static factory method to trust the array passed in, >> avoiding unnecessary copying. JMH results for >> the benchmark show about 15% improvement for the cases that were optimized, >> namely the 3 to 10 fixed arg

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fix

RFR: 8156071: List.of: reduce array copying during creation

2020-09-30 Thread Stuart Marks
Plumb new internal static factory method to trust the array passed in, avoiding unnecessary copying. JMH results for the benchmark show about 15% improvement for the cases that were optimized, namely the 3 to 10 fixed arg cases. # VM options: -verbose:gc -XX:+UseParallelGC -Xms4g -Xmx4g

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your

Re: RFR [14] JDK-8227024 : Remove the deprecated javax.security.cert APIs

2019-07-09 Thread Stuart Marks
On 7/8/19 3:27 PM, Xuelei Fan wrote: Thanks for looking into the update.  The "forRemoval=true" tag was added in March 2010 (JDK-8160247).  It make sense to me to postpone the removal until JDK 15. I re-targeted the RFE and CSR to JDK 15. March 2010?!? Oh, whew, that's just a typo, should

Re: RFR [14] JDK-8227024 : Remove the deprecated javax.security.cert APIs

2019-07-08 Thread Stuart Marks
Hi, thanks for asking about this. There's not much process, but there unfortunately is some that isn't quite written down yet. :-) Essentially something must be deprecated for removal in some release prior to it actually being removed in a subsequent release. In the "old days" of multi-year

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-04 Thread Stuart Marks
llan/webrevs/8191053/webrev.02/docs/api/java.base/java/lang/SecurityManager.html http://cr.openjdk.java.net/~mullan/webrevs/8191053/webrev.02/docs/api/java.base/java/lang/System.html On 10/3/18 7:11 PM, Stuart Marks wrote: Hi Sean, The new arrangement of using special tokens for java.security.

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-03 Thread Stuart Marks
Hi Sean, The new arrangement of using special tokens for java.security.manager makes a lot more sense than having a separate property. Overall, the proposed semantics seem reasonable to me. I have some suggestions to clarify the proposed specification. (But also see below.) From webrev.01:

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-13 Thread Stuart Marks
I'd guess that security-dev would have reviewers for the change to default.policy. Cc'd. s'marks On 9/13/18 2:43 PM, Sergey Bylokhov wrote: Hello. Please review fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8210692 Webrev: http://cr.openjdk.java.net/~serb/8210692/webrev.00

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-09-13 Thread Stuart Marks
Hi Sean, Looks sensible to me. On 9/13/18 1:02 PM, Sean Mullan wrote: 2. A new JDK-specific system property to disallow the setting of the security manager at run-time: jdk.allowSecurityManager If set to false, it allows the run-time to optimize the code and improve performance when it is

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-09-10 Thread Stuart Marks
On 9/10/18 5:13 PM, Weijun Wang wrote: On Sep 11, 2018, at 3:29 AM, Langer, Christoph wrote: Ok, maybe it should be named "priviledgedGetOverridable" then. Ah yes. My mistake. Small spelling nit: there's no "d" before "g", so this should likely be privilegedGetOverridable

Re: RFR: 8173827: Remove forRemoval=true from several deprecated security APIs

2017-02-02 Thread Stuart Marks
Hi Claes, The text of JEP 277 [1] has the following: Given the history of deprecation in Java SE, and the emphasis on long term API compatibility across versions, removal of an API is a matter of serious concern. Therefore, deprecation with the element |forRemoval=true| should be applied only

hg: jdk8/tl/jdk: 8027536: rmic: add deprecation warning message when generating JRMP static stubs/skeletons

2013-12-13 Thread stuart . marks
Changeset: 6c343d3d2721 Author:smarks Date: 2013-12-13 18:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c343d3d2721 8027536: rmic: add deprecation warning message when generating JRMP static stubs/skeletons Reviewed-by: mchung, dmocek !

hg: jdk8/tl/jdk: 7190106: java/rmi/reliability/benchmark fails intermittently because of use of fixed port

2013-12-03 Thread stuart . marks
Changeset: df819e356901 Author:tyan Date: 2013-12-03 14:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df819e356901 7190106: java/rmi/reliability/benchmark fails intermittently because of use of fixed port Reviewed-by: smarks, mduigou ! test/ProblemList.txt !

hg: jdk8/tl/jdk: 8028757: CharSequence.subSequence improperly requires a new CharSequence be returned

2013-12-03 Thread stuart . marks
Changeset: accd6ffd4b3f Author:smarks Date: 2013-12-03 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/accd6ffd4b3f 8028757: CharSequence.subSequence improperly requires a new CharSequence be returned Reviewed-by: alanb, darcy, mduigou !

hg: jdk8/tl/jdk: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

2013-12-03 Thread stuart . marks
Changeset: c6b6b515cf4f Author:smarks Date: 2013-12-03 18:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6b6b515cf4f 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted Reviewed-by: darcy, lancea, mduigou !

hg: jdk8/tl/jdk: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

2013-11-19 Thread stuart . marks
Changeset: 19d2e9649138 Author:smarks Date: 2013-11-19 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Reviewed-by: lancea ! test/java/rmi/testlibrary/RMID.java

hg: jdk8/tl/jdk: 8028027: serialver should emit declaration with the 'private' modifier

2013-11-12 Thread stuart . marks
Changeset: f6012ca3bdd3 Author:smarks Date: 2013-11-12 16:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3 8028027: serialver should emit declaration with the 'private' modifier Reviewed-by: darcy, mchung, alanb, chegar !

hg: jdk8/tl/jdk: 8023863: deprecate support for statically-generated stubs from RMI (JRMP); ...

2013-10-30 Thread stuart . marks
Changeset: 1ea1b24c1a04 Author:smarks Date: 2013-10-30 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04 8023863: deprecate support for statically-generated stubs from RMI (JRMP) 4449028: exportObject() javadoc should specify behavior for null socket

hg: jdk8/tl/jdk: 5063500: Formatter spec says char is not an integral type; ...

2013-10-25 Thread stuart . marks
Changeset: 8ea272253285 Author:smarks Date: 2013-10-25 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ea272253285 5063500: Formatter spec says char is not an integral type 7126305: Wrong Unicode value specified for format conversion character 'd' 8027287: incorrect

hg: jdk8/tl/jdk: 8023862: deprecate HTTP proxying from RMI

2013-10-24 Thread stuart . marks
Changeset: 808b9ef4f667 Author:smarks Date: 2013-10-24 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667 8023862: deprecate HTTP proxying from RMI Reviewed-by: mchung ! src/share/classes/java/rmi/server/RMISocketFactory.java !

hg: jdk8/tl/jdk: 8026427: deprecate obsolete APIs from java.rmi

2013-10-22 Thread stuart . marks
Changeset: 9fbf35589211 Author:smarks Date: 2013-10-22 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211 8026427: deprecate obsolete APIs from java.rmi Reviewed-by: alanb, dfuchs ! src/share/classes/java/rmi/RMISecurityManager.java !

hg: jdk8/tl/jdk: 8023447: change specification to allow RMI activation to be optional

2013-09-09 Thread stuart . marks
Changeset: 6731ea9123f2 Author:smarks Date: 2013-09-09 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6731ea9123f2 8023447: change specification to allow RMI activation to be optional Reviewed-by: darcy, alanb, olagneau !

hg: jdk8/tl/jdk: 8022412: Fixed warnings in java.util root, except for HashMap

2013-08-06 Thread stuart . marks
Changeset: 12c1b78acf9a Author:lagergren Date: 2013-08-06 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a 8022412: Fixed warnings in java.util root, except for HashMap Reviewed-by: mduigou, darcy Contributed-by: marcus.lagerg...@oracle.com !

Re: Code review request, 7127524 P11TlsPrfGenerator has anonymous inner class with serialVersionUID

2013-08-05 Thread Stuart Marks
On 8/5/13 9:16 AM, Tom Hawtin wrote: On 01/08/2013 06:36, Xuelei Fan wrote: An anonymous class cannot make any guarantees about serialization compatibility since has a compiler-generated, implementation-specific name that may vary uncontrollably. It is nonsensical for an anonymous class to

hg: jdk8/tl/jdk: 8020854: change RMI javadocs to specify that remote objects are exported to the wildcard address

2013-08-05 Thread stuart . marks
Changeset: 31759750ff63 Author:smarks Date: 2013-08-05 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31759750ff63 8020854: change RMI javadocs to specify that remote objects are exported to the wildcard address Reviewed-by: rgallard, alanb !

hg: jdk8/tl/jdk: 8020977: StringJoiner merges with itself not as expected

2013-07-30 Thread stuart . marks
Changeset: 09a77a1bdbc3 Author:henryjen Date: 2013-07-30 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a77a1bdbc3 8020977: StringJoiner merges with itself not as expected Reviewed-by: psandoz, chegar, mduigou, smarks ! src/share/classes/java/util/StringJoiner.java

hg: jdk8/tl/jdk: 8019224: add exception chaining to RMI CGIHandler

2013-06-27 Thread stuart . marks
Changeset: 6729f7ef94cd Author:smarks Date: 2013-06-27 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6729f7ef94cd 8019224: add exception chaining to RMI CGIHandler Reviewed-by: darcy ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java

Re: hg: jdk8/tl/jdk: 8019224: add exception chaining to RMI CGIHandler

2013-06-27 Thread Stuart Marks
Hi Bernd, A fair question. The Throwable.printStackTrace() call goes to the standard error stream, which is *usually* not mixed with the HTTP response collected from stdout and thus shouldn't spoil the protocol. But this really depends on how it's invoked. My assumption is that stderr is

hg: jdk8/tl: 8016780: README-builds.html misses crucial requirement on bootstrap JDK

2013-06-18 Thread stuart . marks
Changeset: b9587f41fd55 Author:smarks Date: 2013-06-18 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55 8016780: README-builds.html misses crucial requirement on bootstrap JDK Reviewed-by: dholmes, chegar ! README-builds.html

hg: jdk8/tl/jdk: 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-17 Thread stuart . marks
Changeset: 79fed1733d4a Author:jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number

hg: jdk8/tl/jdk: 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures

2013-01-10 Thread stuart . marks
Changeset: 13ff1089e625 Author:jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup

hg: jdk8/tl/jdk: 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently

2013-01-07 Thread stuart . marks
Changeset: 797e8a3dcd51 Author:smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to

hg: jdk8/tl/jdk: 8005118: Javadoc styles are inconsistent

2013-01-02 Thread stuart . marks
Changeset: cc78ceb99284 Author:jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy !

hg: jdk8/tl/jdk: 2 new changesets

2012-12-28 Thread stuart . marks
Changeset: 0cfcba56cfa7 Author:jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore !

hg: jdk8/tl/jdk: 8005290: remove -showversion from RMI test library subprocess mechanism

2012-12-20 Thread stuart . marks
Changeset: 60adb69bf043 Author:smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java !

hg: jdk8/tl/jdk: 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

2012-12-12 Thread stuart . marks
Changeset: 56fd5479a98f Author:jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning

hg: jdk8/tl/jdk: 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread stuart . marks
Changeset: a971516029ab Author:jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks !

hg: jdk8/tl/jdk: 8004131: move jdi tests out of core testset

2012-11-29 Thread stuart . marks
Changeset: 83d9f30ebeed Author:smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83d9f30ebeed 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties

hg: jdk8/tl/jdk: 8004134: More ProblemList.txt updates (11/2012)

2012-11-29 Thread stuart . marks
Changeset: 7ccf93c60c4d Author:smarks Date: 2012-11-29 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ccf93c60c4d 8004134: More ProblemList.txt updates (11/2012) Reviewed-by: alanb Contributed-by: amy...@oracle.com ! test/ProblemList.txt

Re: Code review request: 7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so

2012-09-25 Thread Stuart Marks
On 9/25/12 12:58 AM, Alan Bateman wrote: On 25/09/2012 05:16, Weijun Wang wrote: Hi Stuart Please take a look at http://cr.openjdk.java.net/~weijun/7200682/webrev.00/ So I am now using java -XshowSettings:properties | grep os.arch to find out the arch. Not sure if there is a more formal

hg: jdk8/tl/jdk: 7193406: Clean-up JDK Build Warnings in java.util, java.io

2012-09-11 Thread stuart . marks
Changeset: 1f7c783e4f13 Author:dxu Date: 2012-08-31 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7c783e4f13 7193406: Clean-up JDK Build Warnings in java.util, java.io Summary: Clean-up JDK Build Warnings in java.util, java.io Packages Reviewed-by: smarks, darcy,

hg: jdk8/tl/jdk: 7195099: update problem list with RMI test failures

2012-08-30 Thread stuart . marks
Changeset: f9b11772c4b2 Author:smarks Date: 2012-08-30 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9b11772c4b2 7195099: update problem list with RMI test failures Reviewed-by: alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7187876: ClassCastException in TCPTransport.executeAcceptLoop

2012-08-02 Thread stuart . marks
Changeset: 8a82e5f9c47f Author:dmocek Date: 2012-08-02 18:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a82e5f9c47f 7187876: ClassCastException in TCPTransport.executeAcceptLoop Reviewed-by: dholmes, smarks ! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java

hg: jdk8/tl/jdk: 7186111: fix bugs in java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup

2012-07-27 Thread stuart . marks
Changeset: 018e555a7a07 Author:dmocek Date: 2012-07-27 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/018e555a7a07 7186111: fix bugs in java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup Reviewed-by: smarks, jgish !

hg: jdk8/tl/jdk: 7184943: fix failing test com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java; ...

2012-07-18 Thread stuart . marks
Changeset: 89129c0737f1 Author:dmocek Date: 2012-07-18 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89129c0737f1 7184943: fix failing test com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java 7184946: fix failing test

hg: jdk8/tl/jdk: 7142596: RMI JPRT tests are failing

2012-07-17 Thread stuart . marks
Changeset: b6f78869c66d Author:dmocek Date: 2012-07-17 11:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f78869c66d 7142596: RMI JPRT tests are failing Summary: Changed RMI tests to use random port numbers for the RMI Registry and RMID so the tests can be run

hg: jdk8/tl/jdk: 6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-05 Thread stuart . marks
Changeset: 97eb7a4b1fdd Author:smarks Date: 2012-07-05 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd 6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently Reviewed-by: dholmes, smarks Contributed-by: Eric Wang

hg: jdk8/tl/jdk: 7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently

2012-07-05 Thread stuart . marks
Changeset: 4ad204cc7433 Author:smarks Date: 2012-07-05 15:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad204cc7433 7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently Reviewed-by: dholmes, smarks Contributed-by: Eric Wang yiming.w...@oracle.com

hg: jdk8/tl/jdk: 7170938: (str) incorrect wording in doc for String.subSequence

2012-06-29 Thread stuart . marks
Changeset: 9df29b658145 Author:smarks Date: 2012-06-29 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9df29b658145 7170938: (str) incorrect wording in doc for String.subSequence Reviewed-by: forax, mduigou Contributed-by: Joe Bowbeer joe.bowb...@gmail.com !

hg: jdk8/tl/jdk: 7117230: clean up warnings in java.text

2012-05-24 Thread stuart . marks
Changeset: e309917fb9af Author:dbhole Date: 2012-05-24 19:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af 7117230: clean up warnings in java.text Reviewed-by: jrose, smarks ! src/share/classes/java/text/AttributedCharacterIterator.java !

hg: jdk8/tl/jdk: 7159130: add java/rmi/transport/pinClientSocketFactory to problem list

2012-04-04 Thread stuart . marks
Changeset: 19c6ad447258 Author:dmocek Date: 2012-04-04 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19c6ad447258 7159130: add java/rmi/transport/pinClientSocketFactory to problem list Reviewed-by: smarks ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7122061: add -Xlint:all -Werror to warning-free build steps

2011-12-29 Thread stuart . marks
Changeset: 3a7ea63302f8 Author:smarks Date: 2011-12-29 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8 7122061: add -Xlint:all -Werror to warning-free build steps Reviewed-by: chegar, alanb, dholmes, ohair ! make/com/sun/demo/jvmti/hprof/Makefile !

hg: jdk8/tl/jdk: 7122235: stop the build if javac fails

2011-12-17 Thread stuart . marks
Changeset: abbca81a98a7 Author:smarks Date: 2011-12-17 08:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abbca81a98a7 7122235: stop the build if javac fails Reviewed-by: chegar, dholmes, mcimadamore, ohair ! make/common/Rules.gmk

hg: jdk8/tl/jdk: 7118546: fix warnings in javax.xml.crypto, javax.script

2011-12-08 Thread stuart . marks
Changeset: 9bb7c3b97384 Author:smarks Date: 2011-12-08 14:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384 7118546: fix warnings in javax.xml.crypto, javax.script Reviewed-by: mullan ! src/share/classes/javax/script/ScriptException.java !

hg: jdk8/tl/jdk: 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip

2011-12-07 Thread stuart . marks
Changeset: 4f0f9f9c4892 Author:smarks Date: 2011-12-07 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Reviewed-by: alanb, dholmes, forax, sherman, smarks Contributed-by: Prasannaa

please review fix for 7118546, warnings cleanup in javax.xml.crypto

2011-12-07 Thread Stuart Marks
Webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7118546/webrev.0/ Notes: In addition to changes to javax.xml.crypto, this webrev also includes a change to a file in javax.script. This package (among others) is included in the same build step as javax.xml.crypto, specifically in

hg: jdk8/tl/jdk: 7116993: fix warnings in java.applet

2011-12-05 Thread stuart . marks
Changeset: f4fe86bba8a2 Author:smarks Date: 2011-12-05 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe86bba8a2 7116993: fix warnings in java.applet Reviewed-by: art, smarks Contributed-by: Danesh Dadachanji ddada...@redhat.com !

hg: jdk8/tl/jdk: 7116890: additional warnings fixes for java.io

2011-12-01 Thread stuart . marks
Changeset: 0e3f706741ca Author:smarks Date: 2011-12-01 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e3f706741ca 7116890: additional warnings fixes for java.io Reviewed-by: alanb, smarks Contributed-by: Sebastian Sickelmann sebastian.sickelm...@gmx.de !

hg: jdk8/tl/jdk: 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list

2011-08-12 Thread stuart . marks
Changeset: 3f66f9ca1ba5 Author:smarks Date: 2011-08-12 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list Reviewed-by: weijun, alanb ! test/ProblemList.txt

hg: jdk7/tl/jdk: 6896297: (rmi) fix ConcurrentModificationException causing TCK failure

2011-04-20 Thread stuart . marks
Changeset: 00f3997e6aeb Author:smarks Date: 2011-04-20 16:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00f3997e6aeb 6896297: (rmi) fix ConcurrentModificationException causing TCK failure Reviewed-by: alanb, dholmes, peterjones !

hg: jdk7/tl/jdk: 7029680: fix test/sun/misc/Version/Version.java build parsing

2011-03-24 Thread stuart . marks
Changeset: f326a018fd3f Author:smarks Date: 2011-03-24 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326a018fd3f 7029680: fix test/sun/misc/Version/Version.java build parsing Reviewed-by: ohair ! test/sun/misc/Version/Version.java

hg: jdk7/tl/jdk: 7022382: convert pack200 library code to use try-with-resources

2011-03-17 Thread stuart . marks
Changeset: 192bbf6cd5de Author:smarks Date: 2011-03-17 18:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/192bbf6cd5de 7022382: convert pack200 library code to use try-with-resources Reviewed-by: ksrini ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java !

hg: jdk7/tl/jdk: 7022624: use try-with-resources in java.io tests

2011-03-01 Thread stuart . marks
Changeset: 98d2d57d9e73 Author:smarks Date: 2011-03-01 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98d2d57d9e73 7022624: use try-with-resources in java.io tests Reviewed-by: alanb ! test/java/io/File/SetLastModified.java !

  1   2   >