a.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
> On Nov 16, 2015, at 3:19 PM, Vincent Ryan wrote:
>
> Yes the source changes look fine.
> Last week I ran the tests using webrev.4 and all passed.
FYI: webrev.6 also pass.
--Max
>
> T
Weijun [mailto:weijun.w...@oracle.com]
Sent: Freitag, 13. November 2015 17:08
To: Langer, Christoph
Cc: Vincent Ryan ; security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
It is my understanding that if you write multiple files for a single
@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Yes the source changes look fine.
Last week I ran the tests using webrev.4 and all passed.
Thanks Christoph for the comprehensive fix.
> On 16 Nov 2015, at 00:32, Wang Weijun wrote:
>
> All t
> On Nov 16, 2015, at 3:19 PM, Vincent Ryan wrote:
>
> Yes the source changes look fine.
> Last week I ran the tests using webrev.4 and all passed.
FYI: webrev.6 also pass.
--Max
>
> Thanks Christoph for the comprehensive fix.
Yes the source changes look fine.
Last week I ran the tests using webrev.4 and all passed.
Thanks Christoph for the comprehensive fix.
> On 16 Nov 2015, at 00:32, Wang Weijun wrote:
>
> All tests look fine.
>
> I suppose Vincent already agreed with the src change. Right?
>
> For safety, I am
All tests look fine.
I suppose Vincent already agreed with the src change. Right?
For safety, I am running all related tests on windows-i586 and windows-x64 now.
Thanks
Max
> On 2015年11月16日, at 上午7:27, Langer, Christoph wrote:
>
> Hi Max,
>
> thanks for that hint about correctly referencing
436.6/
Best regards
Christoph
-Original Message-
From: Wang Weijun [mailto:weijun.w...@oracle.com]
Sent: Samstag, 14. November 2015 03:32
To: Langer, Christoph
Cc: Vincent Ryan ; security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
d
ph
>
> -Original Message-
> From: Wang Weijun [mailto:weijun.w...@oracle.com]
> Sent: Freitag, 13. November 2015 17:08
> To: Langer, Christoph
> Cc: Vincent Ryan ; security-dev@openjdk.java.net
> Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incom
It is my understanding that if you write multiple files for a single test, they
should be put inside a sub-directory.
But in this case you can combine them into a single class by putting the
provider-related codes into static inner classes.
--Max
P. S. Sent from my iPhone so I haven't read al
: sun.security.mscapi.KeyStore might load incomplete
data
> On Nov 13, 2015, at 7:12 AM, Langer, Christoph
> wrote:
>
> Hi Vincent,
>
> I just updated the changeset with a
> testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/
>
> The testcase would run through with or without m
Christoph
From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
Sent: Mittwoch, 11. November 2015 13:18
To: Langer, Christoph
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Unfortunately I cannot push a changeset without a jtreg test.
Can you validate the fix
Also there is a standard way to check if it's windows:
http://openjdk.java.net/jtreg/tag-spec.html#requires_names
os.family should be the one to use.
--Max
>
>> I just updated the changeset with a
>> testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/
>>
> On Nov 13, 2015, at 7:12 AM, Langer, Christoph
> wrote:
>
> Hi Vincent,
>
> I just updated the changeset with a
> testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/
>
> The testcase would run through with or without my patch, unless you specify
> the IAIK provider as explai
Nov message when it came past. No further objections. But
> still unclear if modularization will permit this.
>
> Mike
>
>
>
> Thanks
> Christoph
>
> From: Langer, Christoph
> Sent: Mittwoch, 4. November 2015 12:11
> To: 'Michael StJohns' &
care.
Christoph
From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
Sent: Mittwoch, 11. November 2015 08:46
To: Mike StJohns ; Langer, Christoph
Cc: security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Explicitly referencing the Sun
StJohns ; Langer, Christoph
Cc: security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Explicitly referencing the Sun JCE provider makes the jdk.crypto.mscapi module
depend on the java.base module.
And that’s OK.
I can sponsor this
anger, Christoph
>> Sent: Mittwoch, 4. November 2015 12:11
>> To: 'Michael StJohns' <mailto:mstjo...@comcast.net>
>> Cc: security-dev@openjdk.java.net <mailto:security-dev@openjdk.java.net>
>> Subject: RE: RFR 8139436: sun.security.mscapi.KeyStore mig
:* Mittwoch, 4. November 2015 12:11
*To:* 'Michael StJohns'
*Cc:* security-dev@openjdk.java.net
*Subject:* RE: RFR 8139436: sun.security.mscapi.KeyStore might load
incomplete data
Hi Mike,
eventually I’ve made a new webrev implementing your suggestion for a
simpler pat
Hi folks,
is there any feedback/review for this change?
Thanks
Christoph
From: Langer, Christoph
Sent: Mittwoch, 4. November 2015 12:11
To: 'Michael StJohns'
Cc: security-dev@openjdk.java.net
Subject: RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
...@comcast.net]
Sent: Donnerstag, 15. Oktober 2015 02:09
To: Langer, Christoph
Cc: security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Sorry for the top post, I'm wring this on an iPad on a plane.
It's perfectly acceptable for a p
ke StJohns
> Sent: Mittwoch, 14. Oktober 2015 02:17
> To: security-dev@openjdk.java.net
> Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
> data
>
> Hi -
>
> I took a look and this probably isn't the correct way to fix this.
>
>
y-dev-boun...@openjdk.java.net] On Behalf Of
Mike StJohns
Sent: Mittwoch, 14. Oktober 2015 02:17
To: security-dev@openjdk.java.net
Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete
data
Hi -
I took a look and this probably isn't the correct way to fix this.
A simpl
Hi -
I took a look and this probably isn't the correct way to fix this.
A simpler change might be to specify the sun provider when requesting
the certificate factory.I hesitate to say that definitively as
modularization guidance may restrict that approach?
The belt and suspenders approac
23 matches
Mail list logo
