On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 3 May 2022 23:10:51 GMT, Xue-Lei Andrew Fan wrote:
> Could someone in Oracle help to run the Mach5 testing for security and
> network components (or just tier1 and tier2), and let me know if this update
> causes any failures?
Builds underway.
-
PR: https://git.openjdk.jav
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 3 May 2022 02:02:58 GMT, Xue-Lei Andrew Fan wrote:
>>> Thanks for the rewording. Updated.
>>
>> I made one more tweak that reads better.
>
> Yes, it looks better. Updated. Thanks!
Looks good, thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/8065
On Mon, 2 May 2022 17:55:56 GMT, Bradford Wetmore wrote:
>> Thanks for the rewording. Updated.
>
>> Thanks for the rewording. Updated.
>
> I made one more tweak that reads better.
Yes, it looks better. Updated. Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/8065
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
More n
On Mon, 2 May 2022 17:45:44 GMT, Xue-Lei Andrew Fan wrote:
> Thanks for the rewording. Updated.
I made one more tweak that reads better.
-
PR: https://git.openjdk.java.net/jdk/pull/8065
On Mon, 2 May 2022 16:46:17 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comment about remove finalize() method
>
> src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
update
On Mon, 2 May 2022 05:01:21 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Sat, 30 Apr 2022 03:46:23 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comment about remove finalize() method
>
> src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.jav
On Wed, 27 Apr 2022 06:55:42 GMT, Xue-Lei Andrew Fan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - typo blank linke correction
>> - revise the update
>
> ping ...
> @XueleiFan, would you please add a no
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
commen
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 14 Apr 2022 15:37:05 GMT, Daniel Jeliński wrote:
> IMO we should not send close_notify in the finalizer. It's the application's
> responsibility to send close_notify when it's done with the socket; we should
> not pretend that it was closed normally when it was not.
@djelinski makes an
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Sat, 9 Apr 2022 14:59:13 GMT, Xue-Lei Andrew Fan wrote:
> The existing behavior is trying to close the socket and send the
> close_notify. As the socket closure has been done in the SocketImpl, I think
> BaseSSLSocketImpl could rely on to the SocketImpl cleaner. So the left for
> the cleani
On Sat, 9 Apr 2022 11:52:01 GMT, Alan Bateman wrote:
> What is the existing behavior with the BaseSSLSocketImpl finalizer? Does it
> just close the socket or does it to the close_notify before closing the
> socket. If it does, and you want to keep that behavior, then you are probably
> into si
On Fri, 8 Apr 2022 22:55:07 GMT, Bradford Wetmore wrote:
> @AlanBateman, @dfuch, @bchristi-git, any great ideas here?
As you have found, if an open Socket is unreferenced then a cleaner can close
the underlying socket (and release the file descriptor). The Cleaner is setup
by the SocketImpl im
On Fri, 8 Apr 2022 06:52:57 GMT, Xue-Lei Andrew Fan wrote:
> The Socket implementation will take care of the file description/native
> memory release, I think.
I've walked through the network code and understand it now. The Socket
creation code calls into sun.nio.ch.NioSocketImpl.create():451
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 7 Apr 2022 22:49:24 GMT, Bradford Wetmore wrote:
> > The socket close() call in the finalize() method may be blocked for the SSL
> > implementation, which is not good for garbage collection. It should be safe
> > by just removing the finalize() method.
`>
> Can you provide more detail?
On Thu, 7 Apr 2022 20:11:25 GMT, Xue-Lei Andrew Fan wrote:
> The socket close() call in the finalize() method may be blocked for the SSL
> implementation, which is not good for garbage collection. It should be safe
> by just removing the finalize() method.
Can you provide more detail? I expec
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Xue-Lei Andrew Fan has updated the pull request incrementally with two
additional commits since the last revision:
- typo
On Thu, 31 Mar 2022 20:15:35 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
The socket close() call in the finalize() method may be blocke
On Thu, 31 Mar 2022 20:15:35 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the SunJSSE provider
> implementation. It is one of the efforts to clean up the use of finalizer
> method in JDK.
Need an update, close the review for now.
-
PR:
33 matches
Mail list logo
