HI Sean,
Looks OK based on our exchanges. Thank you for your time on this one!
Best
Lance
> On Jun 22, 2020, at 7:22 AM, Seán Coffey wrote:
>
> Thanks Lance.
>
> I've updated the patch with some extra offline feedback from yourself and Max.
> A new warning is printed with use of the new flag
Thanks Lance.
I've updated the patch with some extra offline feedback from yourself
and Max.
A new warning is printed with use of the new flag. A warning is also
printed when file posix permissions are detected on resources being
signed. Test updated for that also.
https://cr.openjdk.java.ne
Hi Sean,
I think your changes look fine so all good FMPOV.
Best
Lance
> On Jun 12, 2020, at 6:21 AM, Seán Coffey wrote:
>
> Hi,
>
> I'd like to reboot this jarsigner enhancement request[1]. I've removed the
> problem references to zip file name extensions. Instead, there's a new JDK
> imple
Hi,
I'd like to reboot this jarsigner enhancement request[1]. I've removed
the problem references to zip file name extensions. Instead, there's a
new JDK implementation specific jarsigner option: -keepposixperms
https://bugs.openjdk.java.net/browse/JDK-8218021
https://cr.openjdk.java.net/~cof
On 17/01/2020 10:59, Seán Coffey wrote:
Hi,
Looking to introduce some JDK private functionality which will help
preserve internal zip file attribute permissions when jarsigner is run
on a zip file. Some of the logic is taken from the recent work carried
out in this area for zipfs API.
https
Hi Philipp,
thanks for the reply .. comments inline
On 19/01/20 16:09, Philipp Kunz wrote:
Hi Sean,
I figure that distinguishing zips and jars is ambiguous in a certain
way. After having signed a zip, it contains a manifest and is also a
jar file according to the specs. That would mean we woul
HI Sean,
I think the change looks reasonable and I would keep it focused on its current
intent for zip files given the problem you were addressing.
The test also looks reasonable. Did you give any consideration to throwing a
SkippedException if posixAttributes are not supported?
Also remember
Hi Sean,
Nice patch. I wonder why permissions should be preserved only in zip
files. Jar files also are zip files, according to the jar file specs,
and hence, shouldn't jar files benefit of preserving permissions, too?
The file name extension is most often zip for zip files and jar for jar
files
Hi Philipp,
On 17/01/2020 12:40, Philipp Kunz wrote:
Hi Sean,
Nice patch. I wonder why permissions should be preserved only in zip
files. Jar files also are zip files, according to the jar file specs,
and hence, shouldn't jar files benefit of preserving permissions, too?
Thanks for your comment
Am 2020-01-17 um 11:59 schrieb Seán Coffey:
Hi,
Looking to introduce some JDK private functionality which will help
preserve internal zip file attribute permissions when jarsigner is run
on a zip file. Some of the logic is taken from the recent work carried
out in this area for zipfs API.
h
Hi,
Looking to introduce some JDK private functionality which will help
preserve internal zip file attribute permissions when jarsigner is run
on a zip file. Some of the logic is taken from the recent work carried
out in this area for zipfs API.
https://bugs.openjdk.java.net/browse/JDK-82180
11 matches
Mail list logo
