> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error code
> mappings.
>
> For the native headers, it's a
On Wed, 4 Nov 2020 21:06:35 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated the javadoc comments of PKCS11Constants class with additional
>> typedef info
>> Updated the legal file to
On Wed, 4 Nov 2020 20:52:11 GMT, Valerie Peng wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update?
>>
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error code
> mappings.
>
> For the native headers, it's a
On Tue, 3 Nov 2020 16:58:45 GMT, Weijun Wang wrote:
>
>
> https://github.com/openjdk/jdk/blob/0b37b821a10325d9083c23130e4b8921812ed9c5/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java#L54
>
> I cannot add comments to unchanged lines in
On Mon, 2 Nov 2020 21:33:31 GMT, Weijun Wang wrote:
>>>
>>>
>>> Just curious, can the Java files be generated during the build process?
>>
>> Hmm, maybe, by the java files, do you just mean PKCS11Constants class or
>> more? I am not familiar with how to generate Java files during the build
On Fri, 30 Oct 2020 21:47:51 GMT, Valerie Peng wrote:
> > Just curious, can the Java files be generated during the build process?
>
> Hmm, maybe, by the java files, do you just mean PKCS11Constants class or
> more? I am not familiar with how to generate Java files during the build
> process,
On Sat, 31 Oct 2020 00:06:01 GMT, Hai-May Chao wrote:
>> These three are just by themselves, so unless you feel strongly about, I
>> prefer just leave them here which matches the ordering of pkcs11t.h, i.e.
>> right before the CKM_VENDOR_DEFINED line.
>
> Just thought they could be moved like
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error code
> mappings.
>
> For the native headers, it's a
On Sat, 31 Oct 2020 03:28:24 GMT, Weijun Wang wrote:
>
>
> > > The constants in PKCS11Exception are duplicated in PKCS11Constants.
> > > ```
> > > 0x,
> > > ```
> > >
> > >
> > > vs
> > > ```
> > > public static final long CKR_OK = 0xL;
> > > ```
On Fri, 30 Oct 2020 21:55:10 GMT, Valerie Peng wrote:
> > The constants in PKCS11Exception are duplicated in PKCS11Constants.
> > ```
> > 0x,
> > ```
> >
> >
> > vs
> > ```
> > public static final long CKR_OK = 0xL;
> > ```
> >
> >
> > Is there
On Fri, 30 Oct 2020 21:44:00 GMT, Valerie Peng wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java
>> line 987:
>>
>>> 985: public static final long CKM_SP800_108_FEEDBACK_KDF =
>>> 0x03adL;
>>> 986: public static final long
On Fri, 30 Oct 2020 21:39:42 GMT, Valerie Peng wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java
>> line 1095:
>>
>>> 1093: addMech(CKM_SP800_108_FEEDBACK_KDF,
>>> "CKM_SP800_108_FEEDBACK_KDF");
>>> 1094:
On Fri, 30 Oct 2020 14:43:20 GMT, Weijun Wang wrote:
>
>
> The constants in PKCS11Exception are duplicated in PKCS11Constants.
>
> ```
> 0x,
> ```
>
> vs
>
> ```
> public static final long CKR_OK = 0xL;
> ```
>
> Is there any way to simplify it?
On Thu, 29 Oct 2020 03:18:33 GMT, Weijun Wang wrote:
>
>
> Just curious, can the Java files be generated during the build process?
Hmm, maybe, by the java files, do you just mean PKCS11Constants class or more?
I am not familiar with how to generate Java files during the build process, can
On Thu, 29 Oct 2020 02:16:15 GMT, Hai-May Chao wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update?
>>
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and
On Thu, 29 Oct 2020 02:07:39 GMT, Hai-May Chao wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update?
>>
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and
On Thu, 29 Oct 2020 02:06:06 GMT, Hai-May Chao wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update?
>>
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and
On Thu, 29 Oct 2020 03:18:33 GMT, Weijun Wang wrote:
>> Changes look good. Only minor comments.
>
> Just curious, can the Java files be generated during the build process?
The constants in PKCS11Exception are duplicated in PKCS11Constants.
0x,
vs
public static final long
On Thu, 29 Oct 2020 02:18:00 GMT, Hai-May Chao wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update?
>>
>> Changes are straight-forward as below:
>> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
>> 2) Updated java side w/ the new constants definitions and
On Wed, 28 Oct 2020 21:35:25 GMT, Valerie Peng wrote:
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error
Could someone please help review this PKCS#11 v3.0 header files update?
Changes are straight-forward as below:
1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
2) Updated java side w/ the new constants definitions and name/error code
mappings.
For the native headers, it's a direct copy of the
22 matches
Mail list logo
