Re: RFR: 8256507: Add a micro benchmark for JDK-8153005 [v3]

2020-11-20 Thread Weijun Wang
> This is a micro benchmark for various algorithm settings of PKCS keystores. > Strong for new algorithms and weak for old ones. Different iteration counts > are tried. The result should show that the current setting (strong1) is > more efficient than old setting (weak5). Weijun Wang ha

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005 [v2]

2020-11-19 Thread Weijun Wang
On Thu, 19 Nov 2020 07:58:36 GMT, Aleksey Shipilev wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> not static anymore > > test/micro/org/openjdk/bench/java/security/PKCS12KeyStores.java line 46: > >> 44: public cla

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005 [v2]

2020-11-19 Thread Aleksey Shipilev
On Wed, 18 Nov 2020 18:53:21 GMT, Weijun Wang wrote: >> This is a micro benchmark for various algorithm settings of PKCS keystores. >> Strong for new algorithms and weak for old ones. Different iteration counts >> are tried. The result should show that the current setting (strong1) is >> m

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005 [v2]

2020-11-18 Thread Weijun Wang
> This is a micro benchmark for various algorithm settings of PKCS keystores. > Strong for new algorithms and weak for old ones. Different iteration counts > are tried. The result should show that the current setting (strong1) is > more efficient than old setting (weak5). Weijun Wang ha

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005 [v2]

2020-11-18 Thread Weijun Wang
On Wed, 18 Nov 2020 13:50:14 GMT, Aleksey Shipilev wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> not static anymore > > I think the benchmark can be simplified. New commit. No more static fields. Thanks. @shipile

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005

2020-11-18 Thread Aleksey Shipilev
On Wed, 18 Nov 2020 14:49:54 GMT, Weijun Wang wrote: >> test/micro/org/openjdk/bench/java/security/PKCS12KeyStores.java line 65: >> >>> 63: } >>> 64: >>> 65: static { >> >> Move these to >> >> @Setup >> public void setup() throws Exception { >> ... >> } >> >> This would save you a

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005

2020-11-18 Thread Weijun Wang
On Wed, 18 Nov 2020 13:46:04 GMT, Aleksey Shipilev wrote: >> This is a micro benchmark for various algorithm settings of PKCS keystores. >> Strong for new algorithms and weak for old ones. Different iteration counts >> are tried. The result should show that the current setting (strong1) is

Re: RFR: 8256507: Add a micro benchmark for JDK-8153005

2020-11-18 Thread Aleksey Shipilev
On Tue, 17 Nov 2020 21:46:38 GMT, Weijun Wang wrote: > This is a micro benchmark for various algorithm settings of PKCS keystores. > Strong for new algorithms and weak for old ones. Different iteration counts > are tried. The result should show that the current setting (strong1) is > more

RFR: 8256507: Add a micro benchmark for JDK-8153005

2020-11-17 Thread Weijun Wang
This is a micro benchmark for various algorithm settings of PKCS keystores. Strong for new algorithms and weak for old ones. Different iteration counts are tried. The result should show that the current setting (strong1) is more efficient than old setting (weak5). - Commit