On Tue, 26 Apr 2022 15:45:47 GMT, Xue-Lei Andrew Fan wrote:
>> Ok, then I would suggest changing the name of the test as it is misleading.
>> I suggest creating a directory named "PasswordCallback" and then adding a
>> test named perhaps "CheckCleanerNotBoundToThis" or something like that. I
On Tue, 26 Apr 2022 15:19:30 GMT, Sean Mullan wrote:
>> The test case is used to check that the Cleaner used is not bind to 'this'
>> object, and the cleaner during finalization could work. Unfortunately, as
>> the cleaner behavior is not visible, I don't find a way to automated test
>> that
On Tue, 26 Apr 2022 04:27:37 GMT, Xue-Lei Andrew Fan wrote:
>> test/jdk/javax/security/auth/callback/PasswordCleanup.java line 74:
>>
>>> 72: }
>>> 73:
>>> 74: private static void checkClearing() throws Exception {
>>
>> How is this test testing that the password is cleared?
>
> The
On Mon, 25 Apr 2022 20:41:47 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code clean up per feedback
>
> test/jdk/javax/security/auth/callback/PasswordCleanup.java line 58:
>
>> 56:
On Mon, 25 Apr 2022 20:37:38 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code clean up per feedback
>
> test/jdk/javax/security/auth/callback/PasswordCleanup.java line 83:
>
>> 81:
On Thu, 21 Apr 2022 06:55:22 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this password cleanup enhancement in the PasswordCallback
>> implementation. This is one of the effort to clean up the buffered
>> passwords.
>>
>> The PasswordCallback.setPassword() clones the password, but is not
> Please review this password cleanup enhancement in the PasswordCallback
> implementation. This is one of the effort to clean up the buffered passwords.
>
> The PasswordCallback.setPassword() clones the password, but is not registered
> for cleanup. An application could call clearPassword()
