The updated webrev looks good.
--Sean
On 3/27/18 4:23 PM, Adam Petcher wrote:
After the last code review[1] on this topic completed, it was suggested
that I add some more "spec enforcement" to the XDH service. The code
hasn't been integrated yet, so I'm doing this as a follow-on review
under
After the last code review[1] on this topic completed, it was suggested
that I add some more "spec enforcement" to the XDH service. The code
hasn't been integrated yet, so I'm doing this as a follow-on review
under the same ticket. The latest webrev contains only the diff from the
end of the la
Latest webrev: http://cr.openjdk.java.net/~apetcher/8171277/webrev.02/
This webrev incorporates the changes from the field arithmetic code (in
my other code review), as well as changes from Sean's comments.
On 3/15/2018 2:46 PM, Sean Mullan wrote:
I reviewed the rest of the code and only hav
I reviewed the rest of the code and only have 2 other comments:
* XECIterative.java
53: typo s/taks/takes
* Convert.java
Since these are static methods that could be useful to other regression
tests, consider moving this to a test library location and using the
jtreg @library label. However,
On 3/9/18 8:25 AM, Adam Petcher wrote:
New webrev: http://cr.openjdk.java.net/~apetcher/8171277/webrev.01/
I think somewhere there should be a sentence or two on the difference
between XECKeys and ECKeys and when you would want to use each. This
is important enough that I think some detail s
New webrev: http://cr.openjdk.java.net/~apetcher/8171277/webrev.01/
On 3/8/2018 1:51 PM, Sean Mullan wrote:
I haven't reviewed all of it (mainly just the standard classes), but
here are some comments so far:
- General comments
For new public classes, you don't need to start the sentence with
I haven't reviewed all of it (mainly just the standard classes), but
here are some comments so far:
- General comments
For new public classes, you don't need to start the sentence with the
name of the class since that is implied and will show up in javadoc
pages. For example, "XECKey is an in
Webrev: http://cr.openjdk.java.net/~apetcher/8171277/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8171277
Please review this change that adds key agreement via the X25519 and
X448 elliptic curve functions to the JCA API and SunEC provider. These
functions and related operations and
