Re: SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-11 Thread Xuelei Fan
On 6/11/2018 7:59 AM, Weijun Wang wrote: On Jun 11, 2018, at 10:32 PM, Xuelei Fan wrote: The protocols (for example, SSLParameters::getProtocols) are now from new to old, which is opposite from the previous order. Why make this change? You didn't answer this. I missed this one. The

Re: SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-11 Thread Weijun Wang
> On Jun 11, 2018, at 10:32 PM, Xuelei Fan wrote: > >> The protocols (for example, SSLParameters::getProtocols) are now from new to >> old, which is opposite from the previous order. Why make this change? You didn't answer this. >> 41 * Instances of this class are immutable after the con

Re: SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-11 Thread Xuelei Fan
On 6/11/2018 7:36 AM, Weijun Wang wrote: On Jun 11, 2018, at 10:32 PM, Xuelei Fan wrote: Another thing in CipherSuite.java: 803 static CipherSuite nameOf(String ciperSuiteName) { Why isn't this method named valueOf()? There is a default builtin valueOf(String) method for enum type.

Re: SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-11 Thread Weijun Wang
> On Jun 11, 2018, at 10:32 PM, Xuelei Fan wrote: > >> >> Another thing in CipherSuite.java: >> 803 static CipherSuite nameOf(String ciperSuiteName) { >> Why isn't this method named valueOf()? > There is a default builtin valueOf(String) method for enum type. Ah, I see. But given the r

Re: SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-11 Thread Xuelei Fan
Update: http://hg.openjdk.java.net/jdk/sandbox/rev/12e20a7d6e26 On 6/10/2018 10:37 PM, Weijun Wang wrote: The protocols (for example, SSLParameters::getProtocols) are now from new to old, which is opposite from the previous order. Why make this change? 41 * Instances of this class are immu

SSLContextImpl.java (was Re: Code Review Request: TLS 1.3 Implementation)

2018-06-10 Thread Weijun Wang
The protocols (for example, SSLParameters::getProtocols) are now from new to old, which is opposite from the previous order. Why make this change? 41 * Instances of this class are immutable after the context is initialized. You mean instances of child of this class? It looks like this class i