On Thu, 17 Feb 2022 23:28:35 GMT, Weijun Wang wrote:
> Updating to a recent release of PSL.
Marked as reviewed by ahmadsha...@github.com (no known OpenJDK username).
-
PR: https://git.openjdk.java.net/jdk/pull/7526
On Thu, 17 Feb 2022 19:00:47 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the attached patch to address
>>
>> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
>> parameter
>> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
On Fri, 18 Feb 2022 06:56:04 GMT, Michael Osipov wrote:
>> Yes. I don't want to let the method fail. Since `instanceof String` should
>> be called anyway the caller can decide how to fail.
>
> So you leave it to the user to read the ASN.1 value and fail if the encoding
> is incorrect instead of
On Fri, 18 Feb 2022 15:06:07 GMT, Weijun Wang wrote:
>> So you leave it to the user to read the ASN.1 value and fail if the encoding
>> is incorrect instead of throwing a `Ceritificate..Exception` although other
>> GeneralNames do?
>
> I want to minimize behavior change and I'm leaving them to
On Fri, 18 Feb 2022 12:09:53 GMT, Alan Bateman wrote:
> The updates changes to ZipFile/JarFile look okay. I don't have time to study
> the test too closely right now but it will need to include instructions on
> how to re-create the signed JAR that is stored in the byte array.
Those instructio
On Fri, 18 Feb 2022 15:17:30 GMT, Michael Osipov wrote:
>> I want to minimize behavior change and I'm leaving them to notice there's no
>> string there and fail.
>
> While I understand that, `new DerValue(byte[])` will be ignored and this will
> be also inconsistent with the remaining general n
On Fri, 18 Feb 2022 16:28:25 GMT, Weijun Wang wrote:
>> While I understand that, `new DerValue(byte[])` will be ignored and this
>> will be also inconsistent with the remaining general names. Looking at
>> sun.security.x509.GeneralName.GeneralName(DerValue, boolean) they all throw
>> `IOExcept
On Thu, 17 Feb 2022 23:28:35 GMT, Weijun Wang wrote:
> Updating to a recent release of PSL.
This pull request has now been integrated.
Changeset: 7ce75afb
Author:Weijun Wang
URL:
https://git.openjdk.java.net/jdk/commit/7ce75afbbcca7635356c7377be7ddff15335e563
Stats: 1254 lines i
On Fri, 18 Feb 2022 16:25:30 GMT, Lance Andersen wrote:
> > The updates changes to ZipFile/JarFile look okay. I don't have time to
> > study the test too closely right now but it will need to include
> > instructions on how to re-create the signed JAR that is stored in the byte
> > array.
>
>
On Fri, 18 Feb 2022 17:05:53 GMT, Alan Bateman wrote:
> > > The updates changes to ZipFile/JarFile look okay. I don't have time to
> > > study the test too closely right now but it will need to include
> > > instructions on how to re-create the signed JAR that is stored in the
> > > byte array
On Fri, 18 Feb 2022 17:15:17 GMT, Lance Andersen wrote:
> If you feel there is still something lacking for documentation, I can
> certainly make another pass clarify/add it, but I tried to cover the steps
> (but I also understand what might be obvious to me might not be as obvious as
> I thoug
We are checking with CA if root cert can be removed. Meanwhile, updated test to
add expiry exception.
-
Commit messages:
- 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in
May 2022
Changes: https://git.openjdk.java.net/jdk/pull/7537/files
Webrev: https://
OtherName.java @93,97
PR:https://git.openjdk.java.net/jdk/pull/7167
if (derValue1.isContextSpecific((byte) 0) &&
derValue1.isConstructed()) {
nameValue = derValue1.data.toByteArray();
} else {
throw new IOException("value is not [0]");
}
That ex
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
> unexpected exception occurs
>
> Mach5 tiers1-3 runs are clean
On Fri, 18 Feb 2022 17:20:26 GMT, Alan Bateman wrote:
> > If you feel there is still something lacking for documentation, I can
> > certainly make another pass clarify/add it, but I tried to cover the steps
> > (but I also understand what might be obvious to me might not be as obvious
> > as I
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
> unexpected exception occurs
>
> Mach5 tiers1-3 runs are clean
> Hi all,
>
> Please review the attached patch to address
>
> - That JarFile::getInputStream did not check for a null ZipEntry passed as a
> parameter
> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an
> unexpected exception occurs
>
> Mach5 tiers1-3 runs are clean
On Thu, 17 Feb 2022 16:00:46 GMT, Weijun Wang wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
>> output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
>> without the tag an
> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
> output for an OtherName.
>
> It also fix several errors:
> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
> without the tag and length bytes.
> 2. The argument in constructor `extClass.ge
On Fri, 18 Feb 2022 18:24:46 GMT, Rajan Halade wrote:
> We are checking with CA if root cert can be removed. Meanwhile, updated test
> to add expiry exception.
Looks fine to me.
-
Marked as reviewed by weijun (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7537
On Fri, 18 Feb 2022 18:24:46 GMT, Rajan Halade wrote:
> We are checking with CA if root cert can be removed. Meanwhile, updated test
> to add expiry exception.
This pull request has now been integrated.
Changeset: d3749de4
Author:Rajan Halade
URL:
https://git.openjdk.java.net/jdk/c
Could someone please help review this trivial change? This is to add an error
handling for the potential CKR_BUFFER_TOO_SMALL error when calling C_Sign().
Since none of the supported signature algorithms trigger this error as the
default buffer size is large enough, this is more for consistency
On Fri, 18 Feb 2022 21:52:59 GMT, Valerie Peng wrote:
> Could someone please help review this trivial change? This is to add an error
> handling for the potential CKR_BUFFER_TOO_SMALL error when calling C_Sign().
> Since none of the supported signature algorithms trigger this error as the
> de
On Fri, 18 Feb 2022 22:10:17 GMT, Mikael Vidstedt wrote:
>> Could someone please help review this trivial change? This is to add an
>> error handling for the potential CKR_BUFFER_TOO_SMALL error when calling
>> C_Sign(). Since none of the supported signature algorithms trigger this
>> error as
> Could someone please help review this trivial change? This is to add an error
> handling for the potential CKR_BUFFER_TOO_SMALL error when calling C_Sign().
> Since none of the supported signature algorithms trigger this error as the
> default buffer size is large enough, this is more for cons
On Sat, 19 Feb 2022 00:07:34 GMT, Valerie Peng wrote:
>> Could someone please help review this trivial change? This is to add an
>> error handling for the potential CKR_BUFFER_TOO_SMALL error when calling
>> C_Sign(). Since none of the supported signature algorithms trigger this
>> error as th
On Sat, 19 Feb 2022 00:07:34 GMT, Valerie Peng wrote:
>> Could someone please help review this trivial change? This is to add an
>> error handling for the potential CKR_BUFFER_TOO_SMALL error when calling
>> C_Sign(). Since none of the supported signature algorithms trigger this
>> error as th
On 2/18/2022 3:05 PM, Weijun Wang wrote:
On Thu, 17 Feb 2022 16:00:46 GMT, Weijun Wang wrote:
The enhancement adds two extra items in the `getSubjectAlternativeNames()`
output for an OtherName.
It also fix several errors:
1. In `OtherName.java`, `nameValue` should be the value inside `CONTEX
On Fri, 18 Feb 2022 20:05:46 GMT, Weijun Wang wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
>> output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
>> without the tag an
On Fri, 18 Feb 2022 21:52:59 GMT, Valerie Peng wrote:
> Could someone please help review this trivial change? This is to add an error
> handling for the potential CKR_BUFFER_TOO_SMALL error when calling C_Sign().
> Since none of the supported signature algorithms trigger this error as the
> de
30 matches
Mail list logo
