Hi Sean,
Thanks for the updates. Looks like the details are all there now. One minor
point:
87 * If a class name is specified, it must be {@code
java.lang.SecurityManager}
88 * or a public subclass and have a public no-arg constructor. The class is
89 * loaded by the {@linkplain
Excellent comments, Stuart. Thanks for taking the time to review this.
I have posted another review that should address most of your comments,
but also responded inline with replies below.
http://cr.openjdk.java.net/~mullan/webrevs/8191053/webrev.02/
I also posted the javadoc so you can see
On Thu, Oct 04, 2018 at 11:19:06AM +0100, Alan Bateman wrote:
> On 03/10/2018 21:49, Nico Williams wrote:
> >:
> >A lot of these changes are interrelated. Reviewing them in order of
> >size might require rebasing our stack of commits, and may not be
> >entirely possible.
> >
> >We're extremely
On Wed, Oct 3, 2018 at 7:53 PM Sergey Bylokhov
wrote:
> Hi, Sean.
> One question related to SecurityManager and performance, is it possible
> to provide a special version of AccessController.doPrivileged which will
> be noop if SecurityManager is not present?
TBH that method (at least, the
On 10/3/18 8:52 PM, Sergey Bylokhov wrote:
Hi, Sean.
One question related to SecurityManager and performance, is it possible
to provide a special version of AccessController.doPrivileged which will
be noop if SecurityManager is not present?
Yes, it may be possible, and we have prototyped it.
On 03/10/2018 21:49, Nico Williams wrote:
:
A lot of these changes are interrelated. Reviewing them in order of
size might require rebasing our stack of commits, and may not be
entirely possible.
We're extremely familiar with this code as we have been patching the
JGSS stack this way for years
