Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hi Sean, Thank you for feedback. I've updated the bug report. 14.09.16 19:57, Sean Mullan wrote: Thanks for the information. It would be very useful if you could add that additional information as an example into the bug report for future reference. --Sean On 09/14/2016 11:26 AM, Sergei

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Thanks for the information. It would be very useful if you could add that additional information as an example into the bug report for future reference. --Sean On 09/14/2016 11:26 AM, Sergei Kovalev wrote: Hi Sean, I'm working for testing minimal JRE image. If I create custom JRE with

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Answered in other thread 14.09.16 18:54, Wang Weijun wrote: Sorry I was thinking about another bug on TLS tests -- 8166032. What exception is thrown there if the jgss module is missing? Thanks Max 在 2016年9月14日，23:44，Wang Weijun > 写道：

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Sorry I was thinking about another bug on TLS tests -- 8166032. What exception is thrown there if the jgss module is missing? Thanks Max > 在 2016年9月14日，23:44，Wang Weijun 写道： > > The example shows jdk.crypto.pkcs11 is needed, but I still don't know why >

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

The example shows jdk.crypto.pkcs11 is needed, but I still don't know why java.security.jgss is. Can you give another example where jgss must be present? Thanks Max > 在 2016年9月14日，23:26，Sergei Kovalev 写道： > > Hi Sean, > > I'm working for testing minimal JRE image.

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hi Sean, I'm working for testing minimal JRE image. If I create custom JRE with java.base only - the tests fail. To emulate such behavior we can use "--limit-modules java.base" option. In case if we have no module declaration in tests header the test fails with, e.g. ClassNotFound exception

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Looks fine to me, but can you explain in more detail why the extra dependencies are needed, or an example using --limit-modules? These tests are not failing regularly now, so when do the missing dependencies cause failures? Thanks, Sean On 09/13/2016 08:34 AM, Sergei Kovalev wrote: Hello

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, This is re-request for review of very small changes. Could somebody take a look? 08.09.16 17:03, Sergei Kovalev wrote: Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev:

RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev: http://cr.openjdk.java.net/~skovalev/8165689/webrev.00/ Goal: make test possible to run with "--limit-modules" flag. Summary: added @modules tag into jtreg header if

RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev: http://cr.openjdk.java.net/~skovalev/8165689/webrev.00/ Goal: make test possible to run with "--limit-modules" flag. Summary: added @modules tag into jtreg header if