Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

On 8/29/16 8:51 PM, David Holmes wrote: On 30/08/2016 9:08 AM, Daniel D. Daugherty wrote: On 8/23/16 6:17 AM, Harsha Wardhana B wrote: Hi David, You approach to waiter object is a neat little abstraction and I will make it a point to use it in future fixes, if required. revised webrev :

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

Thanks Alejandro. A minor correction - the patch is pushed to jdk9/hs/hotspot which is the right repo to fix this issue. I did a grep on jdk9/hs/hotspot/test and find no other test changes using the old CLI options. I have covered the necessary changes in jdk9/dev/hotspot/test in [1]. Mandy

Re: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module

On 30/08/2016 8:39 PM, Amit Sapre wrote: Hello, Fixed the alignment problem as well. Here is the updated webrev. http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/ Can you use the original style for this please. No need to see an updated webrev. Thanks, David Thanks, Amit

RE: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module

Hello, Fixed the alignment problem as well. Here is the updated webrev. http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/ Thanks, Amit -Original Message- From: David Holmes Sent: Tuesday, August 30, 2016 11:44 AM To: Amit Sapre; serviceability-dev Subject: Re: PING

Fwd: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

Hi, Could I, please, have some feedback on the RFR below (adding a new test for the -javaagent option)? Best regards, Alexander - Forwarded Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.net Cc: christian.tornqv...@oracle.com,

Re: RFR:8148103:add more tests for task "Update JDI and JDWP for modules"

Hi Alexander, On 8/30/16 02:56, Alexander Kulyakhtin wrote: Hi Sergey, Thank you very much for the review. I've submitted JDK-8165017 as you have suggested. Ok, thanks! Is it enough to have one review for test enhancements? Also, do you

Re: RFR:8148103:add more tests for task "Update JDI and JDWP for modules"

Hi Sergey, Thank you very much for the review. I've submitted JDK-8165017 as you have suggested. Best regards, Alexander - Original Message - From: serguei.spit...@oracle.com To: alexander.kulyakh...@oracle.com Cc: christian.tornqv...@oracle.com,

Re: RFR: 8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c

Hello, Please find below webrev addressing David's and Dmitry's comments. http://cr.openjdk.java.net/~hb/8161448/webrev.02/ -Harsha On Tuesday 30 August 2016 09:46 AM, David Holmes wrote: On 30/08/2016 2:06 PM, Harsha Wardhana B wrote: Error checking might distract the main flow of code but

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

Please push this to jdk9/dev after Mandy's change is in, to make sure the fix work, and that is there by Thursday when I take the snapshot otherwise there's not guarantee it will be part of the snapshot Thanks Alejandro On 8/30/2016 12:15 AM, Jini Susan George wrote: Thank you, Mandy.

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

> On Aug 29, 2016, at 11:07 PM, David Holmes wrote: > > Hi Mandy, > > On 30/08/2016 3:56 PM, Mandy Chung wrote: >> >>> On Aug 29, 2016, at 12:51 AM, Jini Susan George >>> wrote: >>> >>> Hi David, >>> >>> Thank you for the review. I have

Re: RFR : JDK-8164609 : javax/management/remote/mandatory/notif/DeadListenerTest.java fails with AssertionError

Looks good! Thanks, David On 30/08/2016 3:58 PM, Amit Sapre wrote: Hello, I made changes as David suggested. Here is the new webrev link http://cr.openjdk.java.net/~jgeorge/sponsorships/8164609/webrev.01/ Thanks, Amit -Original Message- From: David Holmes Sent: Monday, August 29,

RE: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

Thank you, Mandy. Aiming at that. -jini. > -Original Message- > From: Mandy Chung > Sent: Tuesday, August 30, 2016 11:27 AM > To: Jini Susan George > Cc: David Holmes; serviceability-dev; Alejandro Murillo > Subject: Re: RFR:(S): 8164562: >

Re: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module

On 30/08/2016 3:56 PM, Amit Sapre wrote: Thanks David for your inputs. I like to go the cleanup way and made changes accordingly. The new webrev is http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.01/ Looks good! Only nit is the argument alignment here: ! default public

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

Hi Mandy, On 30/08/2016 3:56 PM, Mandy Chung wrote: On Aug 29, 2016, at 12:51 AM, Jini Susan George wrote: Hi David, Thank you for the review. I have added a few more asserts and uploaded a modified webrev: http://cr.openjdk.java.net/~jgeorge/8164562/webrev.01/

RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

Hello, Please review this small code change and a new test case to validate the changes. Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/ Thanks, Amit