> On Aug 29, 2016, at 11:07 PM, David Holmes <david.hol...@oracle.com> wrote: > > Hi Mandy, > > On 30/08/2016 3:56 PM, Mandy Chung wrote: >> >>> On Aug 29, 2016, at 12:51 AM, Jini Susan George <jini.geo...@oracle.com> >>> wrote: >>> >>> Hi David, >>> >>> Thank you for the review. I have added a few more asserts and uploaded a >>> modified webrev: >>> >>> http://cr.openjdk.java.net/~jgeorge/8164562/webrev.01/ >> >> Looks okay. It’d be helpful if you can make sure your fix can push to >> jdk9/hs and include in the next hs->dev push. Otherwise these tests without >> your fix will fail in jdk9/dev since the old CLI option will be removed. > > Why wasn't removal deferred until after all test changes were made? There is > no guarantees as to when jdk9/hs will push up next - it depends on the > changes that go in there and the stability of those changes.
If jdk9/hs is sync’ed to jdk9/dev without 8164562, doesn’t this test fail with NPE anyway? When the new CLI options are integrated, all regression tests were updated to use the new CLI options. These 2 tests were changed after JDK-8136930 was pushed and use the old CLI options - that happens. The new CLI options has been integrated over 2+ weeks to give time for transition. We should also ask why these tests are not using the new CLI options. In any case, I file https://bugs.openjdk.java.net/browse/JDK-8164902 that Jini has closed as a dup since his patch is going to resolve it. Mandy [1] http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/1cbffa2beba6
