Thanks, David!
I'll push it under the trivial fix rule.
Thanks,
Serguei
On 8/7/17 18:11, David Holmes wrote:
Seems reasonable. :)
Thanks,
David
On 8/08/2017 8:21 AM, serguei.spit...@oracle.com wrote:
Please, review a two-lines fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-818593
Seems reasonable. :)
Thanks,
David
On 8/08/2017 8:21 AM, serguei.spit...@oracle.com wrote:
Please, review a two-lines fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8185930
The fix is to remove the unneeded dependecies on the jdk.jdi module.
The patch is:
diff -r f2ec523d900b
tes
2017-08-08 7:16 GMT+09:00 serguei.spit...@oracle.com
:
>
>
> On 8/7/17 10:11, serguei.spit...@oracle.com wrote:
>>
>> On 8/7/17 10:05, serguei.spit...@oracle.com wrote:
>>>
>>> Hi Yasumasa,
>>>
>>> It is good.
>>
>>
>> I forgot about the line that is not needed in the test:
>>
>> 29 * @modules j
Please, review a two-lines fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8185930
The fix is to remove the unneeded dependecies on the jdk.jdi
module.
The patch is:
diff -r f2ec523d900b
test/serviceability/jvmti/GetNamedModu
On 8/7/17 10:11, serguei.spit...@oracle.com wrote:
On 8/7/17 10:05, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It is good.
I forgot about the line that is not needed in the test:
29 * @modules jdk.jdi
I will remove it before pushing.
Pushed.
Thanks,
Serguei
Thanks,
Serguei
On 8/7/17 10:05, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It is good.
I forgot about the line that is not needed in the test:
29 * @modules jdk.jdi
I will remove it before pushing.
Thanks,
Serguei
I will sponsor the fix.
If I understand correctly, David is also Ok with the fix.
Hi Yasumasa,
It is good.
I will sponsor the fix.
If I understand correctly, David is also Ok with the fix.
Thanks,
Serguei
On 8/7/17 01:54, Yasumasa Suenaga wrote:
Thanks Serguei, David,
I uploaded webrev which includes @summary update and 4 indent:
http://cr.openjdk.java.net/~ysuenaga/J
On 8/7/17 2:54 AM, Yasumasa Suenaga wrote:
Thanks Serguei, David,
I uploaded webrev which includes @summary update and 4 indent:
http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.05/
make/test/JtregNative.gmk
No comments.
src/share/vm/runtime/objectMonitor.cpp
No comments.
On 04/08/2017 21:02, Jonathan Gibbons wrote:
Please review this fix for some of the docs for the jdk.jdi module.
Most of the changes are relatively straightforward. The biggest change
was to the introductory tables in the Type and Value classes. These
were both conceptually "many tables in o
Thanks Serguei, David,
I uploaded webrev which includes @summary update and 4 indent:
http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.05/
Could you review and be a sponsor for it?
Yasumasa
2017-08-07 17:35 GMT+09:00 serguei.spit...@oracle.com
:
> On 8/6/17 21:50, David Holmes wro
On 8/6/17 17:42, Daniel D. Daugherty wrote:
Solaris X64 test results with the fix look good. Here's what I ran:
- internal VM/NSK JVM/TI, JDWP and JDI tests
- JTREG jdk/test/:jdk_svc, hotspot/test/:hotspot_jprt
hotspot/test/:hotspot_runtime_tier2,
hotspot/test/:hotspot_runtime_tier3
I've ru
On 8/6/17 21:50, David Holmes wrote:
Hi Yasumasa,
On 7/08/2017 2:02 PM, Yasumasa Suenaga wrote:
Hi David,
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.04/
. . .
Style query: do we do indent of 2 or 4 in hotspot C code tests ?
Fixed in C code.
I was
Hi Yasumasa,
This is helpful, but looks like 'locked' is printed even when a thread
is waiting for the monitor entry, or has unlocked a lock. For a simple
test program, we would have:
"Thread-1" #11 prio=5 tid=0x7f393845 nid=0x6be4 waiting for
monitor entry [0x7f391501]
j
13 matches
Mail list logo