Re: RFR [XS] Subclasses of jdk.jfr.Event loaded from CDS breaks -XX:FlightRecorderOptions=retransform=false

2017-10-26 Thread serguei.spit...@oracle.com
Hi Ioi, It looks good modulo the comment from Jiangli. Thanks, Serguei On 10/26/17 16:26, Ioi Lam wrote: Please review the follow change:     https://bugs.openjdk.java.net/browse/JDK-8190191 http://cr.openjdk.java.net/~iklam/jdk10/8190191-jfr-event-retransform-false.v01.open/ Background:

Re: [PATCH] Unnecessary Amount Of Internal Class Conversion

2017-10-26 Thread serguei.spit...@oracle.com
Hi Ben, The fix looks good, I see no problems. Thank you for taking care about this! I'll sponsor it. A couple of copyright comments need an update but I can fix it myself. Do I understand it right that you have no OpenJDK status yet? At least one more review is required for push. Thanks, Serg

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-26 Thread Harsha Wardhana B
Sorry. Missed the webrev - http://cr.openjdk.java.net/~hb/5016517/webrev.05/ On Friday 27 October 2017 09:27 AM, Harsha Wardhana B wrote: Hi, Below is the updated webrev incorporating review comments from Daniel, Roger and Mandy. The password file will now be locked before writing. Mandy,

Re: RFE Review : JDK-5016517 - Replace plaintext passwords by hashed passwords for out-of-the-box JMX Agent

2017-10-26 Thread Harsha Wardhana B
Hi, Below is the updated webrev incorporating review comments from Daniel, Roger and Mandy. The password file will now be locked before writing. Mandy, 49 # https://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#MessageDigest 50 # MD5, SHA-1 and SHA-256 are suppo

Re: RFR [XS] Subclasses of jdk.jfr.Event loaded from CDS breaks -XX:FlightRecorderOptions=retransform=false

2017-10-26 Thread Jiangli Zhou
Hi Ioi, SystemDictionary::reorder_dictionary_for_sharing() and Dictionary::reorder_dictionary_for_sharing() are only used for CDS code. Could you please add CDS_ONLY() to the function definitions and put the implementation under #if INCLUDE_CDS. Thanks, Jiangli > On Oct 26, 2017, at 4:26 PM,

Re: RFR [S] Subclasses of jdk.jfr.Event loaded from CDS breaks -XX:FlightRecorderOptions=retransform=false (closed repo)

2017-10-26 Thread Ioi Lam
Hi, Here are the closed test cases: http://ioilinux.us.oracle.com/webrev/jdk10/8190191-jfr-event-retransform-false.v01.closed/ Thanks - Ioi On 10/26/17 4:26 PM, Ioi Lam wrote: Please review the follow change:     https://bugs.openjdk.java.net/browse/JDK-8190191 http://cr.openjdk.java.net/~i

RFR [XS] Subclasses of jdk.jfr.Event loaded from CDS breaks -XX:FlightRecorderOptions=retransform=false

2017-10-26 Thread Ioi Lam
Please review the follow change:     https://bugs.openjdk.java.net/browse/JDK-8190191 http://cr.openjdk.java.net/~iklam/jdk10/8190191-jfr-event-retransform-false.v01.open/ Background: When -XX:FlightRecorderOptions=retransform=false is given in the command-line, subclasses of jdk.jfr.Event are

Re: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

2017-10-26 Thread Erik Gahlin
Looks good. Erik Hi all, Please review the following changes which add a new field to the BiasedLockRevocation event, previousOwner, containing information on which thread (if any) owned the bias before it was revoked. Issue: https://bugs.openjdk.java.net/browse/JDK-8189368 Webrev: http://c

Re: RFR : JDK-8044122 MBean access to the PID

2017-10-26 Thread Ujwal Vangapally
Hi Roger, made changes as suggested. webrev : http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.03/ Thanks, Ujwal. On 10/26/2017 6:54 PM, Roger Riggs wrote: Hi Ujwal, In RuntimeMXBean: Please add @throws UnsupportedOperationException if the process id is not available

Re: RFR : JDK-8044122 MBean access to the PID

2017-10-26 Thread mandy chung
On 10/26/17 1:53 AM, Bernd Eckenfels wrote: Hello, Yes the frames must have the security granted, isnt that the whole purpose of a security permission check? With the current state of the patch unprivileged application code can read the PID. If this is intentional I would simply remove the

Re: RFR : JDK-8044122 MBean access to the PID

2017-10-26 Thread Roger Riggs
Hi Ujwal, In RuntimeMXBean: Please add @throws UnsupportedOperationException if the process id is not available Otherwise, looks fine. Thanks, Roger On 10/26/2017 4:29 AM, Ujwal Vangapally wrote: Thanks for the review Mandy, Roger, Harsha, Christoph. kindly see the new webrev incorporat

Re: RFR : JDK-8044122 MBean access to the PID

2017-10-26 Thread Bernd Eckenfels
Hello, Yes the frames must have the security granted, isnt that the whole purpose of a security permission check? With the current state of the patch unprivileged application code can read the PID. If this is intentional I would simply remove the access check completely instead. Gruss Bernd -

Re: RFR : JDK-8044122 MBean access to the PID

2017-10-26 Thread Ujwal Vangapally
Thanks for the review Mandy, Roger, Harsha, Christoph. kindly see the new webrev incorporating review comments. webrev: http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.02/ csr : https://bugs.openjdk.java.net/browse/JDK-8189091 Ujwal. On 10/24/2017 10:50 PM, mandy chung w