Re: RFR JDK-8198253: ThreadInfo.from(CompositeData) assigning fields incorrectly in JDK 9

Webrev at: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8198253/webrev.01 This patch updates the spec to clarify what attributes are required since which release. There is a spec bug that "classLoaderName" added in JDK 9 is missing in the CompositeData for StackTraceElement but the impleme

Re: Thread Native ID Access

Here’s a concrete proposal on which people may want to comment. We could add a method to ThreadInfo, vis., long getPlatformThreadId() Returns the platform-specific thread ID of the thread associated with this ThreadInfo. The ID has no meaning to the Java runtime and is not guaranteed to have a

Re: RFR(XS): 8198585: add asserts to verify that ServiceUtil::visible_oop is not needed

Ok. I'll make that change. thanks, Chris On 2/23/18 6:45 AM, Daniel D. Daugherty wrote: Instead of "assert(false, ...", I recommend "fatal(...". This will cause a failure in all build configs including 'release' bits. Dan On 2/22/18 8:16 PM, Chris Plummer wrote: Hello, Please review the f

Re: RFR(XS): 8198585: add asserts to verify that ServiceUtil::visible_oop is not needed

Instead of "assert(false, ...", I recommend "fatal(...". This will cause a failure in all build configs including 'release' bits. Dan On 2/22/18 8:16 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8198585 http://cr.openjdk.java.net/~cjpl

Re: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

On 2018-02-23 02:03, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8196992 diff --git a/make/lib/Lib-jdk.jdwp.agent.gmk b/make/lib/Lib-jdk.jdwp.agent.gmk --- a/make/lib/Lib-jdk.jdwp.agent.gmk +++ b/make/lib/Lib-jdk.jdwp.agent.gmk @@ -43,7

Re: Thread Native ID Access

On 23/02/2018 05:04, John Rose wrote: We may or may not bind fiber identity to the legacy java.lang.Thread type. This affects the question of whether the following code can return false: boolean testThreadShift(Runnable r) {   Thread t0 = Thread.current();   r.run();   Thread t1 = Thread.current

Re: RFR(XS): 8198585: add asserts to verify that ServiceUtil::visible_oop is not needed

Hi Chris, +1 Thanks, Serguei On 2/23/18 01:58, Stefan Karlsson wrote: Looks good. StefanK On 2018-02-23 02:16, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8198585 http://cr.openjdk.java.net/~cjplummer/8198585/webrev.00/webrev/ Before

Re: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

Chris, This looks good to me too. Thanks, Serguei On 2/23/18 00:48, Langer, Christoph wrote: Looks good, Chris. -Original Message- From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of Chris Plummer Sent: Freitag, 23. Februar 2018 02:04 To: build-...@openjdk.java.

Re: RFR(XS): 8198585: add asserts to verify that ServiceUtil::visible_oop is not needed

Looks good. StefanK On 2018-02-23 02:16, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8198585 http://cr.openjdk.java.net/~cjplummer/8198585/webrev.00/webrev/ Before removing ServiceUtil::visible_oop(), I want to make sure it really isn't

RE: RFR (XS): 8198539: Cleanup of unused imports in java/util/jar/Attributes.java (java.base) and JdpController.java (jdk.management.agent)

Thanks, Thomas. From: Thomas Stüfe [mailto:thomas.stu...@gmail.com] Sent: Donnerstag, 22. Februar 2018 09:54 To: Langer, Christoph Cc: Java Core Libs ; serviceability-dev@openjdk.java.net; andrew_m_leon...@uk.ibm.com Subject: Re: RFR (XS): 8198539: Cleanup of unused imports in java/util/jar/Att

RE: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

Looks good, Chris. > -Original Message- > From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of > Chris Plummer > Sent: Freitag, 23. Februar 2018 02:04 > To: build-...@openjdk.java.net build-dev ; > serviceability-dev > Subject: RFR(S): 8196992: Resolve disabled warning