Hi Jc,
The fix looks great as it looks much more simple now!
One minor suggestion about this file update:
http://cr.openjdk.java.net/%7Ejcbeyler/8210182/webrev.02/test/hotspot/jtreg/vmTestbase/nsk/share/jpda/libNativeMethodsTestThread.cpp.udiff.html
Hi Alex,
It looks good in general but not sure I understand all the
changes.
Could you, please, tell a little bit more about the refactoring in
the Jdb.java and JdbTest.java?
I understand that you moved some code from Jdb.java to
JdbTest.java.
Agreed.
It looks like the root cause of the extra newlines.
--alex
On 08/29/2018 18:55, Chris Plummer wrote:
I just stumbled across the following in Jdb.java. I think it might be
the source of the extra newlines on windows:
public static final String lineSeparator =
System.getProperty("
Thank you Alex, Serguei, Gary, and JC for the reviews.
Chris
On 8/30/18 10:33 AM, Alex Menkov wrote:
Looks good.
--alex
On 08/29/2018 21:19, Chris Plummer wrote:
Hi,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8210118
http://cr.openjdk.java.net/~cjplummer/8210118/
+1
--alex
On 08/30/2018 15:43, serguei.spit...@oracle.com wrote:
Hi Daniil,
Thank you a lot for this extra update and cleanup!
I feels that it has a real value in improving the tests reliability.
Some minor comments:
http://cr.openjdk.java.net/~dtitov/8209585/webrev.03/test/hotspot/jtreg/vmT
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8210243
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step3/webrev.01/
The fix converts the following tests:
- test/jdk/com/sun/jdi/JdbArgTest.sh
- test/jdk/com/sun/jdi/JdbLockTest.sh
- test/jdk/com/sun/jdi/JdbMissSte
Hi Alex,
It looks good.
Nice testing framework allows to convert some tests relatively easy!
Thanks,
Serguei
On 8/30/18 15:13, Alex Menkov wrote:
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8067354
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/GetLocalVaria
Looks good to me Alex. With the various refactoring that you've done, this
is getting really easy to read and understand what is actually being tested
:)
Jc
On Thu, Aug 30, 2018 at 3:13 PM Alex Menkov
wrote:
> Hi all,
>
> Please review a fix for
> https://bugs.openjdk.java.net/browse/JDK-8067354
Hi Daniil,
Thank you a lot for this extra update and cleanup!
I feels that it has a real value in improving the tests
reliability.
Some minor comments:
http://cr.openjdk.java.net/~dtitov/8209585/webrev.03/test/hotspot/jtreg/vmTestbase/nsk/jvmt
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8067354
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/GetLocalVariables4/webrev.01/
I was not able to reproduce original issue on Windows, but got a number
of solaris-sparcv9 failures with timeouts.
The fix converts
Hi Serguei,
Please review a new version of the webrev that has the suggested changes
applied for two tests:
test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP02/sp02t001/TestDescription.java
and
test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t001/TestDescription.
I found os::file_separator() that can be used in an absolute
pathname check. There is an isAbsolute function in the
libinstrument native code, but the code we're modifying
is in libjvm.
Here's a quick prototype of an absolute path check...
diff --git a/src/hotspot/share/services/diagnosticComman
Adding hotspot-runtime-dev@... to this thread...
More below...
On 8/28/18 3:37 PM, mandy chung wrote:
On 8/24/18 7:06 AM, Daniel Fuchs wrote:
Hi Harsha,
On 23/08/2018 17:35, Daniel Fuchs wrote:
So all in all - maybe this is worth fixing but better early
in the release than late. I also wo
Hi Jc,
It looks much better now.
BTW did you run all the tests?
test/hotspot/jtreg/vmTestbase/nsk/share/jni/JNIreferences.cpp
"(V" should be "()V":
// notify another thread that JNI local reference has been created
-JNI_ENV_PTR(env)->CallVoidMethod(JNI_ENV_ARG_3(env,
createWi
Looks good.
--alex
On 08/29/2018 21:19, Chris Plummer wrote:
Hi,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8210118
http://cr.openjdk.java.net/~cjplummer/8210118/webrev.00/
There have a been a few jdb bugs (or test bugs) that have caused tests
to fail because they
Looks OK to me.
The extra diagnostic output will be useful to have.
On 8/30/18, 11:08 AM, Gary Adams wrote:
Hi Chris,
It looks good.
Thanks,
Serguei
On 8/29/18 21:19, Chris Plummer wrote:
>/ Hi,
/>/
/>/ Please review the following:
/>/
/>/ https://bugs.openjdk.java.net/browse/JDK-8210118
Filed:
https://bugs.openjdk.java.net/browse/JDK-8210224
for additional cleanup of the resume tests and better
use of the test library for shared code.
On 8/29/18, 4:16 PM, serguei.spit...@oracle.com wrote:
On 8/29/18 07:46, Gary Adams wrote:
Since the vmTestbase/nsk tests are in need of
ref
17 matches
Mail list logo
