Could you move this code:
// Mark dependent AOT nmethods, which are only found via the class
redefined.
AOTLoader::mark_evol_dependent_methods(ik);
into this function:
CodeCache::mark_for_evol_deoptimization(ik)
The rest looks good.
dl
On 2/4/19 7:08 AM, coleen.phillim...@or
Thanks Jini!
Yasumasa
2019年2月5日(火) 14:18 Jini George :
>
> Looks ok to me. Thanks!
>
> -Jini.
>
> On 2/5/2019 10:25 AM, Yasumasa Suenaga wrote:
> > Hi Jini,
> >
> > Thank you for your comment!
> > I uploaded new webrev. Could you review again?
> >
> >http://cr.openjdk.java.net/~ysuenaga/JDK-8
Looks ok to me. Thanks!
-Jini.
On 2/5/2019 10:25 AM, Yasumasa Suenaga wrote:
Hi Jini,
Thank you for your comment!
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.01/
Diff from previous webrev is here:
http://hg.openjdk.java.net/jd
Hi Jini,
Thank you for your comment!
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.01/
Diff from previous webrev is here:
http://hg.openjdk.java.net/jdk/submit/rev/6e603980ab28
Yasumasa
2019年2月5日(火) 12:01 Jini George :
>
> Hi Yasum
Thanks Serguei!
Coleen
On 2/4/19 9:32 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
On 2/4/19 18:26, coleen.phillim...@oracle.com wrote:
On 2/4/19 5:30 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update
Hi Yasumasa,
Thanks a bunch for this welcome change. Looks good to me overall -- a
few points though.
1. Nit: alignment:
180 // See JVMFlag::print_origin() in HotSpot
2. In test/hotspot/jtreg/serviceability/sa/ClhsdbFlags.java,
156 expStrMap.put("flags",
157
Thanks Serguei!
Yasumasa
2019年2月5日(火) 11:40 serguei.spit...@oracle.com :
>
> Hi Yasumasa,
>
> The fix looks good to me.
>
> Thanks,
> Serguei
>
>
> On 2/4/19 04:30, Yasumasa Suenaga wrote:
> > PING: Could you review it?
> >
> >>>JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
> >>>w
Hi Yasumasa,
The fix looks good to me.
Thanks,
Serguei
On 2/4/19 04:30, Yasumasa Suenaga wrote:
PING: Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.00/
Thanks,
Yasumasa
On 2019/01/28 9:3
Hi Coleen,
On 2/4/19 18:26, coleen.phillim...@oracle.com wrote:
On 2/4/19 5:30 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments
On 2/4/19 6:05 PM, David Holmes wrote:
On 5/02/2019 8:30 am, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update the copyright years before the push.
http://cr.openjdk.java.net/~coleenp/2019/8139551.01/webrev/tes
Thank you very much, David.
- Jini.
On 2/5/2019 6:40 AM, David Holmes wrote:
Hi Jini,
This looks fine to me - Reviewed.
Thanks,
David
On 4/02/2019 11:39 pm, Jini George wrote:
Pinging again -- requesting for a Reviewer to take a look.
The patch has been rebased again to include the changes
On 2/4/19 5:30 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update the copyright years before the push.
Hi Serguei, Thanks for reviewing this.
Yes, I update the copyright years in my commit script.
http://
Thank you very much, Serguei.
- Jini.
On 2/5/2019 7:45 AM, serguei.spit...@oracle.com wrote:
Hi Jini,
It looks good to me.
Thanks,
Serguei
On 2/4/19 05:39, Jini George wrote:
Pinging again -- requesting for a Reviewer to take a look.
The patch has been rebased again to include the changes
Hi Jini,
It looks good to me.
Thanks,
Serguei
On 2/4/19 05:39, Jini George wrote:
Pinging again -- requesting for a Reviewer to take a look.
The patch has been rebased again to include the changes of JDK-8217473
to rethrow SkippedException for the tests refactored to use
ClhsdbLauncher.
Hi Jc,
On 5/02/2019 3:47 am, Jean Christophe Beyler wrote:
Hi Jini,
The webrev looks good to me but I was wondering why you are changing the
tests really. For example:
http://cr.openjdk.java.net/~jgeorge/8217473/webrev.01/test/hotspot/jtreg/serviceability/sa/ClhsdbAttach.java.html
The main m
Hi Jini,
This looks fine to me - Reviewed.
Thanks,
David
On 4/02/2019 11:39 pm, Jini George wrote:
Pinging again -- requesting for a Reviewer to take a look.
The patch has been rebased again to include the changes of JDK-8217473
to rethrow SkippedException for the tests refactored to use Clh
Hi Gary,
On 5/02/2019 12:01 am, Gary Adams wrote:
Two of the redefine classes tests (021, 023) have been on the
ProblemList since they
were first brought into the open repos. Both tests made an incorrect
assumption
about the access modifiers in class files. There is a single bit in the
binary
On 2/4/19 15:05, David Holmes wrote:
On 5/02/2019 8:30 am, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update the copyright years before the push.
http://cr.openjdk.java.net/~coleenp/2019/8139551.01/webrev/test/hot
On 5/02/2019 8:30 am, serguei.spit...@oracle.com wrote:
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update the copyright years before the push.
http://cr.openjdk.java.net/~coleenp/2019/8139551.01/webrev/test/hotspot/jtreg/runtime/RedefineTests/TestM
Hi Coleen,
Looks good in general.
Just a couple minor comments below.
I hope, you will update the copyright years before the push.
http://cr.openjdk.java.net/~coleenp/2019/8139551.01/webrev/test/hotspot/jtreg/runtime/RedefineTests/Test
Hi Daniil,
Thank you for the update!
It looks good in general.
I think, it can be a good idea to add a simple tests for this
command-line processing.
It should save us from any surprises.
Thanks,
Serguei
On 2/4/19 13:24, Daniil Titov wrote:
Hi Serguei,
Thank you for reviewing this fix.
Hi Serguei,
Thank you for reviewing this fix.
Please review a new version of the fix that includes all changes you suggested
but one about lines 88-91 and 97-101.
88 if (parts[i].equals("-p") || parts[i].equals("--module-path"))
{
89 i++;
90 c
Added the serviceability-dev back.
Thanks,
Serguei
On 2/4/19 07:18, coleen.phillim...@oracle.com wrote:
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8139551.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8139551
The links.
Thanks,
Coleen
On 2/4/19 10:08 AM, coleen.ph
Hi Andrew
> Please tell me which code it is that jumps to
the native code.
SharedRuntime::generate_native_wrapper. The SP here is saved in the thread
state by set_last_Java_frame.
Nick
From: Andrew Haley
Sent: 05 February 2019 02:25:34
To: Nick Gasson (Arm Tech
Hi Gary,
Looks good to me.
Thank you for the update!
Thanks,
Serguei
On 2/4/19 06:01, Gary Adams wrote:
Two of the redefine classes tests (021, 023) have been on the
ProblemList since they
were first brought into the open repos. Both tests made an incorrect
assumption
about the access modifi
On 2/1/19 9:22 AM, Nick Gasson (Arm Technology China) wrote:
> It takes the last-known Java SP and FP, and tries to find the PC
> following the BL instruction that jumped to the native code. At the
> moment it assumes this is at SP[-1]:
That's where it should be. Please tell me which code it is
Hi Gary,
The webrev looks good to me (I don't like the general way the tests are
written with "i" as a test iterator but that's a different conversation ;-))
Thanks,
Jc
On Mon, Feb 4, 2019 at 6:03 AM Gary Adams wrote:
> Two of the redefine classes tests (021, 023) have been on the
> ProblemLis
On 2/3/19 3:01 AM, Nick Gasson (Arm Technology China) wrote:
> I think this is much better, thanks. But we still have the problem
> that the two-argument AARCH64Frame constructor is wrong: I don't
> think it's ever correct to assume the PC is at SP[-1].
Really? We push it there when we make runti
Summary: Walk code cache and deoptimize once per redefinition.*
*This change touches the AOT and code cache code. I tried to describe
it in the comments in the RFE. Basically, for redefinition, we walk the
code cache per class redefined in order to find evol_method
dependencies, then deoptim
Two of the redefine classes tests (021, 023) have been on the
ProblemList since they
were first brought into the open repos. Both tests made an incorrect
assumption
about the access modifiers in class files. There is a single bit in the
binary class file that
defines if an interface is public or
Pinging again -- requesting for a Reviewer to take a look.
The patch has been rebased again to include the changes of JDK-8217473
to rethrow SkippedException for the tests refactored to use ClhsdbLauncher.
webrev:
http://cr.openjdk.java.net/~jgeorge/8215568/webrev.04/index.html
Thanks,
Jini.
PING: Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.00/
Thanks,
Yasumasa
On 2019/01/28 9:35, Yasumasa Suenaga wrote:
Hi all,
This change has passed tests as below (all of jhsdb related test
Hi Lin,
Sorry but can I just confirm that you have signed the OCA [1]? I don't
see you listed individually and I can't tell what company you work for
or whether your are contributing on their behalf.
Thanks,
David
[1] http://www.oracle.com/technetwork/oca-405177.pdf
On 31/01/2019 4:42 pm, 臧
33 matches
Mail list logo
