thanks David, pushed.
-- Igor
> On Apr 27, 2020, at 11:17 PM, David Holmes wrote:
>
> Looks good.
>
> Thanks,
> David
>
> On 28/04/2020 4:13 pm, Igor Ignatyev wrote:
>> Hi all,
>> could you please review yet another follow up fix/revert for 8243928?
>> patch:
>>> diff -r 566418d35593
>>> tes
Looks good.
Thanks,
David
On 28/04/2020 4:13 pm, Igor Ignatyev wrote:
Hi all,
could you please review yet another follow up fix/revert for 8243928?
patch:
diff -r 566418d35593
test/hotspot/jtreg/serviceability/logging/TestQuotedLogOutputs.java
--- a/test/hotspot/jtreg/serviceability/loggin
Hi all,
could you please review yet another follow up fix/revert for 8243928?
patch:
> diff -r 566418d35593
> test/hotspot/jtreg/serviceability/logging/TestQuotedLogOutputs.java
> --- a/test/hotspot/jtreg/serviceability/logging/TestQuotedLogOutputs.java
> Mon Apr 27 22:24:54 2020 -0700
Hi Stefan,
>> - Adding Atomic::load/store.
>> - Removing the time measurement in the run_task. I renamed G1's function
>> to run_task_timed. If we need this outside of G1, we can rethink the API
>> at that point.
>> - ZGC style cleanups
Thanks for revising the patch, they are
thanks, i'll push it as soon as I get full test results (assuming there are no
new failures).
-- Igor
> On Apr 27, 2020, at 10:21 PM, serguei.spit...@oracle.com wrote:
>
> This update looks good too.
>
> Thanks,
> Serguei
>
>
> On 4/27/20 22:12, Igor Ignatyev wrote:
>> Thanks Mikael,
>>
>>
This update looks good too.
Thanks,
Serguei
On 4/27/20 22:12, Igor Ignatyev wrote:
Thanks Mikael,
there is, thought, one more test failing after 8243928 --
serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the
fix is pretty much the same revert part of 8243928:
di
Hi Serguei,
thanks for review, no I haven't yet as I found another problem w/ 8243928.
-- Igor
> On Apr 27, 2020, at 10:14 PM, serguei.spit...@oracle.com wrote:
>
> Hi Igor,
>
> Looks good but you have already pushed. :)
>
> Thanks,
> Serguei
>
>
> On 4/27/20 22:10, Mikael Vidstedt wrote:
Hi Igor,
Looks good but you have already pushed. :)
Thanks,
Serguei
On 4/27/20 22:10, Mikael Vidstedt wrote:
Looks good, thanks for the quick turnaround!
Cheers,
Mikael
On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00
2 lines ch
Thanks Mikael,
there is, thought, one more test failing after 8243928 --
serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the
fix is pretty much the same revert part of 8243928:
> diff -r 67cbcf4f
> test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/C
Looks good and trivial.
Thanks,
David
On 28/04/2020 3:02 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00
2 lines changed: 0 ins; 0 del; 2 mod;
Hi all,
(so now it's my time to apology for inconvenience)
could you please review this small follow-up fix/parti
Looks good, thanks for the quick turnaround!
Cheers,
Mikael
> On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00
>> 2 lines changed: 0 ins; 0 del; 2 mod;
>
> Hi all,
>
> (so now it's my time to apology for inconvenience)
>
> coul
http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00
> 2 lines changed: 0 ins; 0 del; 2 mod;
Hi all,
(so now it's my time to apology for inconvenience)
could you please review this small follow-up fix/partial revert of 8243928[1]?
serviceability/sa/TestCpoolForInvokeDynamic.java and TestDe
Pushed.
Sorry for the inconvenience.
Thanks,
Serguei
On 4/27/20 20:55, Igor Ignatyev wrote:
sure,
and thank you, Serguei, for handling this so promptly!
-- Igor
sure, and thank you, Serguei, for handling this so promptly!
-- Igor
> On Apr 27, 2020, at 8:54 PM, serguei.spit...@oracle.com wrote:
>
> Thanks, Igor!
> Will push it after build-tier1 job is completed.
>
> Thanks,
> Serguei
>
> On 4/27/20 20:53, Igor Ignatyev wrote:
>> Hi Serguei,
>>
>> LGTM
Thanks, Igor!
Will push it after build-tier1 job is completed.
Thanks,
Serguei
On 4/27/20 20:53, Igor Ignatyev wrote:
Hi
Serguei,
LGTM,
-- Igor
On Apr 27, 2020, at
Please, review small patch to fix the build
regression caused by fix of 8242237.
Patch:
diff --git
a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
b/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.c
Hi Serguei,
LGTM,
-- Igor
> On Apr 27, 2020, at 8:52 PM, serguei.spit...@oracle.com wrote:
>
> Please, review small patch to fix the build regression caused by fix of
> 8242237.
>
> Patch:
>
> diff --git
> a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
>
>
Thanks Alex, pushed.
-- Igor
> On Apr 27, 2020, at 7:36 PM, Alex Menkov wrote:
>
> Hi Igor,
>
> LGTM
>
> --alex
>
> On 04/27/2020 16:51, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8243928/webrev.00
>>> 16 lines changed: 4 ins; 0 del; 12 mod;
>> Hi all,
>> could you please
Hi Igor,
LGTM
--alex
On 04/27/2020 16:51, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243928/webrev.00
16 lines changed: 4 ins; 0 del; 12 mod;
Hi all,
could you please review the trivial patch which updates 15 svc tests to use a
driver mode?
from JBS:
the "main" classes
Hi Chris,
The fix looks good.
--alex
On 04/27/2020 12:17, Chris Plummer wrote:
Ping! Please help review if you can.
thanks,
Chris
On 4/24/20 12:44 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8243500
http://cr.openjdk.java.net/~cjp
Hi Leonid,
Updated webrev version with the suggested refactoring is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-events.5/
Hi Chris,
great analysis.
LGTM++
--alex
On 04/27/2020 14:52, serguei.spit...@oracle.com wrote:
Hi Chris,
The fix looks reasonable.
Thanks,
Serguei
On 4/27/20 12:16, Chris Plummer wrote:
Ping! Please help review if you can. There's also an RFR out for
8243500, which is related.
thanks,
updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/LingeredApp_improve/webrev.2/
Moved getStdoutAsList to OutputBuffer.
--alex
On 04/24/2020 20:38, Chris Plummer wrote:
On 4/24/20 6:52 PM, Alex Menkov wrote:
Hi Chris,
On 04/24/2020 15:42, Chris Plummer wrote:
Hi Alex,
Overall it loo
http://cr.openjdk.java.net/~iignatyev//8243929/webrev.00
> 7 lines changed: 1 ins; 6 del; 0 mod;
Hi all,
could you please review this trivial patch which updates
AttachWithStalePidFile.java test to use @requires?
from JBS:
> serviceability/attach/AttachWithStalePidFile.java test can be run on wi
http://cr.openjdk.java.net/~iignatyev//8243928/webrev.00
> 16 lines changed: 4 ins; 0 del; 12 mod;
Hi all,
could you please review the trivial patch which updates 15 svc tests to use a
driver mode?
from JBS:
> the "main" classes of the tests listed below fork new JVMs and check their
> output
Hi Chris,
The fix looks reasonable.
Thanks,
Serguei
On 4/27/20 12:16, Chris Plummer wrote:
Ping!
Please help review if you can. There's also an RFR out for
8243500, which is related.
thanks,
Thanks a lot, Alex!
Serguei
On 4/27/20 14:24, Alex Menkov wrote:
Hi Serguei,
LGTM++
--alex
On 04/24/2020 15:20, serguei.spit...@oracle.com wrote:
Hi Leonid,
Thank you for review and suggestion.
Will fix it.
Thanks,
Serguei
On 4/24/20 15:11, Leonid Mesnik wrote:
Looks good.
The small n
Hi Serguei,
LGTM++
--alex
On 04/24/2020 15:20, serguei.spit...@oracle.com wrote:
Hi Leonid,
Thank you for review and suggestion.
Will fix it.
Thanks,
Serguei
On 4/24/20 15:11, Leonid Mesnik wrote:
Looks good.
The small nit (optional). New function
287 static void JNICALL
288 ClassPre
Hi Daniil,
Overall it looks good. A few comments below.
Can you add a comment to TestSysProps.java indicating the reason for
checking if the line starts with "[".
In JDKToolLauncher you have an extra empty line:
112 * Any platform specific arguments required for running the
tool are
Thank you, Chris and Serguei, for reviewing this change.
I will fix typos before pushing in the repository.
Best regards,
Daniil
On 4/27/20, 12:12 PM, "Chris Plummer" wrote:
Hi Daniil,
83 // names2, and names3 will have different size. Repeat
the test in this case
Ping! Please help review if you can.
thanks,
Chris
On 4/24/20 12:44 AM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8243500
http://cr.openjdk.java.net/~cjplummer/8243500/webrev.00/index.html
A couple years ago JDK-8214226 fixed an issue
Ping! Please help review if you can. There's also an RFR out for
8243500, which is related.
thanks,
Chris
Forwarded Message
Subject:
RFR(S) 8231634: SA stack walking fails w
Hi Daniil,
83 // names2, and names3 will have different size. Repeat
the test in this case.
Should be "sizes". There are a few instances of this in the comments
that need to be changed.
Looks good otherwise. I don't need to see another webrev.
thanks,
Chris
On 4/25/20 9:11
Please review the change [1] that ensures that VM and test options are
forwarded to
j*-tools when they are launched from serviceability/sa tests.
The tests that expect an empty output were corrected to ignore the product
version printed
in the error stream since in some tiers the tests are ru
Looks good.
StefanK
On 2020-04-25 00:30, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
8 lines changed: 0 ins; 6 del; 2 mod;
Hi all,
could you please review this small and trivial patch which updates
serviceability/logging/TestLogRotation.java test to pass bo
Hi David,
> Not a review but some general commentary ...
That's welcome.
> On 25/04/2020 2:08 am, Reingruber, Richard wrote:
> > Hi Yasumasa, Patricio,
> >
> I will send review request to replace VM_SetFramePop to handshake in
> early next week in JDK-8242427.
> Does it help you
Hi all,
Not a review but some general commentary ...
On 25/04/2020 2:08 am, Reingruber, Richard wrote:
Hi Yasumasa, Patricio,
I will send review request to replace VM_SetFramePop to handshake in early next
week in JDK-8242427.
Does it help you? I think it gives you to remove workaround.
I
Hi Lin,
On 2020-04-26 05:10, linzang(臧琳) wrote:
Hi Stefan and Paul，
I have made a new patch based on your comments and Stefan's Poc code:
Webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_03/
Delta(based on Stefan's change:) :
http://cr.openjdk.java.net/~lzang
38 matches
Mail list logo
