Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

2020-12-17 Thread Yasumasa Suenaga
On Tue, 1 Dec 2020 01:43:15 GMT, Chris Plummer wrote: >>> * Q1: Is it necessary to call the Agent_OnUnload()? >> >> [JVMTI spec of >> Agent_OnUnload()](https://docs.oracle.com/en/java/javase/15/docs/specs/jvmti.html#onunload) >> says this function will be called when the agent library will be

Integrated: 8258471: "search codecache" clhsdb command does not work

2020-12-17 Thread Yasumasa Suenaga
On Wed, 16 Dec 2020 10:27:05 GMT, Yasumasa Suenaga wrote: > `search codecache` command does not work as following: > > hsdb> search codecache 0x7fedbd0aec90 > java.lang.RuntimeException: Unable to deduce type of CodeBlob from address > 0x7fedbc85e810 (expected type nmethod, RuntimeStub,

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition [v3]

2020-12-17 Thread Leonid Mesnik
> The error code during class redefinition might be not enough to easily > diagnose the problem. Some more logging might be useful to understand it. I > encountered this problem when redefined methods with lambda usage. > I run all existing tests with enabled logging and sanity verified error >

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

2020-12-17 Thread David Holmes
On 16/12/2020 5:36 pm, Yasumasa Suenaga wrote: Hi David, I'm not sure you mean exactly by DLL unloading mechanism is not hooked. I want to say we do not hook `FreeLibrary()` on Windows and `dlclose()` on Linux. Can we describe ""this function may be called - " at here? I think it is

Re: RFR: 8258471: "search codecache" clhsdb command does not work

2020-12-17 Thread Serguei Spitsyn
On Wed, 16 Dec 2020 10:27:05 GMT, Yasumasa Suenaga wrote: > `search codecache` command does not work as following: > > hsdb> search codecache 0x7fedbd0aec90 > java.lang.RuntimeException: Unable to deduce type of CodeBlob from address > 0x7fedbc85e810 (expected type nmethod, RuntimeStub,

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition [v2]

2020-12-17 Thread Serguei Spitsyn
On Thu, 17 Dec 2020 22:54:13 GMT, Leonid Mesnik wrote: >> The error code during class redefinition might be not enough to easily >> diagnose the problem. Some more logging might be useful to understand it. I >> encountered this problem when redefined methods with lambda usage. >> I run all

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition [v2]

2020-12-17 Thread Coleen Phillimore
On Thu, 17 Dec 2020 22:54:13 GMT, Leonid Mesnik wrote: >> The error code during class redefinition might be not enough to easily >> diagnose the problem. Some more logging might be useful to understand it. I >> encountered this problem when redefined methods with lambda usage. >> I run all

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition [v2]

2020-12-17 Thread Leonid Mesnik
On Thu, 17 Dec 2020 18:46:14 GMT, Coleen Phillimore wrote: >> I've made them log_trace to be consistent with already existing logging >> introduced for nestmates related errors. Do you want to make all of them >> log_info in such case? > > I see. I think so, yes. Since you're returning an

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition [v2]

2020-12-17 Thread Leonid Mesnik
> The error code during class redefinition might be not enough to easily > diagnose the problem. Some more logging might be useful to understand it. I > encountered this problem when redefined methods with lambda usage. > I run all existing tests with enabled logging and sanity verified error >

Withdrawn: 8254861: reformat code in vmTestbase/nsk/jdb

2020-12-17 Thread Igor Ignatyev
On Thu, 15 Oct 2020 22:47:43 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this patch which reformats/cleans up the code of > vmTestbase/nsk/jdb tests? > > the part of this patch is a spinoff from #350. > > testing: > * [x] `vmTestbase/nsk/jdb` tests on `linux-x64-debug`

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v8]

2020-12-17 Thread Mandy Chung
On Thu, 17 Dec 2020 04:59:17 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition

2020-12-17 Thread Coleen Phillimore
On Thu, 17 Dec 2020 16:10:29 GMT, Leonid Mesnik wrote: >> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 935: >> >>> 933:the_class->super()->name() != >>> 934:scratch_class->super()->name())) { >>> 935: log_trace(redefine, class, normalize) >> >> I think these would

Integrated: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings

2020-12-17 Thread Patricio Chilano Mateo
On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review the following small fix for test > RemovingUnixDomainSocketTest.java. As explained in the bug comments, the > issue is due to having two different StreamPumper objects consuming from the > same stderr,

Re: RFR: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings [v2]

2020-12-17 Thread Patricio Chilano Mateo
On Tue, 15 Dec 2020 20:52:36 GMT, Alex Menkov wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> include 'VM Warning' in stderr search > > Marked as reviewed by amenkov (Reviewer). Thanks @alexmenkov,

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition

2020-12-17 Thread Leonid Mesnik
On Thu, 17 Dec 2020 13:25:42 GMT, Coleen Phillimore wrote: >> The error code during class redefinition might be not enough to easily >> diagnose the problem. Some more logging might be useful to understand it. I >> encountered this problem when redefined methods with lambda usage. >> I run all

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition

2020-12-17 Thread Leonid Mesnik
On Thu, 17 Dec 2020 05:27:28 GMT, Chris Plummer wrote: >> The error code during class redefinition might be not enough to easily >> diagnose the problem. Some more logging might be useful to understand it. I >> encountered this problem when redefined methods with lambda usage. >> I run all

Re: RFR: 8258061: Improve diagnostic information about errors during class redefinition

2020-12-17 Thread Coleen Phillimore
On Thu, 17 Dec 2020 00:44:18 GMT, Leonid Mesnik wrote: > The error code during class redefinition might be not enough to easily > diagnose the problem. Some more logging might be useful to understand it. I > encountered this problem when redefined methods with lambda usage. > I run all